* [PATCH] net/gve: fix RSS hash endianness in DQO format
@ 2024-07-07 2:43 Shreesh Adiga
2024-07-07 22:23 ` Joshua Washington
0 siblings, 1 reply; 2+ messages in thread
From: Shreesh Adiga @ 2024-07-07 2:43 UTC (permalink / raw)
To: Jeroen de Borst, Rushil Gupta, Joshua Washington, Junfeng Guo; +Cc: stable
The hash field in struct gve_rx_compl_desc_dqo defined in
gve_desc_dqo.h has the type __le32. Therefore the hash must be
read in little endian rather than big endian.
Bugzilla ID: 1441
Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO")
Cc: junfeng.guo@intel.com
Cc: stable@dpdk.org
Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com>
---
drivers/net/gve/gve_rx_dqo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c
index f08b58c78d..5efcce3312 100644
--- a/drivers/net/gve/gve_rx_dqo.c
+++ b/drivers/net/gve/gve_rx_dqo.c
@@ -161,7 +161,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
rxm->ol_flags = 0;
rxm->ol_flags |= RTE_MBUF_F_RX_RSS_HASH |
gve_parse_csum_ol_flags(rx_desc, rxq->hw);
- rxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash);
+ rxm->hash.rss = rte_le_to_cpu_32(rx_desc->hash);
rx_pkts[nb_rx++] = rxm;
bytes += pkt_len;
--
2.44.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/gve: fix RSS hash endianness in DQO format
2024-07-07 2:43 [PATCH] net/gve: fix RSS hash endianness in DQO format Shreesh Adiga
@ 2024-07-07 22:23 ` Joshua Washington
0 siblings, 0 replies; 2+ messages in thread
From: Joshua Washington @ 2024-07-07 22:23 UTC (permalink / raw)
To: Shreesh Adiga; +Cc: Jeroen de Borst, Rushil Gupta, Junfeng Guo, dpdk stable
[-- Attachment #1: Type: text/plain, Size: 62 bytes --]
Reviewed-by: Joshua Washington <joshwash@google.com>
Thanks!
[-- Attachment #2: Type: text/html, Size: 170 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-07-07 22:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-07 2:43 [PATCH] net/gve: fix RSS hash endianness in DQO format Shreesh Adiga
2024-07-07 22:23 ` Joshua Washington
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).