From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [PATCH] net/cpfl: fix build error for debian 32-bit
Date: Wed, 10 Jul 2024 15:53:51 +0100 [thread overview]
Message-ID: <20240710145351.599031-1-bruce.richardson@intel.com> (raw)
When building for debian 11 32-bit, errors were reported with cpfl
driver[1]. The error is due to comparing signed and unsigned values:
../drivers/net/cpfl/cpfl_flow_parser.c:1699:29: error: comparison of
integer expressions of different signedness: 'long int' and
'uint32_t' {aka 'unsigned int'} [-Werror=sign-compare]
Fix the issue by using an explicitly cast for the return value from
atol.
Fixes: c10881d3ee74 ("net/cpfl: support flow prog action")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
[1] https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_11/i586
---
drivers/net/cpfl/cpfl_flow_parser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c
index a8f0488f21..40569ddc6f 100644
--- a/drivers/net/cpfl/cpfl_flow_parser.c
+++ b/drivers/net/cpfl/cpfl_flow_parser.c
@@ -1696,7 +1696,7 @@ cpfl_parse_check_prog_action(struct cpfl_flow_js_mr_key_action *key_act,
bool check_name;
check_name = key_act->prog.has_name ? strcmp(prog->name, key_act->prog.name) == 0
- : atol(prog->name) == key_act->prog.id;
+ : (uint32_t)atol(prog->name) == key_act->prog.id;
if (!check_name) {
PMD_DRV_LOG(ERR, "Not support this prog type: %s.", prog->name);
return -EINVAL;
--
2.43.0
next reply other threads:[~2024-07-10 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 14:53 Bruce Richardson [this message]
2024-07-10 15:07 ` David Marchand
2024-07-10 16:10 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240710145351.599031-1-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).