From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 17A0B455AD for ; Mon, 15 Jul 2024 17:31:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1387140E11; Mon, 15 Jul 2024 17:31:21 +0200 (CEST) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id 75D0740DFB for ; Mon, 15 Jul 2024 17:31:19 +0200 (CEST) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-4257d5fc9b7so34572935e9.2 for ; Mon, 15 Jul 2024 08:31:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721057479; x=1721662279; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XS3GWKxuiMEw3ZjjcYPQ7zWTqhhAbr2RcO/dnIijLgk=; b=LbRh02dmv6Fhu8Xor80VZRFe/vbKzP3GbDIVHtpM4Bpoixr583l8kcXeR+Pdo/98hY cpeXPnEanxRFz9PxCaisaFM5dLwXhG9HqsU6rx1rGrStG++zzOQU2zMd+CTrxowBsZkR 88peAWcGkC8T1bPDIV/dpUsmdKLujhU0KaAtp4M4kZ1spLZZTCpn4B1GPGctMK/YJiwe K3GHgnsswp/7QDO1dSn+4e8+1SIT7ehX8IXzYpsiRySedv/M223GaCa/wGd1lO+diMi7 VeIZ8j/t52XWnHbSFH3rxkHY3gksggNTxQ288Yc6nUjUr0iZndM89bqdnUwvZUHK4pi/ 0Csw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721057479; x=1721662279; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XS3GWKxuiMEw3ZjjcYPQ7zWTqhhAbr2RcO/dnIijLgk=; b=jMqcgf1Wp5xMhlfogn0I/Mk7oE2nFXMW08S9ve2cZpQW+ThtkTMypjlIMz4EiEUV0G IZ+0OZdivrZcJ1COoaX1OQRA0FJyd16JYkNO+7mZoeJtGjUZiwh0OuvRr0uj3ugqku89 iuHmuhnn5kqrJV4Wp/MkMq7d4x9a5AsxcBNbNkKUTUG0UmMHW0ZPf60UNj+Dc3zM5FZ2 svCJ5jcfCAznxOUvxXvI8+0PrtxR/OilxHyhogRFpcDr0Aw8u6uqD/I/NpaNT70EehAe eAtOGCgp5Of1lJku9V6uy5TUrgdHDPVVtPxj9VHsbHy8H6RqwSlExCqtYqVhTRCn8QE9 JXmA== X-Gm-Message-State: AOJu0Yye6T3cUH4JR8Jwfilw8ph8IxtLHzOeTYxdIatn7C3rUHO02sOm HWB+i1vzJlNBrP3XMEnjOzxDnoqY2zfEaupknrliyekOMLe8omEf X-Google-Smtp-Source: AGHT+IFNn4FKxqE1gxYkSAJjQndVP91QAUy9L+QPMG+gW9x3nt6W7wQlufPV2m99lhA9Akh12DGMnw== X-Received: by 2002:adf:fa12:0:b0:367:99fc:238a with SMTP id ffacd0b85a97d-368240887a4mr75160f8f.32.1721057478992; Mon, 15 Jul 2024 08:31:18 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4279f2397easm127088595e9.6.2024.07.15.08.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jul 2024 08:31:18 -0700 (PDT) From: luca.boccassi@gmail.com To: Shai Brandes Cc: dpdk stable Subject: patch 'net/ena: fix bad checksum handling' has been queued to stable release 22.11.6 Date: Mon, 15 Jul 2024 16:26:58 +0100 Message-Id: <20240715152704.2229503-80-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240715152704.2229503-1-luca.boccassi@gmail.com> References: <20240624235907.885628-81-luca.boccassi@gmail.com> <20240715152704.2229503-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/17/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/33ddd1e51dfebd10c239b596556d8d3a2153cd4d Thanks. Luca Boccassi --- >From 33ddd1e51dfebd10c239b596556d8d3a2153cd4d Mon Sep 17 00:00:00 2001 From: Shai Brandes Date: Tue, 2 Jul 2024 17:46:22 +0300 Subject: [PATCH] net/ena: fix bad checksum handling [ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] Removed a workaround for a false L4 bad Rx csum indication from the device. The workaround was to set it as unknown so the application would check it instead. The issue was fixed in the device, thus the driver bad csum handling should be fixed in the PMD. Fixes: b2d2f1cf89a6 ("net/ena: fix checksum flag for L4") Signed-off-by: Shai Brandes --- drivers/net/ena/ena_ethdev.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c index 29782a7fb6..2fcd74a0e0 100644 --- a/drivers/net/ena/ena_ethdev.c +++ b/drivers/net/ena/ena_ethdev.c @@ -595,13 +595,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, } else { if (unlikely(ena_rx_ctx->l4_csum_err)) { ++rx_stats->l4_csum_bad; - /* - * For the L4 Rx checksum offload the HW may indicate - * bad checksum although it's valid. Because of that, - * we're setting the UNKNOWN flag to let the app - * re-verify the checksum. - */ - ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN; + ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_BAD; } else { ++rx_stats->l4_csum_good; ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_GOOD; -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-15 16:19:38.568469863 +0100 +++ 0080-net-ena-fix-bad-checksum-handling.patch 2024-07-15 16:19:34.724209794 +0100 @@ -1 +1 @@ -From fa4bb7025255036fcff9556c637efa2627ac4af4 Mon Sep 17 00:00:00 2001 +From 33ddd1e51dfebd10c239b596556d8d3a2153cd4d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit fa4bb7025255036fcff9556c637efa2627ac4af4 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4e7171e629..b43b913903 100644 +index 29782a7fb6..2fcd74a0e0 100644 @@ -24 +25 @@ -@@ -674,13 +674,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring, +@@ -595,13 +595,7 @@ static inline void ena_rx_mbuf_prepare(struct ena_ring *rx_ring,