From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 439D9455AD
for <public@inbox.dpdk.org>; Mon, 15 Jul 2024 17:31:32 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 3DA4940DFB;
Mon, 15 Jul 2024 17:31:32 +0200 (CEST)
Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com
[209.85.221.41]) by mails.dpdk.org (Postfix) with ESMTP id D580C40A71
for <stable@dpdk.org>; Mon, 15 Jul 2024 17:31:30 +0200 (CEST)
Received: by mail-wr1-f41.google.com with SMTP id
ffacd0b85a97d-36794da7c96so868481f8f.0
for <stable@dpdk.org>; Mon, 15 Jul 2024 08:31:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1721057490; x=1721662290; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=aSSH57bzteNpUG/Cexpg4XV6sdp2o/IXPo27rd2XL4I=;
b=Q2rbMn7PbVYHngKjOfIeuBnEbNNuurY7SrgjXxwz07dm/htYOG0gR6uF+jo6CGDzOH
+yeD2rYgLK4wTYnIbi6ZPMRp/YRDCKeG19AOkRTv8LzYAOAw9FhSJEKl8sniKQFKbJ8d
z4hLoTz7eNGKDgRIzBjqkfP4Q2TH8ZBBphc698L0UJL6cVpGYdEs2823HDiOZEOjwl44
w7Nje949JVAIZRaGg4vlNfrAWU28YeBZ5FBfJdfxJZQA7i3zvDVGgAnO5MJY7YCGpqSd
ZKUBluD2nJWvQb8OrSCoVfW1ooc2oqLeRq/fdGpU2scPe0nrjRo1fWl2ZEVjXUwQmwHy
n9xA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1721057490; x=1721662290;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=aSSH57bzteNpUG/Cexpg4XV6sdp2o/IXPo27rd2XL4I=;
b=irg135jc0E64vbSPCyf9pgvbFoYtQPkoWVkrr21rZ9X3BF5c9hj4PvOZpfU/v06BmB
FCrW9Yoe0kxtl0xw30GZhBzaEFqqw9n+kbdzs9Yl64+fdcj551VHFBrhI3RM/pDiqogU
n6/pJIolGF+Q0K4RqXs3vRjcqt+37bFIKTvqQ3t7jdRH0LMGhrlgs7LjuHiZ35GD+t63
YiwSYVN7poHb0K7YYzGQq2vuLaC/n0ui9Mg2Oy439ESbqUKDQR349rILSlMJHQr+02Uy
vfY6BN6CMBe1wwoNlkSRYPtB9DLBVMC1Hv4aKLhy4rhaxArZ/t+AtPxIbXiGmVC43idZ
4KWg==
X-Gm-Message-State: AOJu0YyImEmCQuqIG+q26OvFlltbuWOs60JQoyPLWLzj2paCRoZNG7uk
o8x8f+a7rDorgTebtgVUSp26BnJAs7WH6oWuO9tn4upoS5SCJalW
X-Google-Smtp-Source: AGHT+IF0fgIITxwD9HltK851pzQsaegWkk5vrCIpx5Hfq7q1Y6x46yHy75bBR1l5UOj+uxGtBRj9uQ==
X-Received: by 2002:a05:6000:120d:b0:35f:f90:f383 with SMTP id
ffacd0b85a97d-368240caed9mr58013f8f.56.1721057490321;
Mon, 15 Jul 2024 08:31:30 -0700 (PDT)
Received: from localhost ([2a01:4b00:d036:ae00:7aef:1aaa:3dff:d546])
by smtp.gmail.com with ESMTPSA id
ffacd0b85a97d-3680dab3e71sm6713286f8f.12.2024.07.15.08.31.29
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Mon, 15 Jul 2024 08:31:29 -0700 (PDT)
From: luca.boccassi@gmail.com
To: Shai Brandes <shaibran@amazon.com>
Cc: dpdk stable <stable@dpdk.org>
Subject: patch 'net/ena: fix return value check' has been queued to stable
release 22.11.6
Date: Mon, 15 Jul 2024 16:26:59 +0100
Message-Id: <20240715152704.2229503-81-luca.boccassi@gmail.com>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20240715152704.2229503-1-luca.boccassi@gmail.com>
References: <20240624235907.885628-81-luca.boccassi@gmail.com>
<20240715152704.2229503-1-luca.boccassi@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
Hi,
FYI, your patch has been queued to stable release 22.11.6
Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet.
It will be pushed if I get no objections before 07/17/24. So please
shout if anyone has objections.
Also note that after the patch there's a diff of the upstream commit vs the
patch applied to the branch. This will indicate if there was any rebasing
needed to apply to the stable branch. If there were code changes for rebasing
(ie: not only metadata diffs), please double check that the rebase was
correctly done.
Queued patches are on a temporary branch at:
https://github.com/bluca/dpdk-stable
This queued commit can be viewed at:
https://github.com/bluca/dpdk-stable/commit/cf4bb6bffc2193d84dd26be22e1582b4218caf8f
Thanks.
Luca Boccassi
---
>From cf4bb6bffc2193d84dd26be22e1582b4218caf8f Mon Sep 17 00:00:00 2001
From: Shai Brandes <shaibran@amazon.com>
Date: Tue, 2 Jul 2024 17:46:23 +0300
Subject: [PATCH] net/ena: fix return value check
[ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ]
Removed the sign inversion for when checking if
ena_com_set_host_attributes returns ENA_COM_UNSUPPORTED.
ENA_COM_UNSUPPORTED is defined as -EOPNOTSUPP, so the extra sign
inversion is wrong.
Fixes: 3adcba9a8987 ("net/ena: update HAL to the newer version")
Signed-off-by: Shai Brandes <shaibran@amazon.com>
---
drivers/net/ena/ena_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ena/ena_ethdev.c b/drivers/net/ena/ena_ethdev.c
index 2fcd74a0e0..881e2ecdaf 100644
--- a/drivers/net/ena/ena_ethdev.c
+++ b/drivers/net/ena/ena_ethdev.c
@@ -733,7 +733,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev)
rc = ena_com_set_host_attributes(ena_dev);
if (rc) {
- if (rc == -ENA_COM_UNSUPPORTED)
+ if (rc == ENA_COM_UNSUPPORTED)
PMD_DRV_LOG(WARNING, "Cannot set host attributes\n");
else
PMD_DRV_LOG(ERR, "Cannot set host attributes\n");
@@ -773,7 +773,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter)
rc = ena_com_set_host_attributes(&adapter->ena_dev);
if (rc) {
- if (rc == -ENA_COM_UNSUPPORTED)
+ if (rc == ENA_COM_UNSUPPORTED)
PMD_DRV_LOG(WARNING, "Cannot set host attributes\n");
else
PMD_DRV_LOG(ERR, "Cannot set host attributes\n");
--
2.39.2
---
Diff of the applied patch vs upstream commit (please double-check if non-empty:
---
--- - 2024-07-15 16:19:38.612557630 +0100
+++ 0081-net-ena-fix-return-value-check.patch 2024-07-15 16:19:34.728209880 +0100
@@ -1 +1 @@
-From 8936b01a512a8e25a7369d282a17b9b09c55728b Mon Sep 17 00:00:00 2001
+From cf4bb6bffc2193d84dd26be22e1582b4218caf8f Mon Sep 17 00:00:00 2001
@@ -5,0 +6,2 @@
+[ upstream commit 8936b01a512a8e25a7369d282a17b9b09c55728b ]
+
@@ -12 +13,0 @@
-Cc: stable@dpdk.org
@@ -20 +21 @@
-index b43b913903..67a1d86f9a 100644
+index 2fcd74a0e0..881e2ecdaf 100644
@@ -23 +24 @@
-@@ -812,7 +812,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev)
+@@ -733,7 +733,7 @@ static void ena_config_host_info(struct ena_com_dev *ena_dev)
@@ -32 +33 @@
-@@ -856,7 +856,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter)
+@@ -773,7 +773,7 @@ static void ena_config_debug_area(struct ena_adapter *adapter)