From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DA5874569C for ; Wed, 24 Jul 2024 13:34:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4C00433B7; Wed, 24 Jul 2024 13:34:17 +0200 (CEST) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mails.dpdk.org (Postfix) with ESMTP id BE3DF42D28 for ; Wed, 24 Jul 2024 13:34:16 +0200 (CEST) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-4267345e746so50008095e9.0 for ; Wed, 24 Jul 2024 04:34:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1721820856; x=1722425656; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Odf+QyDh3YIefP1bncDVnC5u5/5OEBLTJB7z/RDGV0o=; b=fCTlVsPIPGELZdR61Ydczw0JyKfLc2r2MsmHurFhHoAdVl6r1QRgIgCHClh71BjPoN QotvVGe/020w7d1jlzyvu196WKZx0/QwlJsEkLGoxPAuAJN/IUpN18BVaO47BLrPQ0mG nbGzq3yo0PAjDUpJDbQYl3hEfWRgLJBsl0AuZcQx2PuxiFiHZ44gVBen53Sh2gpSe/B4 uJxzFMT1vIx1yV3qxj87CudzxznV7svQ4IlprwbvKQ1RA2TLS7XDbDDE7gKq8kmcyvqy EXT1AQwOnUQBuAgweB5conQVCP0QlEXAF0uefb7StMDtkeEuZIqauUnCIPMmQkIR+e1D iKNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1721820856; x=1722425656; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Odf+QyDh3YIefP1bncDVnC5u5/5OEBLTJB7z/RDGV0o=; b=fI8dgGfTycfrIj/gbLOJ2YnJeFX7JG6Mw3bydIVSxIywuHIcUu8lwTRl+RQb7ca9Jm FnE2QtH0J0SkqxhlqwFHCuwv/1YSrbPQ5J0/rjbjKhvdYjcK1H333GT2eoU8NaAojOBE p4LhfsbPMT6R4oKwds9HiwZ2GWZt1/nx4FRHUXf6ygyntQ+FQSfkmEGd6PRTRj6SfrbH a1gksA12TamkJOrr+89GAucRjluPHROy+J+h+cPQdnY8buErDrGKMkaBYYa3tMyPS7HD PGx0mDr7PsxukwW4PjRHGnK2AksK0AIoG9csZWLHRREBqb/QIX0WnHb3zft8IXi68L1w 6lcw== X-Forwarded-Encrypted: i=1; AJvYcCWigJRic9fCJIVifpXScD6Bs6dF8+cRntabec42ZvHV6Ff2OOIkUPE1PIB02FzgdmsLRQeEvEFuLJfzzio9CMU= X-Gm-Message-State: AOJu0YySY4heg9BMttIvfnrEacV9S4kWbD0dZW1HqmPdpMDCda/jWhQP mQ+QchM4D2TE4rgUi6MiYAW46prCicGyn5HCiNfPdeJpNvVOrHqgyfAYm828 X-Google-Smtp-Source: AGHT+IFSKKrTh+yR60GbjakiQvC8/UXYH28lLJZ19HeIk6cDvLMXojdZAS7omBYdzeWDxJxkGHEL/Q== X-Received: by 2002:a05:600c:3b21:b0:427:d740:f38c with SMTP id 5b1f17b1804b1-427dd0e82dcmr80917995e9.17.1721820856262; Wed, 24 Jul 2024 04:34:16 -0700 (PDT) Received: from localhost ([137.220.120.171]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-368787cf182sm14145049f8f.82.2024.07.24.04.34.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jul 2024 04:34:15 -0700 (PDT) From: luca.boccassi@gmail.com To: Bing Zhao Cc: Viacheslav Ovsiienko , dpdk stable Subject: patch 'common/mlx5: remove unneeded field when modify RQ table' has been queued to stable release 22.11.6 Date: Wed, 24 Jul 2024 12:32:56 +0100 Message-Id: <20240724113318.616754-18-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240724113318.616754-1-luca.boccassi@gmail.com> References: <20240715152704.2229503-86-luca.boccassi@gmail.com> <20240724113318.616754-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.6 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 07/26/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d69a8b5eb2badb1c7998948c4b80a96f5312dd03 Thanks. Luca Boccassi --- >From d69a8b5eb2badb1c7998948c4b80a96f5312dd03 Mon Sep 17 00:00:00 2001 From: Bing Zhao Date: Wed, 17 Jul 2024 19:37:19 +0300 Subject: [PATCH] common/mlx5: remove unneeded field when modify RQ table [ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] The attribute "rqt_max_size" of the RQT(RQ table) context is only needed by when creating a new one. When modifying an old one, there is no need to set this attribute. The firmware usually ignored this unneeded field. When enabling some extra check, an error will be returned to prevent the code from continuing to run. In the meanwhile, this field will always be set to the maximal one fetched from the capability without any change. Removing the value set and leave it to 0 will help to solve the potential failure. Fixes: e1da60a8a6e9 ("common/mlx5: add DevX command to modify RQT") Signed-off-by: Bing Zhao Acked-by: Viacheslav Ovsiienko --- drivers/common/mlx5/mlx5_devx_cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c index f44be4c230..9a0fc3501d 100644 --- a/drivers/common/mlx5/mlx5_devx_cmds.c +++ b/drivers/common/mlx5/mlx5_devx_cmds.c @@ -1727,7 +1727,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, MLX5_SET64(modify_rqt_in, in, modify_bitmask, 0x1); rqt_ctx = MLX5_ADDR_OF(modify_rqt_in, in, rqt_context); MLX5_SET(rqtc, rqt_ctx, list_q_type, rqt_attr->rq_type); - MLX5_SET(rqtc, rqt_ctx, rqt_max_size, rqt_attr->rqt_max_size); MLX5_SET(rqtc, rqt_ctx, rqt_actual_size, rqt_attr->rqt_actual_size); for (i = 0; i < rqt_attr->rqt_actual_size; i++) MLX5_SET(rqtc, rqt_ctx, rq_num[i], rqt_attr->rq_list[i]); -- 2.39.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-07-24 12:29:22.150969008 +0100 +++ 0018-common-mlx5-remove-unneeded-field-when-modify-RQ-tab.patch 2024-07-24 12:29:20.735025406 +0100 @@ -1 +1 @@ -From 463e5abe09362f1d20d0ec99b5969549d51167d6 Mon Sep 17 00:00:00 2001 +From d69a8b5eb2badb1c7998948c4b80a96f5312dd03 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 463e5abe09362f1d20d0ec99b5969549d51167d6 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 8e12ac50de..9710dcedd3 100644 +index f44be4c230..9a0fc3501d 100644 @@ -31 +32 @@ -@@ -1914,7 +1914,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt, +@@ -1727,7 +1727,6 @@ mlx5_devx_cmd_modify_rqt(struct mlx5_devx_obj *rqt,