From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33B6245798 for ; Sun, 11 Aug 2024 18:00:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 27E14402C6; Sun, 11 Aug 2024 18:00:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 7E543400D5; Sun, 11 Aug 2024 18:00:07 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 47BESWk3026317; Sun, 11 Aug 2024 09:00:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=pfpt0220; bh=Q fpmDrEcz4WbILZau+TgyHHvu4aJIx1bsFXrOyAew8k=; b=ikh75WZyCC+sLM8nA glGS/SJp5ZbxxngM9wR+E77JrMCpLjK+Pxxm2cW2DTjq3cuXc+Abc/mJx2EVvFdu olvox7gXC8Lm9kaIihGMhVKkgJXO9ZYzdRZ0OLg3tvyi26GyKMVvgyBSEqk0ncKm 2MIoTgAUMU7TxZ7R29NaNskr8eyoyYVUwAC62EZl7nt6TLD93FODPKWymhtT9dGw uBJS/MXMQomrphB8xA6BEpu+e5mTlXjg67r04lnbJXrWMOVys6sGBPrOhOTO3kac EzA7zcOvUVde8ldgemt8KSN8go5qfNw7OR6MjX7rNCGuAxMm/7MorfeQoreTqo9V CIvtQ== Received: from dc6wp-exch02.marvell.com ([4.21.29.225]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 40xqkyru8b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 Aug 2024 09:00:04 -0700 (PDT) Received: from DC6WP-EXCH02.marvell.com (10.76.176.209) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 11 Aug 2024 09:00:02 -0700 Received: from maili.marvell.com (10.69.176.80) by DC6WP-EXCH02.marvell.com (10.76.176.209) with Microsoft SMTP Server id 15.2.1544.4 via Frontend Transport; Sun, 11 Aug 2024 09:00:02 -0700 Received: from localhost.localdomain (unknown [10.28.36.154]) by maili.marvell.com (Postfix) with ESMTP id BE36F3F7062; Sun, 11 Aug 2024 08:59:59 -0700 (PDT) From: Rakesh Kudurumalla To: , , , CC: , , , "Rakesh Kudurumalla" , Subject: [PATCH v5 1/1] examples/l2fwd-jobstats: fix lock availability Date: Sun, 11 Aug 2024 21:29:57 +0530 Message-ID: <20240811155957.576645-1-rkudurumalla@marvell.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240811065819.575759-1-rkudurumalla@marvell.com> References: <20240811065819.575759-1-rkudurumalla@marvell.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Proofpoint-ORIG-GUID: 8YL-qubcdN-7dKkpU4FntRm_FXnymQHf X-Proofpoint-GUID: 8YL-qubcdN-7dKkpU4FntRm_FXnymQHf X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1039,Hydra:6.0.680,FMLib:17.12.28.16 definitions=2024-08-11_14,2024-08-07_01,2024-05-17_01 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Race condition between jobstats and time metrics for forwarding and flushing is maintained using spinlock. Timer metrics are not displayed properly due to the frequent unavailability of the lock.This patch fixes the issue by introducing a delay before acquiring the lock in the loop. This delay allows for betteravailability of the lock, ensuring that show_lcore_stats() can periodically update the statistics even when forwarding jobs are running. Fixes: 204896f8d66c ("examples/l2fwd-jobstats: add new example") Cc: stable@dpdk.org Signed-off-by: Rakesh Kudurumalla --- v5: updated cause of issue in commit message examples/l2fwd-jobstats/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l2fwd-jobstats/main.c b/examples/l2fwd-jobstats/main.c index 308b8edd20..7bb38b290f 100644 --- a/examples/l2fwd-jobstats/main.c +++ b/examples/l2fwd-jobstats/main.c @@ -542,7 +542,7 @@ l2fwd_main_loop(void) } while (likely(stats_read_pending == 0)); rte_spinlock_unlock(&qconf->lock); - rte_pause(); + rte_delay_us(10); } /* >8 End of minimize impact of stats reading. */ } -- 2.25.1