From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A462F45A50
	for <public@inbox.dpdk.org>; Sat, 28 Sep 2024 18:48:51 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1CD2340698;
	Sat, 28 Sep 2024 18:48:45 +0200 (CEST)
Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com
 [209.85.214.176])
 by mails.dpdk.org (Postfix) with ESMTP id D276640616
 for <stable@dpdk.org>; Sat, 28 Sep 2024 18:48:35 +0200 (CEST)
Received: by mail-pl1-f176.google.com with SMTP id
 d9443c01a7336-205659dc63aso29493155ad.1
 for <stable@dpdk.org>; Sat, 28 Sep 2024 09:48:35 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727542115;
 x=1728146915; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=;
 b=igv7H2LGr40PrX5C7PPQvmJLSQgVopDkrd4Lp94/mVsEuSHk7J3J1l3r6pPSf+c1Na
 Z3mAZnc43sPH2XnlIRpp20mRbSHrv9jbhoPxJvVOKMrf7Yv867fthB/pY2x0IvnsqQ7w
 OBERIkaKNT5G4tpgeSK0KS8lXac0l3M4PhibZVAmz4R+L8yOqaOtdBPTGHUEgGyIfUPz
 qacPN7H2PhvzwfcK19290Cv0xbvao0inebZZZpsLZR3UlYoGuICR80AONjGvm1K8OGSj
 6rO2mmJWIQNFXqEZteA85cUgqo8A6VGaxk8lHjsGFLIb+z3n0ts+45V3Da5bm8jMk5Ud
 ly/A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727542115; x=1728146915;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=;
 b=mm5Me0VO+mufMlCwvhlewDj+zD6WNRLs7KNsWS4MGluU8fiXcBFQWeobQhUOHosMU4
 CRDwGGwmdI9qCfFvTwFsVbhP1/isv2KOci4IN8jOcxPxR8LQYDxjIca6+xbw/9c5k5jb
 7OdEPvTuMOZXiNMqntzDCg+8WY2mWeGf7sFMVyX4DjXHK0hlFAMs52ykdzww08vYsDFs
 ymAIBx5XZirEbwlRboPY4t6BLmEgLv0uPGs9Wc5G5Wk9dt55dCdwyEETujZN3i8Ot9zg
 haI8QqhmbK4pHoCWUAd24rQpIOu3cR+go4zB/zJddOv5ohxN+isuNeMQX9rPwfxByoLM
 O15g==
X-Forwarded-Encrypted: i=1;
 AJvYcCUoCk1hl9l64ni0WClgf55DA9Q1+za+XBU6ZjZnHQWpukm70E8KkeTZQfKFCOaJsBEfrFL1WEY=@dpdk.org
X-Gm-Message-State: AOJu0YxFs0GrzIV4qlTM1dUqDMvW4itE0a0Mhy8K2dtwl7cuBovD/hbK
 sDBETJn+rtW4iDlO6zHqV2iLHyN9QVDeB0BErOJi/KogHOJ50ay814YFxSDxEMA=
X-Google-Smtp-Source: AGHT+IH/qgzXbp8zuaPZc0ETJFx23qPLhwFdw7wySEEWkn7GBMDnYY0desEFfbO/hbeCz7bn3/BlDQ==
X-Received: by 2002:a17:902:d4c2:b0:207:13a3:a896 with SMTP id
 d9443c01a7336-20b369d605fmr95182015ad.23.1727542115024; 
 Sat, 28 Sep 2024 09:48:35 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-20b37e47c7dsm28854015ad.216.2024.09.28.09.48.34
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 28 Sep 2024 09:48:34 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, wenjing.qiao@intel.com,
 stable@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>
Subject: [PATCH v2 11/16] net/cpfl: fix free of nonheap object
Date: Sat, 28 Sep 2024 09:47:19 -0700
Message-ID: <20240928164814.861933-12-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20240928164814.861933-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20240928164814.861933-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

With proper annotation, GCC discovers that this driver is
calling rte_free() on an object that was not allocated
(it is part of array in another object).

In function ‘cpfl_flow_js_mr_layout’,
    inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9,
    inlined from ‘cpfl_flow_js_mod_rule’ at ../drivers/net/cpfl/cpfl_flow_parser.c:908:9,
    inlined from ‘cpfl_parser_init’ at ../drivers/net/cpfl/cpfl_flow_parser.c:932:8,
    inlined from ‘cpfl_parser_create’ at ../drivers/net/cpfl/cpfl_flow_parser.c:959:8:
../drivers/net/cpfl/cpfl_flow_parser.c:740:9: warning: ‘rte_free’ called on pointer ‘*parser.modifications’ with nonzero offset [28, 15479062120396] [-Wfree-nonheap-object]
  740 |         rte_free(js_mod->layout);
      |         ^~~~~~~~~~~~~~~~~~~~~~~~

Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON")
Cc: wenjing.qiao@intel.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cpfl/cpfl_flow_parser.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c
index 40569ddc6f..30abaad7c8 100644
--- a/drivers/net/cpfl/cpfl_flow_parser.c
+++ b/drivers/net/cpfl/cpfl_flow_parser.c
@@ -737,7 +737,6 @@ cpfl_flow_js_mr_layout(json_t *ob_layouts, struct cpfl_flow_js_mr_action_mod *js
 	return 0;
 
 err:
-	rte_free(js_mod->layout);
 	return -EINVAL;
 }
 
-- 
2.45.2