From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B80A345A6D for ; Mon, 30 Sep 2024 20:46:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0D0DC40A7A; Mon, 30 Sep 2024 20:46:29 +0200 (CEST) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id 88D5C4066D for ; Mon, 30 Sep 2024 20:46:19 +0200 (CEST) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-6bce380eb96so2784296a12.0 for ; Mon, 30 Sep 2024 11:46:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727721979; x=1728326779; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=; b=x6X5q6pMpuP/FeWaboo+PFV3qrACO4F+xkvHN2mgQ6crRU1cP/nVkCm9rylGUHVcdh yr2cj+lQhSl+7NnE7Vm8Z/rrIc4VV1elly+eu5eSvjBg4m0LlPoDeDOVtXzjkv7A7cub 7g2v9ProXxzmJl8VCwr1AqhzSIv2XGuxRafiWDtVl2SX88utSdtDxptjG4SwnuZYNZvU ezpyn9iy+WxR1aq46wnmLb2QPsDqdMyQJolbdGgZnnd0h2FtuscBnOHH00bOw1xfMNYe Ci6vPlIeIKcM4lqve372GvLo91dt/bpKOtVk6fklPbYSLs2SR31bCKlbFnlkQNSuWz0K MDqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727721979; x=1728326779; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5rIUygztSKBo8hXRl59YcTQfr34c1sPRuIObTaqdxdQ=; b=j6ngoy3O/aXSZ1xxr1lAqkbjTUo4+ebXgxI7YQq+Y4D4wk7Gh0CAHKUSfttlX/SZqJ sqp6KcVU4i9r0YokCIh3xiQUxG0zM80v1v87Zn1k7TUg3qO+Ytbmcl72ioc5HaM3Qf/+ jM5nGE5gEfSRU//XpmtN7vExRRI68ilIqrkWwPag9OLsue1WHyfmWHv8ukiIOB/8YIzx q7Mf3HldxDqeWF1Ux+2KpnnW6E8GC7WxJd5FICy+flJaebg+dzE9bMQdIpKNeDcwsrIe he3Wtb1p0Jrgs9PNPswKkwig6wMeOzxdbyOkUajlsZk6AS2XAa4XcmvhUC1+nj9O1op3 08dA== X-Forwarded-Encrypted: i=1; AJvYcCWY+UmSCzkpdLK66YzY0fWQpr3xhD21WZ0CrxB15k/FutmaZXMKVX806utTws6NFX6dUFDOXe4=@dpdk.org X-Gm-Message-State: AOJu0Ywdh66RmHQorItFASeXlUEqxw85X1LYSkeqZbMpFcvKPAWwgJwf 1modhvdsnN4GZLD8EC/bAquF1PUSuWyDxtzLCTXcoWBZ1xnHDRSq2DnS680SfsQ= X-Google-Smtp-Source: AGHT+IEbRO+rWFdvP7xdwMFhG5rxcfuYhjx+iFreDFuEubRgUO36wv3uP6ngDmBATT2hnZGQnaDeGg== X-Received: by 2002:a05:6a20:c797:b0:1d2:e78a:36a2 with SMTP id adf61e73a8af0-1d4fa64d7acmr16989071637.8.1727721978744; Mon, 30 Sep 2024 11:46:18 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71b264bcca6sm6581895b3a.78.2024.09.30.11.46.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Sep 2024 11:46:18 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , wenjing.qiao@intel.com, stable@dpdk.org, Qi Zhang Subject: [PATCH v4 10/17] net/cpfl: fix free of nonheap object Date: Mon, 30 Sep 2024 11:44:04 -0700 Message-ID: <20240930184600.7092-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240930184600.7092-1-stephen@networkplumber.org> References: <20240927204742.546164-1-stephen@networkplumber.org> <20240930184600.7092-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org With proper annotation, GCC discovers that this driver is calling rte_free() on an object that was not allocated (it is part of array in another object). In function ‘cpfl_flow_js_mr_layout’, inlined from ‘cpfl_flow_js_mr_action’ at ../drivers/net/cpfl/cpfl_flow_parser.c:848:9, inlined from ‘cpfl_flow_js_mod_rule’ at ../drivers/net/cpfl/cpfl_flow_parser.c:908:9, inlined from ‘cpfl_parser_init’ at ../drivers/net/cpfl/cpfl_flow_parser.c:932:8, inlined from ‘cpfl_parser_create’ at ../drivers/net/cpfl/cpfl_flow_parser.c:959:8: ../drivers/net/cpfl/cpfl_flow_parser.c:740:9: warning: ‘rte_free’ called on pointer ‘*parser.modifications’ with nonzero offset [28, 15479062120396] [-Wfree-nonheap-object] 740 | rte_free(js_mod->layout); | ^~~~~~~~~~~~~~~~~~~~~~~~ Fixes: 6cc97c9971d7 ("net/cpfl: build action mapping rules from JSON") Cc: wenjing.qiao@intel.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- drivers/net/cpfl/cpfl_flow_parser.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/cpfl/cpfl_flow_parser.c b/drivers/net/cpfl/cpfl_flow_parser.c index 40569ddc6f..30abaad7c8 100644 --- a/drivers/net/cpfl/cpfl_flow_parser.c +++ b/drivers/net/cpfl/cpfl_flow_parser.c @@ -737,7 +737,6 @@ cpfl_flow_js_mr_layout(json_t *ob_layouts, struct cpfl_flow_js_mr_action_mod *js return 0; err: - rte_free(js_mod->layout); return -EINVAL; } -- 2.45.2