From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA4EB45A9D
	for <public@inbox.dpdk.org>; Wed,  2 Oct 2024 17:44:46 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C6EEF4064C;
	Wed,  2 Oct 2024 17:44:45 +0200 (CEST)
Received: from mail-oi1-f180.google.com (mail-oi1-f180.google.com
 [209.85.167.180])
 by mails.dpdk.org (Postfix) with ESMTP id 663E4402E9
 for <stable@dpdk.org>; Wed,  2 Oct 2024 17:44:42 +0200 (CEST)
Received: by mail-oi1-f180.google.com with SMTP id
 5614622812f47-3e03b6d99c3so6650b6e.0
 for <stable@dpdk.org>; Wed, 02 Oct 2024 08:44:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727883881;
 x=1728488681; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=HCt/WQI5sO7axY3DHorG5Ls6zAF7xLHZak77QAgDqKo=;
 b=q2jO4Y/kmDH+C2mtpwO2v6I2YUNziQd/GDTZq9hGW4ATaWmZQhNltxEqxSpiyLmmJz
 gyF2PEb8jvRYN2XRa1OIfH9o6wNwmLT1wjshRlzIHQJkqUqkrJSuSWY/J4RlzkuW+pRi
 ygDqNWoeCxWJdukmi1SmvemldHE1L7q+z6lCC2DBNr8wkoETCqIsEaklFI0IVIy6Mz4f
 o8iWNWX5UXimMNL1XUxkfWpLbNtMo/bFQms8DoWJGT/aA9Bvm6qvLYGmN9II0Hfjdk/u
 BA6Oy/6zLy8du55Y1Pegf+N7Sa2UCgrYE+xhhHNoPFmntEgnyCkxaauvLtWf1UvB1RO7
 Uc8g==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727883881; x=1728488681;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=HCt/WQI5sO7axY3DHorG5Ls6zAF7xLHZak77QAgDqKo=;
 b=gbnrWrWeuldL618lxTMWtDFqKiRCNYeDuWK4GDxBmJK8R/A9ZKpSN0wbn8IYnhyrHa
 VH70H+zhxdhoEzUtbGXci8y2esucGcZukySZe8Wy6EMXgbqSchmTsihdQGlbxQk3Bbf8
 emae9vhPvmO8ENlQeM5luIR9OA0NaAjghIqPiauXQ33NmSLLYuQ6JeMqjLU9aL0XIbYP
 R2uaMS8aXHE+CNbEv/+5uFx23P7fCufLmlKfsN+Mrk5UajBowzDuW8Ssj8x0YFqyglSg
 +Hr1xkBsE3fELpWADnzlTZEG4SRN/+NHS8i/GoXLM91D2YSv/HJy25A0FhAEGnRHfAHS
 hsSg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWwBLb9qvfGfKweDtDe5N3KNixDgPuRYEftXnlGt5YNFP2dmgTU8j4Xpr73qr1No702vsnwQ6k=@dpdk.org
X-Gm-Message-State: AOJu0Yx4xd3Elck3rF43OEkYon6izILIZuV+gcmT8kkxt3SCw/uYFKbq
 GzktwYD89AgvHZOMsE9aCVYxMimJWLzoPNsbyV62zRLkz9JXB6+pTfFs8V8eXzg=
X-Google-Smtp-Source: AGHT+IEAnaGlPY+NX81hI7lqO3JRCprdw7kaq+/LzobbLYRitFwV0ZeccAz/OVASU4IRU3paRCfU3g==
X-Received: by 2002:a05:6808:17a6:b0:3e3:a923:5208 with SMTP id
 5614622812f47-3e3b40ece81mr3277562b6e.2.1727883881599; 
 Wed, 02 Oct 2024 08:44:41 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 41be03b00d2f7-7e6db2927c7sm10247363a12.1.2024.10.02.08.44.40
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 02 Oct 2024 08:44:41 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, kevin.laatz@intel.com,
 stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Conor Walsh <conor.walsh@intel.com>
Subject: [PATCH v6 03/17] dma/ixd: fix incorrect free function in cleanup
Date: Wed,  2 Oct 2024 08:42:47 -0700
Message-ID: <20241002154429.64357-4-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241002154429.64357-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20241002154429.64357-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

The data structure is allocated with rte_malloc and incorrectly
freed in cleanup logic using free.

Bugzilla ID: 1549
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: kevin.laatz@intel.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/dma/idxd/idxd_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c
index 81637d9420..f89e2b41ff 100644
--- a/drivers/dma/idxd/idxd_pci.c
+++ b/drivers/dma/idxd/idxd_pci.c
@@ -301,7 +301,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,
 	return nb_wqs;
 
 err:
-	free(pci);
+	rte_free(pci);
 	return err_code;
 }
 
-- 
2.45.2