From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id ACEE145A9D
	for <public@inbox.dpdk.org>; Wed,  2 Oct 2024 17:44:51 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id CD95C40665;
	Wed,  2 Oct 2024 17:44:48 +0200 (CEST)
Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com
 [209.85.167.178])
 by mails.dpdk.org (Postfix) with ESMTP id C9DA74064A
 for <stable@dpdk.org>; Wed,  2 Oct 2024 17:44:44 +0200 (CEST)
Received: by mail-oi1-f178.google.com with SMTP id
 5614622812f47-3e03974b6a5so3706123b6e.3
 for <stable@dpdk.org>; Wed, 02 Oct 2024 08:44:44 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727883884;
 x=1728488684; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=OCC/7pypcVANnAzLwv1ykHuWe7RDnUwbh8hT6nfkbJU=;
 b=Fq8bRgDDO8UTKtdSyZ80a8OA3QAKYAt9Bo7J6FEaZjemNoUmioXqpVmP0VtB0QFOK1
 VskUm3yk/wAQIBErTIKbaV43LOjfLkTuAmEBny6coFpurfVl7ncq3NXTJyTjm2zSQ8Pw
 5LaZi8taWfsqqvCwQFgso3prVRGKYjkP/ar/S3HrmQ0iORNS9o2oYiRfEjOdsFVswfL5
 BDqKgxqS0YBOSyUM4s+Q34c994znGD4a+0ZCAbhsYoXOPFgyt/cO4z3tC3hhuqMYSZE4
 NAmaLZ6NoGI7kfX23+bxnxVFS4GhNcVxDYX1jSvjDxh8QlZzx25ScZC6vn6wiqMu2ckQ
 wHiw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727883884; x=1728488684;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=OCC/7pypcVANnAzLwv1ykHuWe7RDnUwbh8hT6nfkbJU=;
 b=lk1JUL5b3WY6T5P2DzwScbElxbUN+48Gp5NM/UCB2i6dvzGiq49/FcvXr6uXW1e8Uw
 xTSiXmwkic97E8tsz+5d+iI2bfYivBsaCqes8ptgGlccRgCGlsGQfa8UBHaGCbrH4vAb
 NPlvkKTMG0Ipi1G4m/SzhlkVevqRew7oR6cknykn4un9ZfFpyRkLxFk/loFqDkPpGJ2h
 A9ajuj1AXw1kefSloEnjBXieYceo2g0pwGYhzQCGE2EiEaJrQUHLHS3Sbak8f5aRz92x
 mBHvUcl9laxp7hhUvKwPYgaqepbgl95fRHOMEw+CcpgG/IvGkJPbweXZ+fhc03H3QGEc
 e9CA==
X-Forwarded-Encrypted: i=1;
 AJvYcCWtjkHS1m/9ZOk4UhspPRlr7wXfiOGanO1IlMJs1DjL9GDpbDIRwr1uzCwJNMqASNYFQR0z4xo=@dpdk.org
X-Gm-Message-State: AOJu0Yye93EDqOXeDTU1jMURzVUN+cg5UE8jteWIt9Qek/xO5c1xHK7E
 zeLo3BSZrcTGmVlNnfQBr8TVxl455MuxayCvobO4QN5+bT6JU3FH/tKG3pyJ3g4=
X-Google-Smtp-Source: AGHT+IF7hgBV3UIUkAod3+1LheqZghlBlwqOlSQ73kMEsXspLWgfnYb0Tmx9jX6CVDddIqVXZWJVbQ==
X-Received: by 2002:a05:6808:14c7:b0:3da:b35d:52e0 with SMTP id
 5614622812f47-3e3b4194bbfmr2539547b6e.43.1727883884160; 
 Wed, 02 Oct 2024 08:44:44 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 41be03b00d2f7-7e6db2927c7sm10247363a12.1.2024.10.02.08.44.43
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 02 Oct 2024 08:44:43 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, rbhansali@marvell.com,
 stable@dpdk.org, Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>,
 Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,
 Harman Kalra <hkalra@marvell.com>
Subject: [PATCH v6 06/17] net/cnxk: fix use-after-free
Date: Wed,  2 Oct 2024 08:42:50 -0700
Message-ID: <20241002154429.64357-7-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241002154429.64357-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20241002154429.64357-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

The driver would refer to the mempool object after it was freed.

Bugzilla ID: 1554
Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF")
Cc: rbhansali@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cnxk/cnxk_ethdev_sec.c b/drivers/net/cnxk/cnxk_ethdev_sec.c
index 6f5319e534..e428d2115d 100644
--- a/drivers/net/cnxk/cnxk_ethdev_sec.c
+++ b/drivers/net/cnxk/cnxk_ethdev_sec.c
@@ -136,8 +136,8 @@ cnxk_nix_inl_custom_meta_pool_cb(uintptr_t pmpool, uintptr_t *mpool, const char
 			return -EINVAL;
 		}
 
-		rte_mempool_free(hp);
 		plt_free(hp->pool_config);
+		rte_mempool_free(hp);
 
 		*aura_handle = 0;
 		*mpool = 0;
-- 
2.45.2