From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 4D45745A9F
	for <public@inbox.dpdk.org>; Wed,  2 Oct 2024 20:39:44 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C0DF940691;
	Wed,  2 Oct 2024 20:39:40 +0200 (CEST)
Received: from mail-pg1-f170.google.com (mail-pg1-f170.google.com
 [209.85.215.170])
 by mails.dpdk.org (Postfix) with ESMTP id A72294064C
 for <stable@dpdk.org>; Wed,  2 Oct 2024 20:39:33 +0200 (CEST)
Received: by mail-pg1-f170.google.com with SMTP id
 41be03b00d2f7-7d7a9200947so39582a12.3
 for <stable@dpdk.org>; Wed, 02 Oct 2024 11:39:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727894373;
 x=1728499173; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=OCC/7pypcVANnAzLwv1ykHuWe7RDnUwbh8hT6nfkbJU=;
 b=cgFWOa5HZ4INUzW3fvpDq2nyy2VTL6w4I+2AeEwqBKy1NtXm0fjFdK3Ea2/deE0hUe
 5BkLLnPNK9GAXy/T6lUoiza9VbLye0GjHZx2ZwClPnDajWhI7iugWHF++TkcVadQXsb9
 Kltl7MjRDNGHNneH3nVFQ5sWlh6I+sB0K9CtLtMha9VwaUj912+EVl2TTOIi0WO9eRKN
 TYw0nIxDXmV8/O8nYVcaGQgODqC1HVhiaPWi4/Zl4ixnGo/JfQ5yr6V4O4nRFRoTXnaC
 Uhq+yDl6US9TMSPyAqJegUQRp9BMzkC6I41/NCpCQlLcacI3mmxTzofMy4nN+sXxeoUo
 eBLg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1727894373; x=1728499173;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=OCC/7pypcVANnAzLwv1ykHuWe7RDnUwbh8hT6nfkbJU=;
 b=AUSpF+GBu9HLkqsmtXb9OGz7cQQIaQOGG/zijIMk+ZhfT2h13fuhJOZ2u7rW1l7jB8
 W/9/YgoyJPrkRGTZ65gGb1CkW9vK75wGysji1D/KuePmYXdNYcrcirspapWeqENFP7wJ
 ClxC1RKGbWoIUE8P5AC6hxrR7zpNeJuzGYaMLmkY872yN3zMpfUkiB6wk+/Rg6FnJ+48
 qNCPHFh61j+/3aotkXOtcaAnPuNl026vxRHXhBJJ8mon09pqIdYVLBRdh6ILrTNX/ElU
 JhpubGenxnCrHQmyB53lR8e0yQnGKjTEJ8eOwkBCkNDDugh9t6fa9SF+3LbESqfg7oGT
 Ctvg==
X-Forwarded-Encrypted: i=1;
 AJvYcCWkYbw+s8hJLgx/U7oipN7ssKu2YVgwy7qqVQfNIyY3lAgMXXrQh5ijl4eN20+v6etcg/08Vn8=@dpdk.org
X-Gm-Message-State: AOJu0YwRamALrulgC39CKZWsNl8xvaa5qBFxxtehuqvqU/JMfqoX7g7C
 eUCRgWnMHBk0SfKkNBqdRvwTauVbE37DslOvjQYx5rGmu05BQwxPB2HlAwpvX/A=
X-Google-Smtp-Source: AGHT+IHAdUJgO5oIx9RsPbegwkcAkk+1uPBinbVzcjKrY6yQprOal9K/ZP72Yu3V9FCqOgNTqPxaXA==
X-Received: by 2002:a05:6a20:1d98:b0:1d1:21a8:ee8d with SMTP id
 adf61e73a8af0-1d5e2ca20e0mr5172426637.22.1727894372872; 
 Wed, 02 Oct 2024 11:39:32 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d2e1a72fcca58-71b2649b0bdsm10104362b3a.34.2024.10.02.11.39.32
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 02 Oct 2024 11:39:32 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, rbhansali@marvell.com,
 stable@dpdk.org, Nithin Dabilpuram <ndabilpuram@marvell.com>,
 Kiran Kumar K <kirankumark@marvell.com>,
 Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,
 Harman Kalra <hkalra@marvell.com>
Subject: [PATCH v7 06/16] net/cnxk: fix use-after-free
Date: Wed,  2 Oct 2024 11:37:44 -0700
Message-ID: <20241002183918.161656-7-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241002183918.161656-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20241002183918.161656-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

The driver would refer to the mempool object after it was freed.

Bugzilla ID: 1554
Fixes: 7ea187184a51 ("common/cnxk: support 1-N pool-aura per NIX LF")
Cc: rbhansali@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cnxk/cnxk_ethdev_sec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/cnxk/cnxk_ethdev_sec.c b/drivers/net/cnxk/cnxk_ethdev_sec.c
index 6f5319e534..e428d2115d 100644
--- a/drivers/net/cnxk/cnxk_ethdev_sec.c
+++ b/drivers/net/cnxk/cnxk_ethdev_sec.c
@@ -136,8 +136,8 @@ cnxk_nix_inl_custom_meta_pool_cb(uintptr_t pmpool, uintptr_t *mpool, const char
 			return -EINVAL;
 		}
 
-		rte_mempool_free(hp);
 		plt_free(hp->pool_config);
+		rte_mempool_free(hp);
 
 		*aura_handle = 0;
 		*mpool = 0;
-- 
2.45.2