From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D368245AA2 for ; Thu, 3 Oct 2024 21:15:03 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C6CD84065C; Thu, 3 Oct 2024 21:15:03 +0200 (CEST) Received: from mail-yw1-f181.google.com (mail-yw1-f181.google.com [209.85.128.181]) by mails.dpdk.org (Postfix) with ESMTP id 05F7D40156 for ; Thu, 3 Oct 2024 21:15:01 +0200 (CEST) Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-6e25f3748e0so15023217b3.0 for ; Thu, 03 Oct 2024 12:15:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1727982900; x=1728587700; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=h8dorIdrbdsDXvnwTp/xWktFMKZ+/T0BwIXwAgwlxFA=; b=T5VikpzufDjIREVr3z1CVeQ6MW7GG0FiOcMTbHb8fUT0co4OS4ckN46QD/GITg1bfv I6Vb4uj20jsgchwsgQrYbpeZJwxvkShYQ/bFWGQY0gajFRdWb4zItL8unVnKBqhLclnE fOmrOu+DBKmtUb36XK4ShixcizIIsV1rYcQ3b9HftgQVTNv2c8f7kGU6qiMXppIR/mXv BnDsY0Uxisrx7M+N6SE4lcsIbR91swTSWgyGDvvEkRcoe61VmKNR+HRK8UJusTqCnRB5 UafPZnxYrgxvgkCWR6wVdF+ogD9Sw/HE7+L/9go4ccWHC40PlWaAMoJ+U4BtClJFPh6d LdCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727982900; x=1728587700; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h8dorIdrbdsDXvnwTp/xWktFMKZ+/T0BwIXwAgwlxFA=; b=vjqA7ZyOMgr+g+atAqCqRd+Qo6ZesCXhEyajUW9At9BRv86bn6XdQITxAF0tdNcQVw VCkyQLQze2WsO4dJdxkXkaM4ps1lJBxpI4Koct87f8ADRcDIjnlDC95T1qSRjnEA+E84 BL9wutbO2hTkP8ZdLs+2RH0wRi8u7G+W9v0rd7D37ta8y8/36HSxGEkbWFXQIwpTWCGe R0BxvZn91XrVjrgia9jmbFJTezu4Se3a+MJDkXrWqX6eOkkEUilkJR04uFDdUFT8NwoF LOuSlk4gkH/kUrlSogBVKLMJzoLJxO6Y+ZGwEb/o1Ws4nl7OtPl4yNPeeFTJolDnqG4S Kr/A== X-Forwarded-Encrypted: i=1; AJvYcCXtHSHQr3GubVliqwmfj6tY5aU7ZnP25RUIqjSJD6crCZstn/WTiwWSXjVXHEl0NG1VnQB8khQ=@dpdk.org X-Gm-Message-State: AOJu0YynmzRNP8jqzDWfPUs5Yb7x2PHLPt0ccH8KvIeEyU9wisOH/1Wc KP021i+gTCXR9CiOTgNNqTb4MB2IEL/b8ptWPMmd4MH4yA2F8CbxLVNx17Q7HtE= X-Google-Smtp-Source: AGHT+IH9jY0OWvZotmCu+ygKp2hlN5SQh5092oJ6yBAjG1FxQVtGvr0bLmbm9vwM5l2ycK7SUBL3KA== X-Received: by 2002:a05:690c:dd1:b0:6dd:c768:e58c with SMTP id 00721157ae682-6e2c6e8c605mr5412757b3.0.1727982900354; Thu, 03 Oct 2024 12:15:00 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id 00721157ae682-6e2bbbb7b0fsm3475247b3.6.2024.10.03.12.14.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Oct 2024 12:15:00 -0700 (PDT) Date: Thu, 3 Oct 2024 12:14:57 -0700 From: Stephen Hemminger To: Alexander Kozyrev Cc: , , , , Subject: Re: [PATCH] drivers: fix error CQE handling Message-ID: <20241003121457.37537b40@hermes.local> In-Reply-To: <20230502184922.3249201-1-akozyrev@nvidia.com> References: <20230502184922.3249201-1-akozyrev@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Tue, 2 May 2023 21:49:22 +0300 Alexander Kozyrev wrote: > The completion queue element size can be independently configured > to report either 64 or 128 bytes CQEs by programming cqe_sz parameter > at CQ creation. This parameter depends on the cache line size and > affects both regular CQEs and error CQEs. But the error handling > assumes that an error CQE is 64 bytes and doesn't take the padding > into consideration on platforms with 128-byte cache lines. > Fix the error CQE size in all error handling routines in mlx5. > > Fixes: 957e45fb7b ("net/mlx5: handle Tx completion with error") > Cc: stable@dpdk.org > > Signed-off-by: Alexander Kozyrev I have no idea about internals of mlx5 but the concept seems fine. Patch needs to be rebased. Please title it with net/mlx5 not drivers.