From: Stephen Hemminger <stephen@networkplumber.org>
To: Tyler Retzlaff <roretzla@linux.microsoft.com>
Cc: Ashish Sadanandan <ashish.sadanandan@gmail.com>,
dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
nelio.laranjeiro@6wind.com, stable@dpdk.org
Subject: Re: [PATCH v3 1/1] eal: add C++ include guard in generic/rte_vect.h
Date: Mon, 7 Oct 2024 13:20:43 -0700 [thread overview]
Message-ID: <20241007132043.66372dbd@hermes.local> (raw)
In-Reply-To: <20240402161923.GA19422@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net>
On Tue, 2 Apr 2024 09:19:23 -0700
Tyler Retzlaff <roretzla@linux.microsoft.com> wrote:
> On Sun, Mar 17, 2024 at 08:44:15PM -0600, Ashish Sadanandan wrote:
> > The header was missing the extern "C" directive which causes name
> > mangling of functions by C++ compilers, leading to linker errors
> > complaining of undefined references to these functions.
> >
> > Also updated the coding style contribution guideline with a new
> > "Language Linkage" section stating `extern "C"` block should be added to
> > public headers.
> >
> > Fixes: 86c743cf9140 ("eal: define generic vector types")
> > Cc: nelio.laranjeiro@6wind.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ashish Sadanandan <ashish.sadanandan@gmail.com>
> > ---
> Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
prev parent reply other threads:[~2024-10-07 20:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-02 5:13 [PATCH " Ashish Sadanandan
2024-02-02 9:18 ` Thomas Monjalon
2024-02-02 9:40 ` Bruce Richardson
2024-02-02 20:58 ` Ashish Sadanandan
2024-03-13 23:45 ` Stephen Hemminger
2024-03-14 3:45 ` Tyler Retzlaff
2024-02-05 17:36 ` Tyler Retzlaff
2024-02-05 21:07 ` Morten Brørup
2024-02-12 15:43 ` Ferruh Yigit
2024-02-12 16:02 ` Morten Brørup
2024-03-13 20:26 ` Ashish Sadanandan
2024-03-13 20:45 ` Thomas Monjalon
2024-03-13 22:11 ` Ashish Sadanandan
2024-02-12 15:42 ` Ferruh Yigit
2024-03-18 2:40 ` [PATCH v2 " Ashish Sadanandan
2024-03-18 2:44 ` [PATCH v3 " Ashish Sadanandan
2024-04-02 16:03 ` Ashish Sadanandan
2024-04-03 14:52 ` Thomas Monjalon
2024-04-07 1:30 ` Ashish Sadanandan
2024-04-07 17:04 ` Stephen Hemminger
2024-04-08 8:50 ` Ferruh Yigit
2024-04-08 9:04 ` Bruce Richardson
2024-04-08 15:29 ` Tyler Retzlaff
2024-04-02 16:10 ` Bruce Richardson
2024-04-02 16:19 ` Tyler Retzlaff
2024-10-07 20:20 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241007132043.66372dbd@hermes.local \
--to=stephen@networkplumber.org \
--cc=ashish.sadanandan@gmail.com \
--cc=dev@dpdk.org \
--cc=nelio.laranjeiro@6wind.com \
--cc=roretzla@linux.microsoft.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).