From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 407D345AE3
	for <public@inbox.dpdk.org>; Tue,  8 Oct 2024 18:49:02 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id A9DFC40DF6;
	Tue,  8 Oct 2024 18:49:01 +0200 (CEST)
Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com
 [209.85.214.176])
 by mails.dpdk.org (Postfix) with ESMTP id 39B644042F
 for <stable@dpdk.org>; Tue,  8 Oct 2024 18:48:56 +0200 (CEST)
Received: by mail-pl1-f176.google.com with SMTP id
 d9443c01a7336-20b6c311f62so52068585ad.0
 for <stable@dpdk.org>; Tue, 08 Oct 2024 09:48:56 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728406135;
 x=1729010935; darn=dpdk.org; 
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:from:to:cc:subject:date
 :message-id:reply-to;
 bh=sMVbTgs7uNhYejwjHhjohbVJWZHHSAzpxmwxbsoCr2Y=;
 b=cdMuRS48C6r63vFhpcCKHu+QdBRqRTClSROvUlQshaG6RrUtS/qG/Oc2KocMu0Uxqq
 N+f5znNlru2DTT/wpfE22tb1f8YdGOSbd9IgtNJUjIDn29MrCFZny5kKtjZfZneurMJj
 Ps5ySOF2Lykwu5qvT6exItFSqvM4w8EWQ5tkUM1sBnKvAr2eqyJOb+1BWa0lisHYUswm
 xEMRCHIXy9Y8h/iSylaLRd+G847xSHu0xFeVGosPxCq20+8LRXpuubCRFNDRYc6xJrDU
 yBgc4RcOuPDWhGMpW0gpXZs4t+7Q25IJo7Hdq2dKKjQD5IEnuYyYSzfKsd0HHOPVnH7H
 +5ZA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20230601; t=1728406135; x=1729010935;
 h=content-transfer-encoding:mime-version:references:in-reply-to
 :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=sMVbTgs7uNhYejwjHhjohbVJWZHHSAzpxmwxbsoCr2Y=;
 b=Ld7Lc6/Pxia12hARzjHF5IlwO5RfMleH+DLYhJkEPTXuXKfi8RnwwTKm/QMpBChKiY
 Oamb1QoVjY9cr+vF77qzVvfb5x5cqOHMrSlq9ha4bNJZMfx6Hz6tgFUaccnGbVwDbTJx
 k4HXVuQ2r7IM/e7tFtbTvCBGjJhab/UOXHHXkLKNUoUoZetBNintqSSqqklSngHRh9Ye
 S/iZVdKR0wXYH/7vFxQBHmzdAKdnHm816U960Rknt3fTarwrIn4kF+oWwXWD10j/OgTM
 66EQAwaIUF9+q+W4VtXTvTwppfwWVWOcbyzpTqP+UPhedKiici6lbkxmp4fdCTkpnaV2
 7H+Q==
X-Forwarded-Encrypted: i=1;
 AJvYcCXFpICO4RNhBBuYa9DeBbzlAqkAueFyB/BwF5j1uSSGtsB1m47iSfAXJ59/sBRGp4MyxG/gvxw=@dpdk.org
X-Gm-Message-State: AOJu0YyCj6x0qWeOkBQULIC83WTvmJ7wQ1f9Du904fKAgx/sCRq24IX5
 T2bNP627aat4ITaAMZ4kRYb1KlW1XaEku1Hr8+tk5ZS25twuRIcXvA6Rgxt1GfCm8ZVmegmUZYS
 99GulnA==
X-Google-Smtp-Source: AGHT+IGZlq363ORX1Ao9m8WtLr29YRabUHtNEwDrHmK4MLUECVOH9BedqsF+qOX8swuAW70LY2ayeg==
X-Received: by 2002:a17:902:d50e:b0:20b:8907:b597 with SMTP id
 d9443c01a7336-20bfea56bccmr215805565ad.28.1728406135458; 
 Tue, 08 Oct 2024 09:48:55 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
 by smtp.gmail.com with ESMTPSA id
 d9443c01a7336-20c54056bd9sm13832965ad.85.2024.10.08.09.48.54
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 08 Oct 2024 09:48:55 -0700 (PDT)
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>, kevin.laatz@intel.com,
 stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
 Conor Walsh <conor.walsh@intel.com>
Subject: [PATCH v9 03/17] dma/ixd: fix incorrect free function in cleanup
Date: Tue,  8 Oct 2024 09:47:07 -0700
Message-ID: <20241008164842.139045-4-stephen@networkplumber.org>
X-Mailer: git-send-email 2.45.2
In-Reply-To: <20241008164842.139045-1-stephen@networkplumber.org>
References: <20240927204742.546164-1-stephen@networkplumber.org>
 <20241008164842.139045-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
 <mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
 <mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org

The data structure is allocated with rte_malloc and incorrectly
freed in cleanup logic using free.

Bugzilla ID: 1549
Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe")
Cc: kevin.laatz@intel.com
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Reviewed-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/dma/idxd/idxd_pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c
index 60ac219559..6ed03e96da 100644
--- a/drivers/dma/idxd/idxd_pci.c
+++ b/drivers/dma/idxd/idxd_pci.c
@@ -301,7 +301,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,
 	return nb_wqs;
 
 err:
-	free(pci);
+	rte_free(pci);
 	return err_code;
 }
 
-- 
2.45.2