From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <stable-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id 9323F45B04
for <public@inbox.dpdk.org>; Thu, 10 Oct 2024 17:20:14 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 1669940E0B;
Thu, 10 Oct 2024 17:20:14 +0200 (CEST)
Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com
[209.85.214.174])
by mails.dpdk.org (Postfix) with ESMTP id EBB1B40C35
for <stable@dpdk.org>; Thu, 10 Oct 2024 17:20:07 +0200 (CEST)
Received: by mail-pl1-f174.google.com with SMTP id
d9443c01a7336-20b90984971so9727635ad.3
for <stable@dpdk.org>; Thu, 10 Oct 2024 08:20:07 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1728573607;
x=1729178407; darn=dpdk.org;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:from:to:cc:subject:date
:message-id:reply-to;
bh=Ph0gis7N6SyK6HkHUINJSvdslNui2pPutAooYcwesmA=;
b=QbkqGzdNCkDUCLeCKD6ItKS6SIVmbjEFwsz/hDxF+b6NwGKKM/pAMQOOzx4h5Eiqof
meFn7eWjgGETi/5oFOlq4GS5o3EBGGPe7cAq+X1kctWLBSlye/rxUyap4tRuLkaKCucN
wI1nC3iVVdOFBX+NC0mLGrQWZfezDq5rHPH6L77QKEiM9MIrD6fjb9I2s8I2GSDpitTi
j6OIpOKX4iITjW4lMChLdwZAEaDd2IspaTAiTxxC2V5Glaiq6a8fdDo5yjRnb2Zrc+Qx
eVwMXr4DnVP48MwJTOgeI1eUgVSIH+rP9Ih1PH7w5hlOc3ZLq7l3qTk3QsAvjKgZ27TG
Qyrg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1728573607; x=1729178407;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=Ph0gis7N6SyK6HkHUINJSvdslNui2pPutAooYcwesmA=;
b=bUF/siTMdlG9+x7F+h5H/Se2j2dZNvKzE5EB9Jn0GyhnBvEMQ1SLRVJG0qIChMBEUe
rgIgDSw/JcYJtnAsZF+9bJVE36BsU1RYoJeSMGk10tjdweQ99cWMViPqXpVqALmHNCS3
7CT4i6CzvQI9HohZ4xk/tQZ392fSt97Rpy8eWP7d43pnQtMYlj5LHtWjZ9W2yZRY8053
aN5LcdXd3qfMM5P/18GnpT+S3UY8J7p+c1LKnjBfzdYOaPMU33t0iks7Tfyf3QaxQcCH
rFNvxXL1lAeL9kD7h3/kY2kkfMEo3aV091uoK7pcwAMBECApjQM8holxHBGDBXFyRcW4
u42g==
X-Forwarded-Encrypted: i=1;
AJvYcCVXdtjAJOc+GqpN9kkcQ4xE9XiGEHuSqehbR7HjwPuKrGkTNGDhkYiiBrkoTdYD0GtuZf6uqto=@dpdk.org
X-Gm-Message-State: AOJu0YxZPgt30FrwMJhQeVCevSHWc5bC9Q372iyg1mxZQ1AT6DCcOOgO
wmMtRh4o7WQV+FamOq9MynhAxUb6gGr5Z059NtM7mRo1FlxILHz8Vz7ZMv4XdDQ=
X-Google-Smtp-Source: AGHT+IGxVjJdMyUwaMKNoYAu9wOY7JCE95/+tPn98n5iLQ+RQK5kBPxMK4gPUaHTB+P2q/Uwafrp2w==
X-Received: by 2002:a17:903:2b05:b0:20b:6d8c:463 with SMTP id
d9443c01a7336-20c637557d0mr85556295ad.35.1728573607163;
Thu, 10 Oct 2024 08:20:07 -0700 (PDT)
Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226])
by smtp.gmail.com with ESMTPSA id
d9443c01a7336-20c8c33cbb9sm10534835ad.249.2024.10.10.08.20.06
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 10 Oct 2024 08:20:06 -0700 (PDT)
Date: Thu, 10 Oct 2024 08:13:38 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com, stable@dpdk.org, Long Wu
<long.wu@corigine.com>, Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH 05/10] net/nfp: fix problem caused by configure function
Message-ID: <20241010081338.7bbf0983@hermes.local>
In-Reply-To: <20241010091716.3631747-6-chaoyong.he@corigine.com>
References: <20241010091716.3631747-1-chaoyong.he@corigine.com>
<20241010091716.3631747-6-chaoyong.he@corigine.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
X-BeenThere: stable@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: patches for DPDK stable branches <stable.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/stable>,
<mailto:stable-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/stable/>
List-Post: <mailto:stable@dpdk.org>
List-Help: <mailto:stable-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/stable>,
<mailto:stable-request@dpdk.org?subject=subscribe>
Errors-To: stable-bounces@dpdk.org
On Thu, 10 Oct 2024 17:17:11 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:
> The return value of 'nfp_eth_set_configured()' is three ways, the
> original logic considered it as two ways wrongly.
>
> Fixes: 61d4008fe6bb ("net/nfp: support setting link up/down")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
Maybe refering to the return values in nfp_nsp_eth.c would be clearer
but makes sense.
Acked-by: Stephen Hemminger <stephen@networkplumber.org>