From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD93145B78 for ; Sat, 19 Oct 2024 17:32:56 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CA91741148; Sat, 19 Oct 2024 17:32:56 +0200 (CEST) Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by mails.dpdk.org (Postfix) with ESMTP id 6FF7340671 for ; Sat, 19 Oct 2024 17:32:54 +0200 (CEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-71e6d988ecfso2415858b3a.0 for ; Sat, 19 Oct 2024 08:32:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1729351973; x=1729956773; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=/vyYspPG7pyNwHEkFTPqZqwwqBOZHuh5GRlrw6HaPpo=; b=Ma4F8ObWMwB8GLA9g/DYGOz+lty6dXyrPSgORmFCoNpx5vMrT51OjQ5u3Ki4pXjyYl 41HnWcqd/HFWkDgFpvx/3TcSEHuaAsAUvIzS6/vFeAqC18Yfopw9r+SVXl+4Pr0d4tq8 kR18QOQLZv+UdJ/goem2NapCDC8hdlWLfO3hCjs+sYe65KEnGhidswn1Nq0I+lph3l4q fp/5JOUY6VIXF/wg+E0esiTarUbwXtNpcyq9XXu6HcQTeJ5gTCSbfg0sK5MTG2yMasLf UhTTcjno3JtioUJip2iN8usp+o64qE/ORJqvGtGFQE5OVfcr5Rz4NcmmhPFP1BjtXZ7c uydw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729351973; x=1729956773; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/vyYspPG7pyNwHEkFTPqZqwwqBOZHuh5GRlrw6HaPpo=; b=MSHUwjsRcYiyfyGMoSGxcJfTsmNmRPcA4w6oz/80rI9r3kfJcFuA0b2Q2luvqImyz4 q+P2jWDLMvdCfq3QkHwx6MFadDQX8ofCzhBseNqIzon111Hsao5e9pF20gmY7uoTXyei 4XZHSlQZwpw7SqxSq90JufmaeZxyHLZ6nm+3rrBIFmmoDxYBriBswYEKdjB4AMVduYVM /G/cI6oEGLlltLmZXL8KuFmY5sCZjY5tXQ0RNdcs6/DyxHYAyObA2L8SsjCCnLsl9Tka gEMjdraP3opHJkaLZMYGIsJO8oBmHdyPHIAT1K0v1ubjGVbHSkPyoDQ2Eq1kKcMBiOT8 HCTA== X-Forwarded-Encrypted: i=1; AJvYcCUPI2X35264LgNWihXcRoPhpOiVhnfnxi+0fWQl0KIe6MHVY+Itcq3ooqyTcJ9A+NcY731YcGI=@dpdk.org X-Gm-Message-State: AOJu0YzTLZRdnNfsNATz7dzyJw05VHOGOogha5Ah+8hT8jg/cCYoGEyp 0UsJoKAza0z1hoOZi520hUY7WK9cUlmeGqOGYRuQozhYB69LDf5wc8nDzuTxwpQ= X-Google-Smtp-Source: AGHT+IHq/klokJ1UB3j0BGip5GxrE+GZFApqhr8oHeeh2TDJAJbfN5ZMECBvTNwyjfkb+rQMkJF5Aw== X-Received: by 2002:a05:6a00:9298:b0:71e:77e7:d60 with SMTP id d2e1a72fcca58-71ea32fc43fmr8034771b3a.23.1729351973365; Sat, 19 Oct 2024 08:32:53 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-71ea3311f45sm3332656b3a.14.2024.10.19.08.32.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Oct 2024 08:32:53 -0700 (PDT) Date: Sat, 19 Oct 2024 08:32:52 -0700 From: Stephen Hemminger To: longli@linuxonhyperv.com Cc: longli@microsoft.com, Ferruh Yigit , Andrew Rybchenko , dev@dpdk.org, "Hui (Hui) Ling" , Wei Hu , stable@dpdk.org Subject: Re: [PATCH] net/netvsc: force TX VLAN offload on 801.2Q packet Message-ID: <20241019083252.11352d7e@hermes.local> In-Reply-To: <1729275230-16011-1-git-send-email-longli@linuxonhyperv.com> References: <1729275230-16011-1-git-send-email-longli@linuxonhyperv.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org On Fri, 18 Oct 2024 11:13:50 -0700 longli@linuxonhyperv.com wrote: > icrosoft.com> > > The VSP assumes the packet doesn't have VLAN tags. When VLAN tag is > present in a TX packet, always strip it and use PPI to send VLAN info > through VSP packet. > > Fixes: 4e9c73e96e83 ("net/netvsc: add Hyper-V network device") > Cc: Hui (Hui) Ling > Cc: Stephen Hemminger > Cc: Wei Hu > Cc: stable@dpdk.org > Signed-off-by: Long Li This was discovered from an network application that was using VLAN's but not setting the offload bits in the mbuf. Reviewed-by: Stephen Hemminger