From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7E2CF45BB6 for ; Wed, 23 Oct 2024 23:17:35 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78F504326C; Wed, 23 Oct 2024 23:17:35 +0200 (CEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id 30E1340261 for ; Wed, 23 Oct 2024 23:17:34 +0200 (CEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-4316cce103dso2675195e9.3 for ; Wed, 23 Oct 2024 14:17:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718254; x=1730323054; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0q2NmaxvlscohhDZS3BEDpGaVhkTVDBoGns4d45bTAs=; b=WYH1629//XhXlaOVIwHceXDZfFSl2xnFL6H1jtLAo76XI/rbt3Rbey+aA+gIKjo06D w2vfWWPUqn0uS67Q0XhzPAL9Az3PhrsnuJ7E9ZlS322JYwTMHzUYts6Rb1tb2bZjyga2 o2PH62YlBP47bQdeHMQTj7ruZ80TUtFv1VAb/zPj+ZdniDUzplknJ/NVGknHGUgMbUi6 nw6k44UXpgICJaGb58n1NaRAZRK1azpjJzmbR19J+cfNx10J/lqqChW0mbiIuzfODww9 MXzNKL4x4vFs1XVxLbcDjbLTJFn6Jx0avcnVE4qsxSOSSn3+hXUveByDWqVQSmZNRRCJ UU4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718254; x=1730323054; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0q2NmaxvlscohhDZS3BEDpGaVhkTVDBoGns4d45bTAs=; b=RXluVw+nh1a7KWuOBQU0gBzecwgKDqXlxjkMfWcZeospESjGi9YdbILSHaPauYAtBp Xeguzycn6Bo5uc09iRqRGSqw0wUEmAazGEoyqFZY23RSVdPk1cUMVK4iw/ffg10A26kX Xyevs0iPLLlThYtCiReIBKA739CUpSznR24BR2PS8aZuT8L8Wb9GecfGqEbkQ8EAc2fL 0pth+OcQJ0io1yXL2YEVcR5t3P92Pei8MVsCQWNfQOvODb5KLFrB6NyWSi0hVHmG33DL C/U2sUqx4z5TKzM8ntzk9G2mQrqFsLoIoukiqR3N6xTbY/mb1tKAAKO7tFntpc26/KLp ztGA== X-Forwarded-Encrypted: i=1; AJvYcCVp6COJYruugpNF7GBy0EG+kkHiBiSU/1AQfns98c23/ak9KstR+RMw6zcHFbnrLV4NKp6WlCk=@dpdk.org X-Gm-Message-State: AOJu0Ywo4oQuJ4MajHprzPZJ7SewC3ZKj4wJ2Xa4fSAHpeVDhnNw6pTI +VyhimjwC6ehj1hF8hItqiyCv7WhbeYDyW4v8IidpfNzD7B3FXVf X-Google-Smtp-Source: AGHT+IF0xPmhOMBlBL/+hWUTLJ+Lfog+GsK7FR8EAHGlR+lXGp74wvpc7cmFwSEX+OK6rUxsG25yIw== X-Received: by 2002:a05:600c:5108:b0:430:57e8:3c7e with SMTP id 5b1f17b1804b1-4318424dc7dmr41324855e9.28.1729718253633; Wed, 23 Oct 2024 14:17:33 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b9432fsm9785897f8f.83.2024.10.23.14.17.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:17:33 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Ajit Khaparde , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'crypto/bcmfs: fix free function mismatch' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:15:50 +0100 Message-ID: <20241023211704.1216956-10-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/08043b1ad9e349ae0520e0a49a4a7a21fae674d6 Thanks. Luca Boccassi --- >From 08043b1ad9e349ae0520e0a49a4a7a21fae674d6 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:06 -0700 Subject: [PATCH] crypto/bcmfs: fix free function mismatch MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ] The device structure is allocated with rte_malloc() and then incorrectly freed with free(). This will lead to corrupt malloc pool. Bugzilla ID: 1552 Fixes: c8e79da7c676 ("crypto/bcmfs: introduce BCMFS driver") Signed-off-by: Stephen Hemminger Acked-by: Ajit Khaparde Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/crypto/bcmfs/bcmfs_device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/bcmfs/bcmfs_device.c b/drivers/crypto/bcmfs/bcmfs_device.c index ada7ba342c..46522970d5 100644 --- a/drivers/crypto/bcmfs/bcmfs_device.c +++ b/drivers/crypto/bcmfs/bcmfs_device.c @@ -139,7 +139,7 @@ fsdev_allocate_one_dev(struct rte_vdev_device *vdev, return fsdev; cleanup: - free(fsdev); + rte_free(fsdev); return NULL; } @@ -163,7 +163,7 @@ fsdev_release(struct bcmfs_device *fsdev) return; TAILQ_REMOVE(&fsdev_list, fsdev, next); - free(fsdev); + rte_free(fsdev); } static int -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:40.932535337 +0100 +++ 0010-crypto-bcmfs-fix-free-function-mismatch.patch 2024-10-23 22:16:40.439940407 +0100 @@ -1 +1 @@ -From b1703af8e77d9e872e2ead92ab2dbcf290686f78 Mon Sep 17 00:00:00 2001 +From 08043b1ad9e349ae0520e0a49a4a7a21fae674d6 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit b1703af8e77d9e872e2ead92ab2dbcf290686f78 ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org