From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A217D45BB6 for ; Wed, 23 Oct 2024 23:17:46 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9B97B40261; Wed, 23 Oct 2024 23:17:46 +0200 (CEST) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) by mails.dpdk.org (Postfix) with ESMTP id 80CCB40261 for ; Wed, 23 Oct 2024 23:17:45 +0200 (CEST) Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4315baec69eso2052235e9.2 for ; Wed, 23 Oct 2024 14:17:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718265; x=1730323065; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0ZYPR4HDHZSsVNRNl64eZpgVU4XSYdwGiB8OG3BL+uw=; b=G9dTnR1fp24XZcyZqbBY8z7wiG4GFdDkofkXGSNtLkk6NlTgkojOo64JGzPhZvAe7G mESBEWz3MsnQOLmR8SsLJWHMlX7H7BUuPndsVFdd4BecfK6BrrL5JSUVj7G553+tB5B6 137EdDFEiknR9XqBda7GhHoTo+gEIklIipnv1SuF+g1Gkk5O5OAUYjL7CwhS6R7jr0AW qNKI0idH6qSraOYJvdFQJLhKa0X0cYm7yKtPAXS+3o/9Lfvk8xYe/DnOfO901m+Qmzn3 tm7RJZ15ZxvvWoJDKO5OzYF8RFI2yiJpgj+2tiQDQ8MCZnP3heH4twCEwZ1HsFX5I3t7 oMTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718265; x=1730323065; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ZYPR4HDHZSsVNRNl64eZpgVU4XSYdwGiB8OG3BL+uw=; b=Uo2P8sxzsSV3S9Sli/MWAXzrUetXRdvuS9WLuLCxbT6Z9UwcTC24KXvwMroiQ6xhcq b8lDHeK03DQndmKLa5oS8g/cEFiBA2voTznCWGcOZ76ufcPCwDIDkPv4aw3TlEOTN/hg PDhVpFMKXwfYHqacqlvAECSzqaJVhh5AzTwoYPaoXUtFzfxx0Qiw9EutgocJhChqFEu9 6tLmnEc5xSSZr4bRU6ZIMUegvvwZ1cW3FYGenUKNxymhuqQfYa2CscnHTPnyunQM60Qt kzu+a7wq9d+30KgKHLkdfsLVWZUvuVWgiBJNrn7402JNdpFQUkXu3AMrxmn8ylFrdAlF bPhA== X-Forwarded-Encrypted: i=1; AJvYcCXoKDCVZ16EJYh19FVwL5HAuzjgKffr9ETEsDNUA83pUNqAz/D28wcoYud3W5tj49b6Eg70Pws=@dpdk.org X-Gm-Message-State: AOJu0YxXuZusgE7DKf4m5gosTZkxfdmF81mRT+2woiXnBuQ52ML/1Ah2 2xEDqWeWa6buzoPc7A0J26E5sVP0jHEUFSvL9OV03iQSGEHaJL8D X-Google-Smtp-Source: AGHT+IFHFY2yUheUAR0PlOAwNwLkAspJBYRtgIwGNhXAIfeDNuBBBvPl5FizM8avJsEZS9W1Z9W5LA== X-Received: by 2002:a05:600c:3496:b0:431:4b88:d408 with SMTP id 5b1f17b1804b1-431841ee388mr33548755e9.5.1729718264942; Wed, 23 Oct 2024 14:17:44 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c50947sm27328185e9.45.2024.10.23.14.17.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:17:44 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'dma/idxd: fix free function mismatch in device probe' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:15:51 +0100 Message-ID: <20241023211704.1216956-11-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/495fd2e8ca2bc55b021b0c8ed3a2922f40913440 Thanks. Luca Boccassi --- >From 495fd2e8ca2bc55b021b0c8ed3a2922f40913440 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:07 -0700 Subject: [PATCH] dma/idxd: fix free function mismatch in device probe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] The data structure is allocated with rte_malloc and incorrectly freed in cleanup logic using free. Bugzilla ID: 1549 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Signed-off-by: Stephen Hemminger Reviewed-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 781fa02db3..7222de3b7e 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -292,7 +292,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, return nb_wqs; err: - free(pci); + rte_free(pci); return err_code; } -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:40.967887951 +0100 +++ 0011-dma-idxd-fix-free-function-mismatch-in-device-probe.patch 2024-10-23 22:16:40.439940407 +0100 @@ -1 +1 @@ -From 91b026fb46d987e68c1152b0bb5f0bc8f1f274db Mon Sep 17 00:00:00 2001 +From 495fd2e8ca2bc55b021b0c8ed3a2922f40913440 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 60ac219559..6ed03e96da 100644 +index 781fa02db3..7222de3b7e 100644 @@ -29 +30 @@ -@@ -301,7 +301,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, +@@ -292,7 +292,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,