From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63A5C45BB6 for ; Wed, 23 Oct 2024 23:17:12 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5C85640261; Wed, 23 Oct 2024 23:17:12 +0200 (CEST) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) by mails.dpdk.org (Postfix) with ESMTP id BFEB243246 for ; Wed, 23 Oct 2024 23:17:10 +0200 (CEST) Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-37d518f9abcso100325f8f.2 for ; Wed, 23 Oct 2024 14:17:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718230; x=1730323030; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O5zLJTZvSULlgauC5ehMII+ibiaFzHdBVCQaumjo7i4=; b=XosYYwRE3KJ30may/Qw/tQ+Xz/K7wgH5Hx3mmn49k7wr7lDO6LCrhCIVbfxbsF3694 BYaS+mmGcG8hcLAgJvugLW7n3C4y3uRK1LAaTxM/bd62hBP067bnJsP50xB/J8ZQuTNw z8TiO48bhaiicj64NW4wn/OTB4CTtSq0a06LMeTRupac0vbx+YHvllD3fX2+ZFx6xMgr r4sEqIPUHEGbXfiBJSzjSY5xu8vXwV9X1LC1cYfK1oZUiOqHz+x0cMSGALjdrryoo5Oi vZ1wz6uslRwpPAD2dfmicLgsDVzm45lfjdBKVEHesYHprZhw2h3FyRLiLHlE9KGptWDd c6mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718230; x=1730323030; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O5zLJTZvSULlgauC5ehMII+ibiaFzHdBVCQaumjo7i4=; b=vSTRNpBqJ2ghPH4VbNg7hm/gkqUnrEZgSDxPb7BqvW8fXwsHSFIiYeD9lpjt4gLEdz nCOxn69rFxCtuRr4pbUOURRdBZOp97sgH+0aXVVodqWOJRzs4dIaWUSDaGCkEoRqIGBT e+VTm7FavymdGKPmRqDDkSIQ1pLhtV5CPhL94uDsUsCpWV4IFS9yKzIe4omE8egbhczf PIytkt71axt/J1mfaSmtvpgk+dlxuzYe170M/JWbr7+AQkR1xguOIOAu5GrvZDo1VuLc BB/KMKLoj40GcmprcJP+tcqLjDCD4Xn8ncZKK/cqZtKsAfD8B98kO/ok4FXNGpkCVRwi S+UQ== X-Forwarded-Encrypted: i=1; AJvYcCXaoRzYM/KGEwkeSI3qeixng/LAiMh2d++IcqIlRMKFi8iDelt67zGPr7eNfZsH+p86VvGUiEg=@dpdk.org X-Gm-Message-State: AOJu0YwSOZA6rOHNtgZwlQ3x7wfC9I3Q56G1iJMybwShiu78k+u+6/xh KtxaMB1A7DHlTc5m+Xn6aY7PToYLA29FtiVEDM6GO+FRhSsiqlSEQL631w== X-Google-Smtp-Source: AGHT+IF5dPDROSRoDAwVb9xxLtaQsRLnSNAHzUmBNLy3Fzn8XNJuke2m5ofGLo5ErYllf3xpmD5H3A== X-Received: by 2002:a05:6000:acb:b0:37d:5113:cdef with SMTP id ffacd0b85a97d-37efcf84390mr2581680f8f.43.1729718230152; Wed, 23 Oct 2024 14:17:10 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a37b71sm9768996f8f.14.2024.10.23.14.17.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:17:09 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Radu Nicolau , Tyler Retzlaff , dpdk stable Subject: patch 'eal/x86: fix 32-bit write combining store' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:15:42 +0100 Message-ID: <20241023211704.1216956-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fdda4a8d41b8c0636498a37d82dd41c4d822cded Thanks. Luca Boccassi --- >From fdda4a8d41b8c0636498a37d82dd41c4d822cded Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 14:27:57 +0100 Subject: [PATCH] eal/x86: fix 32-bit write combining store [ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] The "movdiri" instruction is given as a series of bytes in rte_io.h so that it works on compilers/assemblers which are unaware of the instruction. The REX prefix (0x40) on this instruction is invalid for 32-bit code, causing issues. Thankfully, the prefix is unnecessary in 64-bit code, since the data size used is 32-bits. Fixes: 8a00dfc738fe ("eal: add write combining store") Signed-off-by: Bruce Richardson Acked-by: Radu Nicolau Acked-by: Tyler Retzlaff --- lib/eal/x86/include/rte_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/x86/include/rte_io.h b/lib/eal/x86/include/rte_io.h index 0e1fefdee1..5366e09c47 100644 --- a/lib/eal/x86/include/rte_io.h +++ b/lib/eal/x86/include/rte_io.h @@ -24,7 +24,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) { asm volatile( /* MOVDIRI */ - ".byte 0x40, 0x0f, 0x38, 0xf9, 0x02" + ".byte 0x0f, 0x38, 0xf9, 0x02" : : "a" (value), "d" (addr)); } -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:40.640485572 +0100 +++ 0002-eal-x86-fix-32-bit-write-combining-store.patch 2024-10-23 22:16:40.427939940 +0100 @@ -1 +1 @@ -From 41b09d64e35b877e8f29c4e5a8cf944e303695dd Mon Sep 17 00:00:00 2001 +From fdda4a8d41b8c0636498a37d82dd41c4d822cded Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] + @@ -15 +16,0 @@ -Cc: stable@dpdk.org