From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2266945BB6 for ; Wed, 23 Oct 2024 23:18:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1BC8340261; Wed, 23 Oct 2024 23:18:26 +0200 (CEST) Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by mails.dpdk.org (Postfix) with ESMTP id A25B340261 for ; Wed, 23 Oct 2024 23:18:24 +0200 (CEST) Received: by mail-wm1-f48.google.com with SMTP id 5b1f17b1804b1-43159c9f617so1996265e9.2 for ; Wed, 23 Oct 2024 14:18:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718304; x=1730323104; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P1gzEx/PfgMAQWGmnIEK5nhsZUs8j+gP19bUaDrzWNI=; b=KQOutmT9x84qoRR5fTSdFLQRuX9MOfEuhw8zfLti43EpPb6N0WRCSrqLxx20Jhah2U r8flK0gzODgA3qfyZ78s6gxp75qSKuvATnrrvY2CKsWEm1knz4sgaGtYiFh2lMTdYSn6 HpNBA+eMbrD4upVO5TuvSZoKKKE3Wd9oqMpMpPBliR/ECHI0V6nxIAEcwrGz+uS/Cvlb EqZkaYvflKDtxxRBTce9TauVDF7i3d/gze8b34xpOhUBiW4RgazhFyF/7XCNz4T/wXnq q33nUdgZKIQO2CGpjgyyiSi1BxFTg024wRW39R3KPJpf6Su7MnELI1sbXbnltZ8suRXj DBVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718304; x=1730323104; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P1gzEx/PfgMAQWGmnIEK5nhsZUs8j+gP19bUaDrzWNI=; b=BgnAGbcuzbnxZEq5Wx1hZrgSqvIuaFDQcx5cBQ98XOYbyP+UvHcbOiABzrDUDahGsc V+jfOmJECwAsIhaVDxy0NefLrns068Fm/6dN+YE0aButlYr8T1atneDXOd3WHzTJnOf9 x+5ruL/6GnVBXhJTvOpNw9/ydLwRDX/Wrdwk1XRakcMY+prZIllTPeYiLo5VaF9ClmT7 ThLzf9UG0AU88z3wmEh8skSBdFjAYVfpxle8bKrAi6Ds+Ya5+TxWoTa4kpcdu6HBwvQn oekXKbD0qovTnhXfyY9KmOgPDr8wnnVBplb108+IqhXAoxGSpLAk4OgBbnDVNFk/+k58 hZjg== X-Forwarded-Encrypted: i=1; AJvYcCVKd/BT2MbPfR7uYOXyaD5sP3lcjW/0pSodpEJznWxM0w6kdZZZd90LEnlo9uVD7eZze0vhzJo=@dpdk.org X-Gm-Message-State: AOJu0YzIgWOCI7tBjkXBfkrF85DLU6O5BXPZUmpy8WgIYgc4khlOB1wZ rTlEp17mhgGuR9aB57zeJuTABUUDCCskqW347+89OeNv+2xxnpOv2okeyg== X-Google-Smtp-Source: AGHT+IGF/IwY4Xrr9qMCyGt1lm58P1IJO3o2ukL69nq1Qc2QzfonRERVm5ZfSrUsQY7RO6kotYL6Rw== X-Received: by 2002:a05:600c:1c0d:b0:427:ff3b:7a20 with SMTP id 5b1f17b1804b1-43184185a15mr28244645e9.27.1729718304066; Wed, 23 Oct 2024 14:18:24 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4317d02dd84sm42548465e9.0.2024.10.23.14.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:18:22 -0700 (PDT) From: luca.boccassi@gmail.com To: Vladimir Medvedkin Cc: David Marchand , dpdk stable Subject: patch 'fib6: add runtime checks in AVX512 lookup' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:01 +0100 Message-ID: <20241023211704.1216956-21-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/e696cfc2f8eb796296d07c932a29f78216d04006 Thanks. Luca Boccassi --- >From e696cfc2f8eb796296d07c932a29f78216d04006 Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Tue, 8 Oct 2024 17:31:36 +0000 Subject: [PATCH] fib6: add runtime checks in AVX512 lookup [ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding if vector function can be used. Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup") Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand --- lib/fib/trie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287..7b33cdaa7b 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -46,8 +46,10 @@ static inline rte_fib6_lookup_fn_t get_vector_fn(enum rte_fib_trie_nh_sz nh_sz) { #ifdef CC_TRIE_AVX512_SUPPORT - if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0) || - (rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512)) + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512DQ) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) <= 0 || + rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512) return NULL; switch (nh_sz) { case RTE_FIB6_TRIE_2B: -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:41.340620284 +0100 +++ 0021-fib6-add-runtime-checks-in-AVX512-lookup.patch 2024-10-23 22:16:40.451940874 +0100 @@ -1 +1 @@ -From 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 Mon Sep 17 00:00:00 2001 +From e696cfc2f8eb796296d07c932a29f78216d04006 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org