From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6215045BB6 for ; Wed, 23 Oct 2024 23:19:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5AFDA432E0; Wed, 23 Oct 2024 23:19:45 +0200 (CEST) Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) by mails.dpdk.org (Postfix) with ESMTP id 3EF58432E0 for ; Wed, 23 Oct 2024 23:19:44 +0200 (CEST) Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43155afca99so9201085e9.1 for ; Wed, 23 Oct 2024 14:19:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718384; x=1730323184; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=k52rYhiOb06gWNK1MlXbt1/ZBOPuIXaiMZki1JtPINM=; b=CERhtsJrg3y46ZVSU5rn9RtkBNynMIkWHP+DFB2fUOB3k9Oz8rSpQEj4epVLBPJTcn zNbEQSvi3cDhScfrvMyU8x6gCcpgAs82fx/YKgW6G39QmFZXqi+2h/7KtP/vbcMeTfLM CZaLfM7DN+lXUQ7C4czRw/7zqBy8ThQg7NUYWRC2KHC+AM8tR81WIqKkKxjncCrMoi18 b7nCaTwAm5x9UBVnkd7XZWhoHPwpTcD8u+pZ8k6DOHEuW8duBuCpj+Sq3Xlj5EHFRw8N vGoK2slo6CfUm6Ju42s8UkNTseCvRr185uSV3hyHHGMFxD1+T6Rgc+MNyy8qiIvTX1Lc x+qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718384; x=1730323184; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k52rYhiOb06gWNK1MlXbt1/ZBOPuIXaiMZki1JtPINM=; b=jgPUP+S55QnvCtjDxVXbsZDT0ziMMPO1iD6nSl5+pzb30/w2VAzdwpLHI++DNHb9UZ LX62eeYuKaKf1lqv22xewMnIlDohVU1CJeMedGuEz7nkbKZG2R29qa9vNgoeLSDm0rus Y5AkZkP/06kOSHk9RJcrGnIcKtM98HSb64D1A2nziMBA6rZhxxlVvFF3cMZShT6zz7GK p81QesO7UxPn6czm2W5aiIJD8DCDNucaJ5aoKAZtMsVUEI+5x2lOiBUcsXupBxlhK2OM bMT1AIvh8SrKc+9ashNiiOxmORB3JuI3piQGk3Xyh09WBBUfwE9lEVTNBd3HcDs4eGmy Ghgw== X-Forwarded-Encrypted: i=1; AJvYcCVyx+a0eKMy3qsJrr2UvwdJolRLCwNa7xVhe6ORdY5biz0nz1BO3VdbLXqKbD8qCZgrCk9fWLU=@dpdk.org X-Gm-Message-State: AOJu0YwtKpy1MjJD7fH6XnFyMhPkU3Ii2aBWd4Yvnyh4GwsyOx6rKyAU 6EjQU4Ke8IMSUJWR+mE6zl/IN6qjzxyr18yx4M3byLh4YfqzcxAy7kae+98t X-Google-Smtp-Source: AGHT+IFqTBYW3LsoLs2QITh214ugngbR/tfpoqPvSuqy+w7H1oDS2Zu3Xsu22Qv0IE094w1VOwDUyA== X-Received: by 2002:a05:600c:354f:b0:431:57cf:f13d with SMTP id 5b1f17b1804b1-43184337402mr26454715e9.3.1729718383772; Wed, 23 Oct 2024 14:19:43 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c508ddsm26989455e9.40.2024.10.23.14.19.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:19:43 -0700 (PDT) From: luca.boccassi@gmail.com To: Barbara Skobiej Cc: Anatoly Burakov , Bruce Richardson , dpdk stable Subject: patch 'net/i40e/base: fix unchecked return value' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:23 +0100 Message-ID: <20241023211704.1216956-43-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/75db5f003240dfb0ec221fb51cd9dc86c36ff89b Thanks. Luca Boccassi --- >From 75db5f003240dfb0ec221fb51cd9dc86c36ff89b Mon Sep 17 00:00:00 2001 From: Barbara Skobiej Date: Mon, 2 Sep 2024 10:54:34 +0100 Subject: [PATCH] net/i40e/base: fix unchecked return value [ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] Static analysis tools have reported an unchecked return value warning. Address the warning by checking return value. Fixes: 2450cc2dc871 ("i40e/base: find partition id in NPAR mode and disable FCoE") Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/i40e/base/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 3acb48e20b..e5651ad80b 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -4226,8 +4226,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, /* use AQ read to get the physical register offset instead * of the port relative offset */ - i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); - if (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK)) + status = i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); + if ((status == I40E_SUCCESS) && (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK))) hw->num_ports++; } -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:42.151728352 +0100 +++ 0043-net-i40e-base-fix-unchecked-return-value.patch 2024-10-23 22:16:40.495942585 +0100 @@ -1 +1 @@ -From 7fb34b9141aab299c2b84656ec5b12bf41f1c21d Mon Sep 17 00:00:00 2001 +From 75db5f003240dfb0ec221fb51cd9dc86c36ff89b Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] + @@ -10 +11,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 416f31dcc3..07e18deaea 100644 +index 3acb48e20b..e5651ad80b 100644 @@ -23 +24 @@ -@@ -4215,8 +4215,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, +@@ -4226,8 +4226,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,