From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AAC4845BB6 for ; Wed, 23 Oct 2024 23:19:49 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A5C9140261; Wed, 23 Oct 2024 23:19:49 +0200 (CEST) Received: from mail-wm1-f54.google.com (mail-wm1-f54.google.com [209.85.128.54]) by mails.dpdk.org (Postfix) with ESMTP id 612D5432F4 for ; Wed, 23 Oct 2024 23:19:48 +0200 (CEST) Received: by mail-wm1-f54.google.com with SMTP id 5b1f17b1804b1-4316f3d3c21so1979275e9.3 for ; Wed, 23 Oct 2024 14:19:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718388; x=1730323188; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=I2nOtsUwqEYhc0/WxDOMBgX1NG/DxOY9oTPnxKL3npw=; b=HcKyuMJU2WK9s1D+RmbfhAXFxPLzxIqG8+/8rWPh8fWHV2YmXsY0fMT8Bt5lkd42om AyRes5lffLOOu4Wd3NX0iEiD8Sykg3mE2EdvWec/oPNXzXFdncbmBhkW5rLZwI+Uq4Bl vNGph26JefQ+42enbDIbE7xJ8dFRukAABHlYWUrsjGnxpCNmOET1JH/akG2AqIMFY/kY BGIJ4neH2BLFXBJ+HYXOPcHy3FA+4ST7Cch0TK60zeGbeZrmDRC1eNnyEcz+jkWaSM1X mIE2ZBbH7qkrrJPFQ20z4Phj0+GDG/2GXS935gHRWMg5JU1y+Ixd2AH56Fs+idUQGHhy UK/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718388; x=1730323188; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=I2nOtsUwqEYhc0/WxDOMBgX1NG/DxOY9oTPnxKL3npw=; b=axA7mHSJBwMaNMDJyXbbw0T4/s/Bczpn1yEmj4iCriNT1h9ex7E8fQGMuG76gACx7d tnF0yWHs7PX/2i6LO9o78O7nhR2eyZMdQwuafODRhILgT/H8Mp3v2IWde6HyF/zFDuzq 48qVU+faOvfI2nXweylva+f7CNQM9iE+S7VsCpr24JTLsJvggcumuJJOsZuU8h6um9cw pj6igjdKsJvKHEs1duSbo47oJjnW4pvZApNzcWCl/V+rOmv3wG7CAkXmDqXnvv7kBoXD kz/oav6EvFfaiqWKTvucAPPs+Jeg9R4UVQmKI90OGsf+4Us9g1Nbe/9FWUH5lOqtDpJJ UpjA== X-Forwarded-Encrypted: i=1; AJvYcCVTd+v7v6SbDQ5VGZv4q4xM8lyXJHcG2FB7oi6NFrprRhdmE9mvx1mhvprkZ581PYIqSEPaWbM=@dpdk.org X-Gm-Message-State: AOJu0Yz6YyOnMDOtv75hx4oG1ZQ4QTmGkmoYpILs4KfJzVNqxED/G91z l3mSiv5gu+50iaMXRiQJP7B6th69nPI3lm/nx1EqWIqWETEcnnV4O0pOgK+v X-Google-Smtp-Source: AGHT+IED+MeN/zMcEmZbbyLKDPlsQ/TfXz0mh08TiUAluRvX1ALHf6CtUzgQSy4LAmGw2xPaZzFpHg== X-Received: by 2002:a05:600c:4f0b:b0:431:5f1c:8352 with SMTP id 5b1f17b1804b1-431841300e3mr33761635e9.5.1729718387826; Wed, 23 Oct 2024 14:19:47 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a37b4dsm9769591f8f.18.2024.10.23.14.19.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:19:46 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/i40e: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:25 +0100 Message-ID: <20241023211704.1216956-45-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0d727f9dd2a3372157608968b0c6e8bd42e634fb Thanks. Luca Boccassi --- >From 0d727f9dd2a3372157608968b0c6e8bd42e634fb Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:24 +0100 Subject: [PATCH] net/i40e: fix AVX-512 pointer copy on 32-bit [ upstream commit 2d040df2437a025ef6d2ecf72de96d5c9fe97439 ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 5171b4ee6b6b ("net/i40e: optimize Tx by using AVX512") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/i40e/i40e_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/i40e/i40e_rxtx_vec_avx512.c b/drivers/net/i40e/i40e_rxtx_vec_avx512.c index 74ff54c653..3490299a6f 100644 --- a/drivers/net/i40e/i40e_rxtx_vec_avx512.c +++ b/drivers/net/i40e/i40e_rxtx_vec_avx512.c @@ -922,6 +922,7 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) uint32_t copied = 0; /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_load_si512(&txep[copied]); const __m512i b = _mm512_load_si512(&txep[copied + 8]); const __m512i c = _mm512_load_si512(&txep[copied + 16]); @@ -931,6 +932,12 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 8], b); _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_load_si512(&txep[copied]); + const __m512i b = _mm512_load_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } cache->len += n; -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:42.224753269 +0100 +++ 0045-net-i40e-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-10-23 22:16:40.499942740 +0100 @@ -1 +1 @@ -From 2d040df2437a025ef6d2ecf72de96d5c9fe97439 Mon Sep 17 00:00:00 2001 +From 0d727f9dd2a3372157608968b0c6e8bd42e634fb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 2d040df2437a025ef6d2ecf72de96d5c9fe97439 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 0238b03f8a..3b2750221b 100644 +index 74ff54c653..3490299a6f 100644 @@ -23 +24 @@ -@@ -799,6 +799,7 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) +@@ -922,6 +922,7 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) @@ -31 +32 @@ -@@ -808,6 +809,12 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq) +@@ -931,6 +932,12 @@ i40e_tx_free_bufs_avx512(struct i40e_tx_queue *txq)