From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD7945BB6 for ; Wed, 23 Oct 2024 23:20:00 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB08940261; Wed, 23 Oct 2024 23:20:00 +0200 (CEST) Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) by mails.dpdk.org (Postfix) with ESMTP id 006AB40261 for ; Wed, 23 Oct 2024 23:19:59 +0200 (CEST) Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-37d41894a32so160585f8f.1 for ; Wed, 23 Oct 2024 14:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718399; x=1730323199; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0qVywuOITEhB5cm4T0ek9bITn5yz2nq0466Xb6Jf1ow=; b=g9+WoLb/ChB6Ti/KEOngvRShoDvcXpkVXa92CJ7OSn/o3s4uL7R8Uql4XfrTtu7RZP 9bh5H72Xj3BQqem1yTkUlWcMW7ShK94Y4YN46isR3R9nlofMNE3l0YKx9og3fkgUeFaK Q5civMxkzJ4lHqdKT4ET0Hl/AyrvmvaaxBB8DwzOizpqjiSEmk3BpuFHyC6A8Pdyidlc qbInzKgHa/ddPc5UvNYsPgcqnHrpwMW71B2PCSz+LD5/o9QIdfkefYDywSIPmfmas/h1 OWZhWWFHKbmyG18iwUE0QLvjusRqYna9JU7fzEmi31D/bP7mwXOXjWTAKbGpNZs1yzzf jdcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718399; x=1730323199; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0qVywuOITEhB5cm4T0ek9bITn5yz2nq0466Xb6Jf1ow=; b=lqGgyQdJ/YzfwxJVEt9pS8Kfu0VcxktEC9PEz3JH/2Fh7/TyNiJCPzvzTi0u6m0vyY Od8AcPqvYJ9nlSCv7gyLmzthwWmSh/uy0dZPBFHLQNsOuwbPWRrwDsRM4qkBRFi+KlmE pSsdkeMG3mZT4Dyq/V7WCBoy5UBaN0/Bmwq6D0Vu1uwgaFAKMUPdJV7B4OBVMRaCB/5f tIk1e3E/uaW8gfxxJkAVQuhgoaqossdjaARfe2NhtBnm+HnEXAPH1PGj7QHql8Qkh0d0 14k6TspqLl7En3dZsCa35ChwXdYWYrzArd2K4Y+My81EV/vnPw4XYJYA07kU7RQXSUj1 vEyg== X-Forwarded-Encrypted: i=1; AJvYcCVTyNfrCmihvIGC9gB7OJQ/qW/n7wv+ptX3EpZsDVfmxLoY2+AhXuBkx2iyDOKOh+NAfCD4KJ8=@dpdk.org X-Gm-Message-State: AOJu0YwX/S5ktIKqZoRJgyy1Awj1NjLR88YLlayoQ79S4Ay1qTeVu1fd XlRDBA1YLatz+0xDmI+mrg5aHqC4rpDtk5NK9k/SnFUfoQqsgSHg X-Google-Smtp-Source: AGHT+IFcWYW9O2HC5YxcjlXQXamp0zgE4tOnHzU6Jb09dWwzu1WZbd+HFD1o5aNBAG7dy90DVtAVTA== X-Received: by 2002:a5d:6348:0:b0:367:8e57:8 with SMTP id ffacd0b85a97d-37ef14daa49mr5344556f8f.19.1729718399410; Wed, 23 Oct 2024 14:19:59 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c3a5b4sm27255515e9.38.2024.10.23.14.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:19:58 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/ice: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:26 +0100 Message-ID: <20241023211704.1216956-46-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8c93fc77264f4b3a7dfbef31f168f9c2fe7e5379 Thanks. Luca Boccassi --- >From 8c93fc77264f4b3a7dfbef31f168f9c2fe7e5379 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:25 +0100 Subject: [PATCH] net/ice: fix AVX-512 pointer copy on 32-bit [ upstream commit da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: a4e480de268e ("net/ice: optimize Tx by using AVX512") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/ice/ice_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/ice/ice_rxtx_vec_avx512.c b/drivers/net/ice/ice_rxtx_vec_avx512.c index 5bfd5152df..5f91ee4839 100644 --- a/drivers/net/ice/ice_rxtx_vec_avx512.c +++ b/drivers/net/ice/ice_rxtx_vec_avx512.c @@ -1020,6 +1020,7 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) uint32_t copied = 0; /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_loadu_si512(&txep[copied]); const __m512i b = _mm512_loadu_si512(&txep[copied + 8]); const __m512i c = _mm512_loadu_si512(&txep[copied + 16]); @@ -1029,6 +1030,12 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 8], b); _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_loadu_si512(&txep[copied]); + const __m512i b = _mm512_loadu_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } cache->len += n; -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:42.258238170 +0100 +++ 0046-net-ice-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-10-23 22:16:40.499942740 +0100 @@ -1 +1 @@ -From da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 Mon Sep 17 00:00:00 2001 +From 8c93fc77264f4b3a7dfbef31f168f9c2fe7e5379 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit da97aeafca4cdd40892ffb7e628bb15dcf9c0f25 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 04148e8ea2..add095ef06 100644 +index 5bfd5152df..5f91ee4839 100644 @@ -23 +24 @@ -@@ -907,6 +907,7 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) +@@ -1020,6 +1020,7 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) @@ -31 +32 @@ -@@ -916,6 +917,12 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq) +@@ -1029,6 +1030,12 @@ ice_tx_free_bufs_avx512(struct ice_tx_queue *txq)