From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F17BE45BB6 for ; Wed, 23 Oct 2024 23:20:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EC439432E6; Wed, 23 Oct 2024 23:20:01 +0200 (CEST) Received: from mail-wr1-f43.google.com (mail-wr1-f43.google.com [209.85.221.43]) by mails.dpdk.org (Postfix) with ESMTP id 54BD9432E6 for ; Wed, 23 Oct 2024 23:20:01 +0200 (CEST) Received: by mail-wr1-f43.google.com with SMTP id ffacd0b85a97d-37d47b38336so99077f8f.3 for ; Wed, 23 Oct 2024 14:20:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718401; x=1730323201; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=s8fE75vDD4Hc8L7wLsKVtwC1q0UyvNvn5qnfRJ8M+/Y=; b=kfnD04qvRqu5rfJU0vW+LyFzR6IOHNM6BPUvqC5OZ8LYM3VzlFjdX/i+egR33GCGzt Yr6lzsIfEHpTokQlJbSjEEzVxMWah4Erj4vzjn7S5O5un3v+04KH0HGST5izlCrwrLrY yFrEVqYmS/l4fBDCP2VaFTjOoUy/qdndykwE/SYOvCrOpvBkZlwyW6w7X1/SvAyrmHkE W/hbu0kZbT3l0Bc93Upbq4ktcwbRz+4LNfBw3M+69bhSe7EXoSsAemZeVl2eMFyVO9uw AA6UAuksJTcnSB04BBhrphIFqAQGUPw1Y4OLpUcq18+IuTnG0yYSCYB1WAYZDdvD4EEC FpyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718401; x=1730323201; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=s8fE75vDD4Hc8L7wLsKVtwC1q0UyvNvn5qnfRJ8M+/Y=; b=QoFIu6aCNqIc/Tw7T38PguW2bX3v0kE6bAP3hkagGfQOddISsz3kVF88WosKjac9DL qR89Ca907vf2DCEXQWXfLo2ZXYlZ7UlEvIcixisDNMUO04y1RoJPrAXMjWtpESgF5cYH FDR4pkyd4/BchyzxySgxVv+LIrRXOZePxjh28MF2AOfTMrzUx6EQsjTswMi8mz62GLOm RZIRq6QhcCUH1IUTEPVmBO5yZcFxNBqHEa2/Vf6PjPwNuVeJZAqTsKe/CanP4FDGUQaX jpGh8Se7PEAh44hUjQca5ZBUJGxf+H28SeWuRUJbOkz9byH2WAj3vmWrRmZz7jL08Mgn 3PGA== X-Forwarded-Encrypted: i=1; AJvYcCVr5ib8K2b0onJmsVD+J8MI3D0vjDooiFg0XaZa4vuD7d95pW4LT/6T5ncys8aae11qwMhnXxE=@dpdk.org X-Gm-Message-State: AOJu0YxpBAjVYUmbhfP0dZkK+jBnSsL6uVC2pWtvK1cFdoTMjIYFi9K9 +Hy+EqAY2wOM+/2D3eX4Erj4qtjrLhNZzAPIUQ3F0h+qsKxCZlAhBuzpkbxr X-Google-Smtp-Source: AGHT+IG3F+54vyHJCngP5ZKhxW5RdwzzcLFAINtTlWxys4oxxifMjyaQsX/whu3fDZa4Li082HYSOg== X-Received: by 2002:a5d:6410:0:b0:37d:462a:9bc6 with SMTP id ffacd0b85a97d-37efcf7ba5dmr2562249f8f.36.1729718400854; Wed, 23 Oct 2024 14:20:00 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0a37d25sm9778997f8f.23.2024.10.23.14.20.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:20:00 -0700 (PDT) From: luca.boccassi@gmail.com To: Bruce Richardson Cc: Ian Stokes , dpdk stable Subject: patch 'net/iavf: fix AVX-512 pointer copy on 32-bit' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:27 +0100 Message-ID: <20241023211704.1216956-47-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/b25fb707fa1a64411395fcf2bed73eb99059863f Thanks. Luca Boccassi --- >From b25fb707fa1a64411395fcf2bed73eb99059863f Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 15:11:26 +0100 Subject: [PATCH] net/iavf: fix AVX-512 pointer copy on 32-bit [ upstream commit 77608b24bdd840d323ebd9cb6ffffaf5c760983e ] The size of a pointer on 32-bit is only 4 rather than 8 bytes, so copying 32 pointers only requires half the number of AVX-512 load store operations. Fixes: 9ab9514c150e ("net/iavf: enable AVX512 for Tx") Signed-off-by: Bruce Richardson Acked-by: Ian Stokes --- drivers/net/iavf/iavf_rxtx_vec_avx512.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/iavf/iavf_rxtx_vec_avx512.c b/drivers/net/iavf/iavf_rxtx_vec_avx512.c index b0546a14c6..eb6eb9847d 100644 --- a/drivers/net/iavf/iavf_rxtx_vec_avx512.c +++ b/drivers/net/iavf/iavf_rxtx_vec_avx512.c @@ -1818,6 +1818,7 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) uint32_t copied = 0; /* n is multiple of 32 */ while (copied < n) { +#ifdef RTE_ARCH_64 const __m512i a = _mm512_loadu_si512(&txep[copied]); const __m512i b = _mm512_loadu_si512(&txep[copied + 8]); const __m512i c = _mm512_loadu_si512(&txep[copied + 16]); @@ -1827,6 +1828,12 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) _mm512_storeu_si512(&cache_objs[copied + 8], b); _mm512_storeu_si512(&cache_objs[copied + 16], c); _mm512_storeu_si512(&cache_objs[copied + 24], d); +#else + const __m512i a = _mm512_loadu_si512(&txep[copied]); + const __m512i b = _mm512_loadu_si512(&txep[copied + 16]); + _mm512_storeu_si512(&cache_objs[copied], a); + _mm512_storeu_si512(&cache_objs[copied + 16], b); +#endif copied += 32; } cache->len += n; -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:42.294094568 +0100 +++ 0047-net-iavf-fix-AVX-512-pointer-copy-on-32-bit.patch 2024-10-23 22:16:40.499942740 +0100 @@ -1 +1 @@ -From 77608b24bdd840d323ebd9cb6ffffaf5c760983e Mon Sep 17 00:00:00 2001 +From b25fb707fa1a64411395fcf2bed73eb99059863f Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 77608b24bdd840d323ebd9cb6ffffaf5c760983e ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 3bb6f305df..d6a861bf80 100644 +index b0546a14c6..eb6eb9847d 100644 @@ -23 +24 @@ -@@ -1892,6 +1892,7 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) +@@ -1818,6 +1818,7 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) @@ -31 +32 @@ -@@ -1901,6 +1902,12 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq) +@@ -1827,6 +1828,12 @@ iavf_tx_free_bufs_avx512(struct iavf_tx_queue *txq)