From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8960C45BB6 for ; Wed, 23 Oct 2024 23:20:07 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 789FF40261; Wed, 23 Oct 2024 23:20:07 +0200 (CEST) Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) by mails.dpdk.org (Postfix) with ESMTP id 9F47A43308 for ; Wed, 23 Oct 2024 23:20:05 +0200 (CEST) Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-43155afca99so9203265e9.1 for ; Wed, 23 Oct 2024 14:20:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1729718405; x=1730323205; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=BIzgDYdaV3feOEIx3VgfkZN0RDv3Wklm4TQchHPXDys=; b=VY84cDJshbR7hu9XVx5p+9imPF384Q/KJjrmdYr8VI2AZJCjrVTD8IZYYOFv5u5dzH eqNO/XSHLSaroUHzda0wCn638bOJcD+lniDlE+aenQ/dpyAa2s+xUKo5X83JuLs3WuQj xn2PPx6atLOXifTcnP6QL02Yjzl5oQ3A7vdpAsHx4TEBV3tzqURY8NXKM1f9lZDBd3xr BTFVriphJyFZLNBsPre1e65vcimKSJ6O4xDT+dqEZZzTxBG+IiKYW8FAuv7cissnGXUJ XTASdocB/nvogQCbi04TAdA9zJwoHaPaqyAuZ2W8pQ5xxmjOAxnwJ0tbs9z21RGHEoUy 09dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729718405; x=1730323205; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BIzgDYdaV3feOEIx3VgfkZN0RDv3Wklm4TQchHPXDys=; b=uWSqkQwCHPP8R6n63BSSPSGrNkAwbFA5H7GX5/I06l8kWyTO/8gZI2F26szTJ3SDVE Ff4fg4IH9jG3O1JTYzYqr6WMzD3OG0l2yRzfNVab6tTRg7gukbxkETmN+RbX6UZieDh4 F1AZaMlbxhfQ7ie4OFfwltxYBuKMMDakC5xddLkBBtUOY/ngLgMH15N4TeQvCjfoGrsH K0EszaQBcp1CkmhpvDjfB0/Pk8eHmVoWqKlcVX3pc/kUAY1nyJ+LHN92vh2C1CCuHem5 ZKi+5fx6hXtZzsAR7fcDuIKrL68oHjdN/OKkIdlYX5yBHgzKTEi7OBQYt+fRSCHfmYZx J7pw== X-Forwarded-Encrypted: i=1; AJvYcCXKVUzvwhnyXanVVST4QlFUusvuk5YI4nT5cYzdPZPbW8QhI7gvMOd++5LHgFzxvCd5Rs6+loY=@dpdk.org X-Gm-Message-State: AOJu0YyB74vFlEWj5N3hTOas88SR3Q/F+R/OUHpKRpbAXqwROxZkJGzF OVLIDsLC3G+PGDYIsm1YMIw7U1SlzBvNM70aWxtV//9MW24mpn8E X-Google-Smtp-Source: AGHT+IGedTY7tXIBFk4hFPhTXc41RYGejche2s0HlBuBk1ZTptlZR5vDVHe/1YNXptlNXGnUbLGhZg== X-Received: by 2002:a5d:4246:0:b0:374:c7cd:8818 with SMTP id ffacd0b85a97d-37ef14e0718mr4968398f8f.22.1729718405171; Wed, 23 Oct 2024 14:20:05 -0700 (PDT) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-43186c1e387sm26695975e9.41.2024.10.23.14.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2024 14:20:04 -0700 (PDT) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Ofer Dagan , Ferruh Yigit , dpdk stable Subject: patch 'net/pcap: set live interface as non-blocking' has been queued to stable release 22.11.7 Date: Wed, 23 Oct 2024 22:16:30 +0100 Message-ID: <20241023211704.1216956-50-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241023211704.1216956-1-luca.boccassi@gmail.com> References: <20241023211704.1216956-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 10/25/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d3a78f0f8f993a4e86460371e2b0d3c2fd11c1ad Thanks. Luca Boccassi --- >From d3a78f0f8f993a4e86460371e2b0d3c2fd11c1ad Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Sat, 24 Aug 2024 11:07:10 -0700 Subject: [PATCH] net/pcap: set live interface as non-blocking [ upstream commit 60dd5a70035f447104d457aa338557fb58d5cb06 ] The DPDK PMD's are supposed to be non-blocking and poll for packets. Configure PCAP to do this on live interface. Bugzilla ID: 1526 Fixes: 4c173302c307 ("pcap: add new driver") Reported-by: Ofer Dagan Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- drivers/net/pcap/pcap_ethdev.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/drivers/net/pcap/pcap_ethdev.c b/drivers/net/pcap/pcap_ethdev.c index 5780f704b6..03729c0ca7 100644 --- a/drivers/net/pcap/pcap_ethdev.c +++ b/drivers/net/pcap/pcap_ethdev.c @@ -522,6 +522,12 @@ open_iface_live(const char *iface, pcap_t **pcap) { return -1; } + if (pcap_setnonblock(*pcap, 1, errbuf)) { + PMD_LOG(ERR, "Couldn't set non-blocking on %s: %s", iface, errbuf); + pcap_close(*pcap); + return -1; + } + return 0; } -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-10-23 22:16:42.419829302 +0100 +++ 0050-net-pcap-set-live-interface-as-non-blocking.patch 2024-10-23 22:16:40.507943052 +0100 @@ -1 +1 @@ -From 60dd5a70035f447104d457aa338557fb58d5cb06 Mon Sep 17 00:00:00 2001 +From d3a78f0f8f993a4e86460371e2b0d3c2fd11c1ad Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 60dd5a70035f447104d457aa338557fb58d5cb06 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 9626c343dc..1fb98e3d2b 100644 +index 5780f704b6..03729c0ca7 100644