From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: thomas@monjalon.net, ferruh.yigit@amd.com,
stephen@networkplumber.org, mattias.ronnblom@ericsson.com,
stable@dpdk.org, Kai Ji <kai.ji@intel.com>,
Slawomir Mrozowicz <slawomirx.mrozowicz@intel.com>,
Tomasz Kulasek <tomaszx.kulasek@intel.com>,
Daniel Mrzyglod <danielx.t.mrzyglod@intel.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Michal Kobylinski <michalx.kobylinski@intel.com>
Subject: [PATCH 4/6] crypto/openssl: fix 3DES-CTR with big endian CPUs
Date: Thu, 24 Oct 2024 14:05:33 +0200 [thread overview]
Message-ID: <20241024120535.2722316-5-david.marchand@redhat.com> (raw)
In-Reply-To: <20241024120535.2722316-1-david.marchand@redhat.com>
Caught by code review.
Don't byte swap unconditionally (assuming that CPU is little endian is
wrong). Instead, convert from big endian to cpu and vice versa.
Fixes: d61f70b4c918 ("crypto/libcrypto: add driver for OpenSSL library")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/crypto/openssl/rte_openssl_pmd.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index 9657b70c7a..9f5f3cda7d 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -2,6 +2,7 @@
* Copyright(c) 2016-2017 Intel Corporation
*/
+#include <rte_byteorder.h>
#include <rte_common.h>
#include <rte_hexdump.h>
#include <rte_cryptodev.h>
@@ -110,9 +111,9 @@ ctr_inc(uint8_t *ctr)
{
uint64_t *ctr64 = (uint64_t *)ctr;
- *ctr64 = __builtin_bswap64(*ctr64);
+ *ctr64 = rte_be_to_cpu_64(*ctr64);
(*ctr64)++;
- *ctr64 = __builtin_bswap64(*ctr64);
+ *ctr64 = rte_cpu_to_be_64(*ctr64);
}
/*
--
2.46.2
next parent reply other threads:[~2024-10-24 12:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20241024120535.2722316-1-david.marchand@redhat.com>
2024-10-24 12:05 ` David Marchand [this message]
2024-10-24 12:54 ` Morten Brørup
2024-10-24 13:10 ` David Marchand
2024-10-24 13:17 ` David Marchand
2024-10-24 13:30 ` David Marchand
2024-10-24 14:21 ` Morten Brørup
[not found] ` <20241025070424.3916007-1-david.marchand@redhat.com>
2024-10-25 7:04 ` [PATCH v2 " David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241024120535.2722316-5-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=danielx.t.mrzyglod@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=kai.ji@intel.com \
--cc=mattias.ronnblom@ericsson.com \
--cc=michalx.kobylinski@intel.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=slawomirx.mrozowicz@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
--cc=tomaszx.kulasek@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).