From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACDA945CE3 for ; Mon, 11 Nov 2024 07:31:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A615A4067A; Mon, 11 Nov 2024 07:31:09 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2088.outbound.protection.outlook.com [40.107.94.88]) by mails.dpdk.org (Postfix) with ESMTP id E981440E19 for ; Mon, 11 Nov 2024 07:31:08 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=oYYtzd2coekOwZuNRknZWqEIRCyB+GYn63ivuxkO1lqBb+5BErRpKlvNj7dIkrI9aBeFGpWn7+FiXr/AJuLtrP88dRQAxOYFnaD+KnD5yFRe50BzVsrRc9AVmbR8pSsxRZXcGu9OESlszXIV4qNR4MgupgdLvRw+fEecxsC7OmZlZFhE5UO36cK2O5VnkpfY5kzYCWKW6vneA0k2nvKypG/p3ZgPeAX9SHVhM/7yMrhIK7mvo3Z3Wfc1AAnnc1VLzoFCIVfcnYlP+pWocTMFMJL68d7Q17N8/u4uRSOW22J3mXDB98MaIqdjGODLQg1II2t1IwxWvxncUKpHqPNxuA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=mD9TSCi3jMKik+NhOXJx9IKC3L6rlYxCSsB7yl2iEhE=; b=D8JmGxZbFXq0H2MRlMjedM3eZgPd74i5DXE/6XqtmSsCfaXCtw/tlMkrqLL476a84U/hPRpv2Qc1Tc0jAOD1cMxVLLTxVeLVQ5Q59zCjXcw2CbTEmbWOvzLh49br2vPzQ9ZIvo+n1+9GhjxeTMVNoipzpe1BuaGZ5tvZ6etEz3T3eaaDqnMa8Cx6/uwtvxDBzAHUv63LAmGe6QfaoRQXmxMomOC6lFdtM+nuGOQbYvcJMuRNyRVtZjnBqZYnlteRSUwYw8VyPmKarVuzQ+vPNp5BHQCyP0PD7TDF/UAMxgaiBZyhrSj24GsbrJjgbOBtoGbCmgJZEAvUSWGAT9ovtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=networkplumber.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=mD9TSCi3jMKik+NhOXJx9IKC3L6rlYxCSsB7yl2iEhE=; b=RGSw9O1+BEmq2Gi/gJWEZI8cc05i5FtNFSGFOAJmDXIVH/wdfSXaqOlQRuCylZGVcRLYHq2GrmCcTrZakCxKElkndWC83NxjuGadl7nh1sGbb98Da+1VZiYAhdVv25Vf6EnZ6nc+Z7oTX6oS9tCJmeQ1c3coCSWLWG7jGYTEloqlV2oFKXLpYBntWd7pDLirn6zY59XmHv7PTfSotpsiZzRPxCexUJ9Inz+uPytV27yaFTI3e4aciglPAGugcXnwHlu++9XVHOOfoVZYFdFv1Y6xZRnQZ80AWS7XilKc5x8UXXqCiRItAYF8gyU2purqf0wsfiAs27GaiVqEm+qxeA== Received: from DS7PR03CA0357.namprd03.prod.outlook.com (2603:10b6:8:55::10) by DM4PR12MB6183.namprd12.prod.outlook.com (2603:10b6:8:a7::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 06:31:06 +0000 Received: from DS1PEPF0001708E.namprd03.prod.outlook.com (2603:10b6:8:55:cafe::38) by DS7PR03CA0357.outlook.office365.com (2603:10b6:8:55::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26 via Frontend Transport; Mon, 11 Nov 2024 06:31:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DS1PEPF0001708E.mail.protection.outlook.com (10.167.17.134) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:31:05 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:30:51 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:30:48 -0800 From: Xueming Li To: Stephen Hemminger CC: , Bruce Richardson , =?UTF-8?q?Morten=20Br=C3=B8rup?= , "Konstantin Ananyev" , Wathsala Vithanage , dpdk stable Subject: patch 'dma/idxd: fix free function mismatch in device probe' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:27:04 +0800 Message-ID: <20241111062847.216344-19-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF0001708E:EE_|DM4PR12MB6183:EE_ X-MS-Office365-Filtering-Correlation-Id: daa74f29-b26f-4cc1-9bad-08dd021a6bf6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?utf-8?B?b1BkSlJKeGU3T0s2TFJMSlhHL3NPT1RySUg4U1hwem5RRWtCcDlxbXRoQkcw?= =?utf-8?B?SFR4QUlTcis0NFEzN1orWW1kd0laaE16QkJOK1ExOVFOTTNYaHUzRFJMKysz?= =?utf-8?B?cmFGMU83YUR4aGZnZy9QUjZSK2F1SDNRNG1HaUhwYkN6NnFTaVMvd0JrT3Jo?= =?utf-8?B?cFQxUEcrZTBHYVdNeWlkZGVxR2hSK3VGczZFVDhhS1REVEgyNTh6c0JTQWo3?= =?utf-8?B?Wm5IeE1ncVJEMFloOWc5VDR6SDRHMWk0a3NGNGdHWUl2SEw5K055TmZzZFQ3?= =?utf-8?B?UGRwUStyMXZqQW9QZ1k3L1cwc1k2aUorRlIrYkNZeWlMQndtbGwvVUxUOUpF?= =?utf-8?B?OXNEMm5XWWhhVSt6b3RDYUFNYTYyVTFuSk5BNGRFMCtCdDRFdHFCRU8rb2Vk?= =?utf-8?B?czBtajFpbGFHZHF0OWM4TjM3ZFJNVy9pbWZpd2lXamRZOTZid1FEVFdTaGhB?= =?utf-8?B?UHdJMktPWE9yZHBaYkRGVGlNb3NTdGdna2YweFdyMUNhUXpKbWFPWjlSWEdy?= =?utf-8?B?ajBZYStkeXNwYkNpdElxSTcweXdsYzJhZDNSOHhHOWJPY29KSXVvWlJtQW5x?= =?utf-8?B?bk1HVWNwSFJtV1FGcExLN0ZEbjhhR0RoU3RRNjdUTVAzejg3Rm5LaDNUSHJR?= =?utf-8?B?eW9lV3pCWHJnU1o3TlgxdkQwUGNXenRLN3o0aXBRWE5tSFBmcXdmeitjNjFx?= =?utf-8?B?dEJaakJJZXUxVndmTlhibktWL0JEVGJteUJicnhKK3BRbWp0RkppUWU3bUk2?= =?utf-8?B?Q3JlTXFIK2NnSnIzTVppRU1RSDRsdDBieFAzbmhXM3lNdlcxWldKN1Rvalha?= =?utf-8?B?YnpCdW12aVljQlNyUzlyZkVnSUdLZExHNlFIMjFmdnFnR0ltRXdkbER4SklW?= =?utf-8?B?TzltZ3NFeVNiREs0aW9PalFEbXRPRVd1THMwa1pBUDFpYkIvL3h6ZVAvam1M?= =?utf-8?B?YTN4ckpNcE9xVWIrSFMycUxFUjVmS1REcTZwWlEyNXMxczJmSUMzbERNbHBN?= =?utf-8?B?ZmtiRU9yYU41ekNGU2lldVhOdXFWMzJFM21KM00vb1NuK0h6YTFvcjdVL2Rl?= =?utf-8?B?LzFDU0s4SFppYyswUzYxUzZ0cTEvaVJXNmFHQkk4N3M2cWxnRENwdm10R0Mx?= =?utf-8?B?VG1zTTQ0UWl0N0NBR2V6Vjl1ZE9HTmFlQytmNWdtY0xSelluWWdabVBLcDNH?= =?utf-8?B?NWIwV2ZRNXFYOEJnVjBpaUtZVm05TW41YlRoQWs4S1ZPa2U1T2E0dXRHMVhY?= =?utf-8?B?RkViMUtmQ0NvMDhrcnJCTmErQTUvazNJVHlNbVdyWXFDNmNlMHNEY25hQnEw?= =?utf-8?B?aFFPYXdqajE2aDdpSm8yK2ZkTUNKYlB5Q0lmTnhZQmllVkVESjY4M1ZEUzI1?= =?utf-8?B?Q2FyUS9IdnF0NVR2S3B3Zm9oUzltMDVGa1NOTTRqMmUrejc4VGtvdEtPUkdO?= =?utf-8?B?a2JNd21YY3BzdzRiYWh3eFNqdDN3d2VxZEFxcDVBNGl2UklpUVJLRDBXVVFD?= =?utf-8?B?QlYwNTNDdDZiSjhVb0tQUFMzVXpFOVhsS2ZmTENadmtYdnBKYkFNTFZwTFo4?= =?utf-8?B?enEvTUtmeUpad0k5dVYvWkhXNTZlNzJrZE9lS3ZRbTRRM2lOblNFVkMxaHJR?= =?utf-8?B?emZ4YTRkeHg5TjkxakJEYkVFbWd2RmVjRmxtMVF2UDd0TjBieVZ5eFlZZDF0?= =?utf-8?B?VVNva3YvaVg5aW1IUi9zcjNxTVZwMEgxTFV5U0pidk45cjlvVEt6VXJ2Q0xn?= =?utf-8?B?dm9JVVhqRzRjYlBwUkMycUFqZVhHSFdmQlhmVnI4eThvQUMrbEk4dGJFL2dJ?= =?utf-8?B?Sml6YTlkZUdNaERTWUY2eVNrY0JjYVpTdUxJYzQ5OGNFQ1dkQTFzOUZ3dGlU?= =?utf-8?B?ZVNuRGpJK0FBWFNwa05Rb1RVSE9meU9OYWs5S0U4amUrcUE9PQ==?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:31:05.8645 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: daa74f29-b26f-4cc1-9bad-08dd021a6bf6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF0001708E.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6183 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=ce1390c98af10b10a62004f28fa5ed90121fd760 Thanks. Xueming Li --- >From ce1390c98af10b10a62004f28fa5ed90121fd760 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:07 -0700 Subject: [PATCH] dma/idxd: fix free function mismatch in device probe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Cc: Xueming Li [ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] The data structure is allocated with rte_malloc and incorrectly freed in cleanup logic using free. Bugzilla ID: 1549 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Signed-off-by: Stephen Hemminger Reviewed-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 2ee78773bb..c314aee65c 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -300,7 +300,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, return nb_wqs; err: - free(pci); + rte_free(pci); return err_code; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:06.251908317 +0800 +++ 0018-dma-idxd-fix-free-function-mismatch-in-device-probe.patch 2024-11-11 14:23:05.032192841 +0800 @@ -1 +1 @@ -From 91b026fb46d987e68c1152b0bb5f0bc8f1f274db Mon Sep 17 00:00:00 2001 +From ce1390c98af10b10a62004f28fa5ed90121fd760 Mon Sep 17 00:00:00 2001 @@ -7,0 +8,3 @@ +Cc: Xueming Li + +[ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org @@ -26 +28 @@ -index 60ac219559..6ed03e96da 100644 +index 2ee78773bb..c314aee65c 100644 @@ -29 +31 @@ -@@ -301,7 +301,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, +@@ -300,7 +300,7 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,