From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 86F5445CE3 for ; Mon, 11 Nov 2024 07:29:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6505B4067A; Mon, 11 Nov 2024 07:29:24 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2060.outbound.protection.outlook.com [40.107.223.60]) by mails.dpdk.org (Postfix) with ESMTP id 5E8B44067A for ; Mon, 11 Nov 2024 07:29:23 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=c1jFWOb8RmC9a13lgBQguP8sCGGpGHfxV4i5Pn6sM87l89FOxZs02xQDw/L2Y40+O845p5GEdAMnYTQ3Gam4FER03drDkxTEunJFq+HzMjfFOpinM+EpN0/ptWr8R/7hLtv3N+qbvOZDe59JMVdk6bvDs6GGDANZHsDqRODPA0mcBuu35F6860N4MSty07pTF3bwIBzahCQxDuUOxR3YZq7a3vYebfRergmGEkAs/WrYdg7lnNOKPHg5weQ/3HlqnEiwYwpkMR15iToqKemro6rWj/o21iIS1aCESMY9MfhN7jYCVz0k6zyEY5/vWfFXbja26R/zSsciSI/56KWCtA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DaOWcJZuvz9VtzihaNjzqSjNvRkymXOarTIfFMM5mi4=; b=VRB/Lk/qOZ+2MUlroQN23wd8px9sbiWSq7FJP+ZxRztdmluDVrmF+2TL+4M2Xo31zkkcGLuGzL7XhPccX7GdCtjojPpi9AJdiZUY9EKCIdiQH7UeKMtZSyk/JhqgLWH9eREMDXTXJNPv3PPDYggnHvusn0ausIfLp+mpkiknYkbAdWtcMcMQ0xQdwtCAUUY9bMQZxtsz/ySSvCLV/q16i9Xnp95mRRO9GgYU4SU4NgX23gH+tNNApkxWDTNWh7z4Sx6Qq+CI6LJbWeqDLgT3dkgXKLqcNH4E9SL6exlv+oZ9FpyO0/ySOAtcxvfOHfMZpP41LvtmwvmX9Bq5Apywcw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DaOWcJZuvz9VtzihaNjzqSjNvRkymXOarTIfFMM5mi4=; b=NsLzAqcDw2Lr7ZCYDTpJPYEac3QZLdOjuwp51q5q1GyItp5YdKkN6i9qm+NCuZRCp1BaOWLmWIZknmJHZcl+tMvz1LTtFh4/l1HJ9oXCha/lJY716kS4XUsMLM/C37WcF8WPrUsdcC2OsSoZDP40bIHuowDp0Yl2bgvTUhS7W0IA0KB5XSwaiPPh54xstjG7vhfp9/fObN+VUa5JIHzJ6yNcYAy2QN/abg/g6VMf5EF8s2su9NmE3j9dFF9rzZuYWwLexGP9WrSIZ0c1SR4JujpGa1bJSWLiHAEhnmOicaEL8MNOwypIaG2oKdb43A9wyT0dyqg7a3Pjv129tuGXIw== Received: from BL0PR05CA0018.namprd05.prod.outlook.com (2603:10b6:208:91::28) by SJ2PR12MB9211.namprd12.prod.outlook.com (2603:10b6:a03:55e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 06:29:20 +0000 Received: from BN2PEPF000055E1.namprd21.prod.outlook.com (2603:10b6:208:91:cafe::e8) by BL0PR05CA0018.outlook.office365.com (2603:10b6:208:91::28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.15 via Frontend Transport; Mon, 11 Nov 2024 06:29:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000055E1.mail.protection.outlook.com (10.167.245.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.1 via Frontend Transport; Mon, 11 Nov 2024 06:29:19 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:29:07 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:29:05 -0800 From: Xueming Li To: Mingjin Ye CC: , dpdk stable Subject: patch 'bus/vdev: revert fix devargs in secondary process' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:26:47 +0800 Message-ID: <20241111062847.216344-2-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055E1:EE_|SJ2PR12MB9211:EE_ X-MS-Office365-Filtering-Correlation-Id: 9eba9a90-1fef-4dc2-ae7f-08dd021a2cb6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?m6zslck/aqn6dn/856DotaZZfiKQqdFaT7wUqM0G+xrEOSbTpHvQkBqQYI7X?= =?us-ascii?Q?fdPhm6CEyGqFDEWuM31oRA5bu89xtIw/DxwLKz3GFXpC2u4PJLa77DpuOtfP?= =?us-ascii?Q?oS3GPPJRa2VaRIBn198AlE5jY7Kdg/044PDzyo6Ga2K8bLyqNFL/8C6EDcCm?= =?us-ascii?Q?XCfz/95Q49S4je7kE7x0qu/7+BdsGdzXj6TXcwGTlVlDxGPfpK3dqd5+c/9+?= =?us-ascii?Q?AdR1JOwzxsZcXAowSUhaFn9rOnbrMrhazZt5XptYicmBP9opxUwoWTAbPwqM?= =?us-ascii?Q?RsD0kecNy9NNK/tE/261WSrND9lHqattuMAg9E8KIUAbFc11QgKb4QcQtxIF?= =?us-ascii?Q?P0KWGb6q1EkYKz9TufWMwZ4XuLnPtjj1fp/68Zcz7/F9C5hphq2XvKe6iAxd?= =?us-ascii?Q?JgXhIOX7ewVZj4LIYueLwU1rOeYd0AZBWeesrqsKwCQgkxh7QA/Ws/EA5nzk?= =?us-ascii?Q?/+cJeGfUSi2/oPxytdz9EMcECSce0H2sdbPRQT4w/j29UecHhJkskv5edeEq?= =?us-ascii?Q?Z3PVF6CiNabVlG0oLCVJG0oyBuSv+dip79LktDVz56Sa1utDgFlVKwMk55st?= =?us-ascii?Q?bc+E46SEWrPVMEc5DbT0Z70q9l3xTzIVkSawyY9evCGqdd+XRDP1BPIXrRD/?= =?us-ascii?Q?9d+ImlGS3IdLyNFVqhZtDbL7aj0sy94wWbWncl7GtcNqa30Pj25ClB1OENp9?= =?us-ascii?Q?j4LYf6jqCX/IBlVsG41nt+Ue/8yp9GP5h7bbz8XS2ihiiQDp7kN7LsjtiN7k?= =?us-ascii?Q?JJsl64UW8kzJtekxdRm6JEn8sHasj2PxTQDHjwG6yhVbAqMrhHGlgaDwinv0?= =?us-ascii?Q?Le5oWTRErNQNnOHzulBfjCOheErLfIIifUDSMqGUJMmQgv6tS4YvZ3QFPj1B?= =?us-ascii?Q?/+RFLx9A0skOeumy/TQrksvAkp2JHEgHjQYthjmL1WP8pqCxF6PJj7uRbvRH?= =?us-ascii?Q?MAFFLsmmPS83zkxQ2i8PmMnAWEK9MG0OFGK+VScwOLr2f640JZjSUJVytU6R?= =?us-ascii?Q?NryYb67TjB7ucftfAF0LOiCGrU5dRconk6ThRuQ5t9/uR5OZF+UYXpYDovID?= =?us-ascii?Q?dGq6lCHgf+DhCAOTFd4c9GjS1vaJhoy4em5xyVRbakTrAp87rpe8T3Ab5P7Y?= =?us-ascii?Q?b0E3CL7eIV/RLrx7qWJb0A2WOFbzbhVdEJGjVW1bFSVUoaTpqpriOXsATxWs?= =?us-ascii?Q?m7BGuSTlYKFB8s29ZI4qU8bbgUupzL2Wv50obmGfyi2GvXIA0oV0WtrtTmTW?= =?us-ascii?Q?9qb4bbWN94QLKp2MGgBr/WK/dugRNfyVzfr8tOqO9QUlhOTM7vXf9qd4CEW0?= =?us-ascii?Q?dwRvjoebv/jEaF4CsXhSNHEVMS20aEvtq1G+jKBJD8Wdlz58xgHXr+DrsBPz?= =?us-ascii?Q?Z9DWm5o0OiSOKY0MBN1HorzidaIAZUQy1uB4ud9wvgg7+1mLLA=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:29:19.7022 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9eba9a90-1fef-4dc2-ae7f-08dd021a2cb6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055E1.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9211 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=1d5ac7180a8b48033600cd7006a7da1a95991c1f Thanks. Xueming Li --- >From 1d5ac7180a8b48033600cd7006a7da1a95991c1f Mon Sep 17 00:00:00 2001 From: Mingjin Ye Date: Thu, 14 Mar 2024 09:36:28 +0000 Subject: [PATCH] bus/vdev: revert fix devargs in secondary process Cc: Xueming Li The ASan tool detected a memory leak in the vdev driver alloc_devargs. The previous commit was that when inserting a vdev device, the primary process alloc devargs and the secondary process looks for devargs. This causes the device to not be created if the secondary process does not initialise the vdev device. And, this is not the root cause. Therefore the following commit was reverted accordingly. After restoring this commit, the memory leak still exists. Bugzilla ID: 1450 Fixes: 6666628362c9 ("bus/vdev: fix devargs in secondary process") Cc: stable@dpdk.org Signed-off-by: Mingjin Ye --- drivers/bus/vdev/vdev.c | 21 +-------------------- 1 file changed, 1 insertion(+), 20 deletions(-) diff --git a/drivers/bus/vdev/vdev.c b/drivers/bus/vdev/vdev.c index dcedd0d4a0..ec7abe7cda 100644 --- a/drivers/bus/vdev/vdev.c +++ b/drivers/bus/vdev/vdev.c @@ -263,22 +263,6 @@ alloc_devargs(const char *name, const char *args) return devargs; } -static struct rte_devargs * -vdev_devargs_lookup(const char *name) -{ - struct rte_devargs *devargs; - char dev_name[32]; - - RTE_EAL_DEVARGS_FOREACH("vdev", devargs) { - devargs->bus->parse(devargs->name, &dev_name); - if (strcmp(dev_name, name) == 0) { - VDEV_LOG(INFO, "devargs matched %s", dev_name); - return devargs; - } - } - return NULL; -} - static int insert_vdev(const char *name, const char *args, struct rte_vdev_device **p_dev, @@ -291,10 +275,7 @@ insert_vdev(const char *name, const char *args, if (name == NULL) return -EINVAL; - if (rte_eal_process_type() == RTE_PROC_PRIMARY) - devargs = alloc_devargs(name, args); - else - devargs = vdev_devargs_lookup(name); + devargs = alloc_devargs(name, args); if (!devargs) return -ENOMEM; -- 2.34.1