From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8664745CE3 for ; Mon, 11 Nov 2024 07:32:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B5AB40685; Mon, 11 Nov 2024 07:32:39 +0100 (CET) Received: from NAM04-MW2-obe.outbound.protection.outlook.com (mail-mw2nam04on2051.outbound.protection.outlook.com [40.107.101.51]) by mails.dpdk.org (Postfix) with ESMTP id D1DBD40685 for ; Mon, 11 Nov 2024 07:32:37 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Ch2sGfZt2WvrjbxQebZckEcOeWGSb8AoBsuUE833SpBw0RWBpRKOdoszyyrjkFsTCuKy2NPEq2ismDcw0xTzPwwTrJxhoRvDm944ehn2QC6CXo65x2T2n9oLgJfOL6vDYJhNEt2Nzr0yfxzAfxsX17LJoooMwxTu4c35nS6YIm2xiRTKlaY1okabSWO5IHry2DNUgeIn1+iSM3L6AoYpaTDTsls+j51fU3NPoyleRo4C2w+7T41Y5BcU92VeqkJNZGIm1wlN5d6PJAuNrizoRxSOZJZiNRfBzc7uw0j72inQnwNfFKe2NdWvYoZO8Yq+hVU4Yn9vwFdEdHfOm/ooFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=jFLFZL1jV9WpvLTNDLBITy5knUDln5sNxgze19yzsnI=; b=Tw+a7djnyxMN6VKx7NgzkEokmovZ2EvuekUbqYL0ED+G9MWk+D5ka6NVqyXO+rUD3BTEl4T7l3rKGyzqJKjvWBWftL1vheS3fBUWJ6/DA7mS/KzOwHn3gQjzGefN0cSigRjVUm+BNrBQdXneyqBchXoIZLzOKOOWxjFNQ3lJS62TXbR2NeiE5IQXqJL4hfp6KUZ+xwQ8SGz6ObIxHpfbrrdE1dyuulrVgVGwwGrl4T4B0XOQWreVQDQqhe1lSCx2UYHZKYMaRQuqJaLyCZkDVsuqN5Sav5TkKif8+oijQcpptWDWdJjCVsMKzyKgUpMA/6/60FE5ZCQgk4tfaDSl7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=jFLFZL1jV9WpvLTNDLBITy5knUDln5sNxgze19yzsnI=; b=qk76hLNwXCPXccAc2KnqGPMJJZcemW7ZV3bx1s0jnivLR3sN9YYBw2H/HX0IFV8P0RUsZjea08rkWSHPpKBCGQ5UEy1LHAu5i3ZD0iMFcx1dVgl6BafdYOtN1lLM8lJmRv05za2gc9G3v2F5aLsQWecAr6cLFXcf6aRy2kDXXqMTovXUvkHLOyKxzdQpVyOTnlQRO/0oGp+dFaOACF8EagnDPLKbCCqLXFNkR31wNArs9hlNjgyi471qiHVUHLoiAb4+gn+BfXmMGLrT3duqCGXsy0wH2OqUhf642RVmNbJLDVcFA6ASreqDwqfDyllkqNp7zxCjc+schx3xickWrg== Received: from BN9PR03CA0280.namprd03.prod.outlook.com (2603:10b6:408:f5::15) by SJ2PR12MB9114.namprd12.prod.outlook.com (2603:10b6:a03:567::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 06:32:34 +0000 Received: from BL02EPF00021F6F.namprd02.prod.outlook.com (2603:10b6:408:f5:cafe::52) by BN9PR03CA0280.outlook.office365.com (2603:10b6:408:f5::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28 via Frontend Transport; Mon, 11 Nov 2024 06:32:34 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F6F.mail.protection.outlook.com (10.167.249.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:32:34 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:32:21 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:32:19 -0800 From: Xueming Li To: Vladimir Medvedkin CC: , David Marchand , "dpdk stable" Subject: patch 'fib6: add runtime checks in AVX512 lookup' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:27:16 +0800 Message-ID: <20241111062847.216344-31-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F6F:EE_|SJ2PR12MB9114:EE_ X-MS-Office365-Filtering-Correlation-Id: d05469ab-fe15-48f6-d6e1-08dd021aa0bd X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?PH6UUeK2eaOe28PI+uauTw+8JabKitii+/DLZ+Dx5lLMh/BcqsiBXrF2Q5jw?= =?us-ascii?Q?UfG84Gx6zs6dm12TAy8EFA7aGjDxE96s0KNAUyzPYkn1ZoC6BjWG2de+niFq?= =?us-ascii?Q?44O00Lv385V3gFKNiv6diOpujZIT8nb3Iy3O9f7HYHkrrNMgrPTXFHvmm/lj?= =?us-ascii?Q?YcB9rM3KymMlAV8raLdZP4Dm6cueTLaY5TnDw5yOSc4lviuKR5f5VDO+f8Am?= =?us-ascii?Q?4NF9qXSTCM5j69PhBWJm+hKYDhXhJK/l5AHtaIPdGzPk2+M3RQfcpMX76BDO?= =?us-ascii?Q?YiCROOn4F9FhSEPIFIijMxFRXHTrxG7dD5pJtthbAxqP03fKyFI/iln0D467?= =?us-ascii?Q?Q8Hx9lAQuNPZyFDoK6KaOIuDt9YVAJYht0/Mbz3MoY6dA15z9aDv+74czHt5?= =?us-ascii?Q?mSa4rSxSisII5hv6hYn5bXV5j4iX3mnsngtqJ5KykXw6XOugQ2/rkjrK0IQv?= =?us-ascii?Q?9+aK/1y4NXBevi3+M4YTQwkGuoS+H2KsBW1UudTFqaVJrEezhCeAfugzgt3S?= =?us-ascii?Q?v6MsjUtIBvos4lVS4sSgLB+2e6K/mWqbU4o1+flsTasJE9GGf1f5ICmEQtQM?= =?us-ascii?Q?ULiWrhv8va+q/Z/4800HY4/f6vd52nAr71rM2ot00HVG/qut0xlCHQH8ZpYn?= =?us-ascii?Q?ZWESx4ok9C0QYQVc6ngQSV+bCl2dyDfneJ13RdCM5BoEX4dvIUz47/5V1i0C?= =?us-ascii?Q?4daQ87HEEiWS/IOX6kJtTrT+uR1Df3sQImy0pNaWSHXNpfjzmCMDYM2ueK8P?= =?us-ascii?Q?FCCInsa67x0tXAjfnDG0gC+iitjwDBDh8qPOEthjbYvCE4qaq4T5g94sbYrJ?= =?us-ascii?Q?YJ3e+TI3LMQf241gE1CGQDculFaMzVVXwf8Dq2vW6WuFFAJMIh6Ea9JX1RCP?= =?us-ascii?Q?pQva6PuDAnhQV3wFC25OgqViXMowljjgbUYPuQC60/TVONl6ReiVr0ziUoXA?= =?us-ascii?Q?zs0T8dB+fWoG5ixAMQKDG8u3sYx0ImQ6GYuBSvEVvLJbaDu+wmzyGG1xHDHT?= =?us-ascii?Q?b5R3RTdn8Sgrajxf6v2wmiYGdHC9P0E/7OB0Zp4mRz43mC8pRB+pi/XCxPVW?= =?us-ascii?Q?2IkkSW9VpAy1SyRJsnGDMiPb/rHLYpShu61WS4pV+pggtQsA8zqhS1EopBkD?= =?us-ascii?Q?7svbF5yowW0W5SSnfltQNbDRKZrw7TRaMnpsi09OpJZvu5qIAiV2q2jNBAT5?= =?us-ascii?Q?FhjFU+6HxYnGCPCnSEkgruQz/+b34NuQblAyh/wKSxAP7COpK2XYs9AgtJLz?= =?us-ascii?Q?UDtqKnYXYn0gkp5v0P000FSYXf44T/sPm8cqqZik5y35OS9hZjtnwRhr5NHJ?= =?us-ascii?Q?iExDaPgNMQEdif5Iq72sAAr9MTjxjnuPcuZoz1CqVmiusLIUGpl8NxuYz+Xk?= =?us-ascii?Q?eqsuR7QlSmvMZg7Fqfjv/H0oy9q5/PFPFDpmM7dAIRiuS7lWyQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:32:34.3648 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d05469ab-fe15-48f6-d6e1-08dd021aa0bd X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F6F.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR12MB9114 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f2905ef63cc3d39bb2d3bd6156613ee5c4479e1f Thanks. Xueming Li --- >From f2905ef63cc3d39bb2d3bd6156613ee5c4479e1f Mon Sep 17 00:00:00 2001 From: Vladimir Medvedkin Date: Tue, 8 Oct 2024 17:31:36 +0000 Subject: [PATCH] fib6: add runtime checks in AVX512 lookup Cc: Xueming Li [ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] AVX512 lookup function requires CPU to support RTE_CPUFLAG_AVX512DQ and RTE_CPUFLAG_AVX512BW. Add runtime checks of these two flags when deciding if vector function can be used. Fixes: 1e5630e40d95 ("fib6: add AVX512 lookup") Signed-off-by: Vladimir Medvedkin Reviewed-by: David Marchand --- lib/fib/trie.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/fib/trie.c b/lib/fib/trie.c index 09470e7287..7b33cdaa7b 100644 --- a/lib/fib/trie.c +++ b/lib/fib/trie.c @@ -46,8 +46,10 @@ static inline rte_fib6_lookup_fn_t get_vector_fn(enum rte_fib_trie_nh_sz nh_sz) { #ifdef CC_TRIE_AVX512_SUPPORT - if ((rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0) || - (rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512)) + if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512F) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512DQ) <= 0 || + rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX512BW) <= 0 || + rte_vect_get_max_simd_bitwidth() < RTE_VECT_SIMD_512) return NULL; switch (nh_sz) { case RTE_FIB6_TRIE_2B: -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:06.699294108 +0800 +++ 0030-fib6-add-runtime-checks-in-AVX512-lookup.patch 2024-11-11 14:23:05.072192841 +0800 @@ -1 +1 @@ -From 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 Mon Sep 17 00:00:00 2001 +From f2905ef63cc3d39bb2d3bd6156613ee5c4479e1f Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 45ddc5660f9830f3b7b39ddaf57af02e80d589a4 ] @@ -11 +13,0 @@ -Cc: stable@dpdk.org