From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1171545CE3 for ; Mon, 11 Nov 2024 07:29:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AC0E40E09; Mon, 11 Nov 2024 07:29:43 +0100 (CET) Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02on2082.outbound.protection.outlook.com [40.107.212.82]) by mails.dpdk.org (Postfix) with ESMTP id DB93E40685 for ; Mon, 11 Nov 2024 07:29:41 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Fi23PMRwBxVFoPNr5NAUpEmDyi5xhxQYahZ4sZyKYqdz84UjU8WKZ+yZB7Sy6bgZC5AG5OvqtYUxn+Ks+edU3KW8bIK34Dhlu+x+ddBod2WKw4ZZv3jtFUEsyW52orcjxPcSqK/g17VbDkr11ZsG3a7nXA0N9je0BDUnJ3Q9E6MkcJrzSlycNDlRtZLATi9wDzNY6cx97Pm0QLoUB6XatBVIw7gMDpZGk4nJwake0WyuJioDa51OVG06M5fDQ4ydIZUkCn4HAdTHGsZng91H2z4FXz7AyJWDQF8P3OxTI5zcA1RkDzg2RkJ+vbY+Mv/Qf70RrqzVlWPI3mj2yFM+UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0CSfEYaxeERDESnHZxig0K9/xmZDE7yWoMlic70UUjk=; b=eZ651lHL98wxZ1HiUUoO76nhSWgDYhNoM1kNRnm2DfwHc4KUznYZrwfEqzS80T44XXCpnWSHbvigkhev8BQnCvqRSciwN1JrSfWmYdHwLEFN6HtOSeR8hCiqqkeGWl8So9b/Ua5sM6EVfu6JuIF1QpqN7pMO+XMZVlmskQnRRfE3smXR2MoD6mIhotlN01lWGe1jm+CTMqS90uSqNRan+vDDzxyUeQvioDW6p2GuaidVzpZewNjVpHFfmPI/rGSDr0hotEJxBDvh6H2yCMV2f65ObCGjzcRCg5h1+VZTkFzOIfdTVAawqI/vM+z3zZHgH/a1xMoFfJN5tq68k+yIMw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0CSfEYaxeERDESnHZxig0K9/xmZDE7yWoMlic70UUjk=; b=ozQ7BsbanOaNuudS2nufEjqy8HxhReox3cEBDnr6gkZo8XHRVmU/yoYrO8Ds6vOf9O+GO9egt+TtXLShqtxupyZipXt3leECngNcxievZtbTFAQI6eAd2djA/RET6jWEQ+yd9f36YqDB+wcSzPZqBamDwKCp3avJk4IdAZrM490/VLaAWX5ao9QCwhLmn4bH9Gsd+MdVrSHQjzlMevJ2ZnLtcLWLqSIqWblk8sbIFpCKU0nZLkYpjgIqAZ8VI763V5n6JCH80ivlOjfBgUZodUufb013BYTIZD7sNuQcGvn3SvfgsBG62Dr3wYR/7x80SDYnq5fA0bCCSsNIq5rtzA== Received: from BL1PR13CA0096.namprd13.prod.outlook.com (2603:10b6:208:2b9::11) by DM6PR12MB4418.namprd12.prod.outlook.com (2603:10b6:5:28e::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 06:29:38 +0000 Received: from BN2PEPF000055E0.namprd21.prod.outlook.com (2603:10b6:208:2b9:cafe::b3) by BL1PR13CA0096.outlook.office365.com (2603:10b6:208:2b9::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:29:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000055E0.mail.protection.outlook.com (10.167.245.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8182.1 via Frontend Transport; Mon, 11 Nov 2024 06:29:38 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:29:20 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:29:17 -0800 From: Xueming Li To: Bruce Richardson CC: , Radu Nicolau , "Tyler Retzlaff" , dpdk stable Subject: patch 'eal/x86: fix 32-bit write combining store' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:26:50 +0800 Message-ID: <20241111062847.216344-5-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000055E0:EE_|DM6PR12MB4418:EE_ X-MS-Office365-Filtering-Correlation-Id: 97985a80-f44c-4812-379e-08dd021a37b8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|376014|82310400026|36860700013; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?zFUy6DHE5n3GSfq79wDw0OP7wlP7DFpzLy85xnYgsSDIJyPwXEnzsXyTTN7B?= =?us-ascii?Q?X3+SNaUEWbpmV4OlkyTY2Nww9autmbK/7F4G0Qzm6b0c8JD4mfNsCzK2BJuH?= =?us-ascii?Q?pYkeKfOUJ3G5c/P0pDSpbb/1uunpTffduoUXNDfZw/YNAaK+nwvRqg3F2Tv3?= =?us-ascii?Q?R9Y46qWIoUBLIoW/xWjS9FD3JsY7CRo2wdx0q1EaFYNG1CArUlI0EWV4tMuZ?= =?us-ascii?Q?5f+KAyYm2J07msp34c3efSk1VW8U8p4xTAcjLXHd17uuvLHszizXEZ9Zx+Ta?= =?us-ascii?Q?3YWJkAwDGfPf+OZnwwxQJ02+wWVarNVMY/U3jsMyN78pDlLh7uyuZqzPmpHL?= =?us-ascii?Q?r8JUPnAPuyiBsRljHV50B5uscDgZtAvcWMNsUq1FpYwzlxS8Q1Ja2JVvQx2w?= =?us-ascii?Q?hVXgK0W0p42Da8azwpD4NI/6Q70dxyCBfJhl8JyJbr/BtpwaPy6jBr38fsvy?= =?us-ascii?Q?DaTNzcnc0eG5ASDodmr2yldq+oJYrmXsiZYGrJHtfb0I+ZgfPpQoewsHDi5t?= =?us-ascii?Q?f0RdTLdnYj2T7hJTVhylBvnSeDnyv6JwusGuLj1bchpugp2JM0LbtWOKRkjP?= =?us-ascii?Q?Ovs4cuEldEkCaQ3Wdm0RX27NBvJjMO48p6PdQ8qjOmvwKKRnIkzg4QwWJa0a?= =?us-ascii?Q?G41qQDBEY7yW3U3D10tZZPV8qblIbAesgR5jBkRcXFvYlDY3ATfQ10GdA8YL?= =?us-ascii?Q?NAgXd1J8fe7107WtP4aqXYQeyCY0aB9nWTfLJC8V44oMJewCIYQI6873vysm?= =?us-ascii?Q?kk+VkBEHCKg+2DoGm8CEdR9rPrmeIsqZ+Q0jsz+VZHc1M5le97qImLuWZrVB?= =?us-ascii?Q?nBRC14x6gxP3zUQHaYq7jfbsdS4EI3jhPOoE/u+CJmSSlUC/Oiqx1Y7j7M8O?= =?us-ascii?Q?qFIlhkg/YwsjwhjEbdryKjyKprP1oAjSXs2lIzqOh0daot7iMTtdCfGBgUCc?= =?us-ascii?Q?SASyAQTp0On2oC1ZA7THTAqPH1J3S+QT/OpYCICxahr4EquCqOWIpm7W3cO/?= =?us-ascii?Q?gyn3IbVGp4bi8F+1DpMi27MAE5n4p2I2bdSozdin0puomncSj9hweUja72lB?= =?us-ascii?Q?MaipaQSiGIWelUS2+crGVzSEwD60zpm2ERvEIGF2EOsBRtFFsFB+uDiA90k4?= =?us-ascii?Q?uPF4YMyii9nrR+jBtQfmyXVe2qtBDlw0hPukndc2KuExcqaJTpZBpZwyLNwy?= =?us-ascii?Q?WB7JtYyxpUdHFHSpgHcFcOHRJuT9oAInaWPESn5CmtRNo2A4GZMH8kVw6rS8?= =?us-ascii?Q?8uAvKGUwff7xysWa0jz60OUI1ZYhL3eGdm+xsnfq7Od2EOMf35PKciN5kQFB?= =?us-ascii?Q?QMwUzVbpJEL6zvTFIGLhQCoQu/HsfysHKaNaWZ0brjE7xqBM8dm2UXhML+zS?= =?us-ascii?Q?yGA52l11URnr8FPWodHMod3m0VRtiHbWmsFNeQ9uoLAQq8+Xrg=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(1800799024)(376014)(82310400026)(36860700013); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:29:38.1359 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 97985a80-f44c-4812-379e-08dd021a37b8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000055E0.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4418 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=f3f7310081a8db84e56dbeefa092c52874dedcc5 Thanks. Xueming Li --- >From f3f7310081a8db84e56dbeefa092c52874dedcc5 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Fri, 6 Sep 2024 14:27:57 +0100 Subject: [PATCH] eal/x86: fix 32-bit write combining store Cc: Xueming Li [ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] The "movdiri" instruction is given as a series of bytes in rte_io.h so that it works on compilers/assemblers which are unaware of the instruction. The REX prefix (0x40) on this instruction is invalid for 32-bit code, causing issues. Thankfully, the prefix is unnecessary in 64-bit code, since the data size used is 32-bits. Fixes: 8a00dfc738fe ("eal: add write combining store") Signed-off-by: Bruce Richardson Acked-by: Radu Nicolau Acked-by: Tyler Retzlaff --- lib/eal/x86/include/rte_io.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eal/x86/include/rte_io.h b/lib/eal/x86/include/rte_io.h index 0e1fefdee1..5366e09c47 100644 --- a/lib/eal/x86/include/rte_io.h +++ b/lib/eal/x86/include/rte_io.h @@ -24,7 +24,7 @@ __rte_x86_movdiri(uint32_t value, volatile void *addr) { asm volatile( /* MOVDIRI */ - ".byte 0x40, 0x0f, 0x38, 0xf9, 0x02" + ".byte 0x0f, 0x38, 0xf9, 0x02" : : "a" (value), "d" (addr)); } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:05.736952027 +0800 +++ 0004-eal-x86-fix-32-bit-write-combining-store.patch 2024-11-11 14:23:05.002192842 +0800 @@ -1 +1 @@ -From 41b09d64e35b877e8f29c4e5a8cf944e303695dd Mon Sep 17 00:00:00 2001 +From f3f7310081a8db84e56dbeefa092c52874dedcc5 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 41b09d64e35b877e8f29c4e5a8cf944e303695dd ] @@ -15 +17,0 @@ -Cc: stable@dpdk.org