From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7486545CE3 for ; Mon, 11 Nov 2024 07:34:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 68A0240685; Mon, 11 Nov 2024 07:34:43 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2088.outbound.protection.outlook.com [40.107.94.88]) by mails.dpdk.org (Postfix) with ESMTP id 0FFEC40685 for ; Mon, 11 Nov 2024 07:34:42 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=eVPrY9lWpFdr+NyVv/ITuSw7MH6pQWcJONMReuvKVysytwXlF74O1+3ctfys/W5K3MBFoHRTZlukQYzhV4HE3fBnuR9aEsVnhNgJElv3Z4AQ9adqnxV2qhwcxqvevJj5FX2T+80kO8qXQxHSaUMnl1nqQ1WGm6AUmdG7NCc4Jvnn+a85Z21Tmi1V2Oa9IklPD+1+9jaj746vbfsTjk4a5zHjrPp3fi6Ol0gFNTtZegrWnbDi3RKBiN6n1MBi0+mXU0xD8XtKOzMmffXvCS0OsxlQ+vcdLsFh+PQ/c7NlkCEZxQNMfBicN56r8o7oWtX+Y7JtTzk6SIdnXMJNgp6BZA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cCqqUzcuPzF6QBENOGQX5mePEKuhzIR1g0DwYqSB2E4=; b=RQ6W4buYsvKeniS3O1ILI68OUYiAqFUkSbMpDbzkP+yFLPQv5GHjXsUTiWyBKciIKfpCA7pQNs0G4vq34cZDULekbke2Rbi/VsjNG0LgIsEmCMgDmqDdNfyqNqv7DkwscKwwuxDWS97+8eSbRll8RpkTG7EelxmMiFdRi8xrgnmmhZoXciIWdD5dVSlc1feiJj+UqRMNi8QVdeaokYcuy7Q+ZNxHO5o50WQXSKYLpES5TIkC366m2+RqJl34tSSJhEGE7RFz0CymYiUjjGXqQJHqsWC0f6GSdXdxvl6WQB+/IWgA1kIi6w3OQW2lhLrhmrZWlwXuxXO8p0ELbin2+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=cestc.cn smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cCqqUzcuPzF6QBENOGQX5mePEKuhzIR1g0DwYqSB2E4=; b=HwwtOr2HHCXYNvG7cjLtwFhrOyXHQHbK/bIVqfu3Vun0MSbKYrMXhkS4yBLIljEm4fCON+6C/MEP3FdiFAJnFFaXyykmTyfUN5J0huIQ8q0s8+QfMn7SKkEEU54kJKiwHtndyaqyvPBTdGelFo1XM7LXRKs8poxf1Y7yyUIRzyvvjdmnfJtS5dEaCcJEaifVLprX/UaVo22uxwl+hvLafast3WFWXf9TaD3fj+xJcon+w67bIksaBbGqAtPFhNXk0INmG/qZYWpx4tN6Jh/oUBjZ5pN+8W8Y/xE21ttLH05JRn4hJw0L7FWVf7F/wyMNFlgsZpkhUoDkXT//pVpLmQ== Received: from MN0P223CA0017.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:52b::8) by DM4PR12MB6136.namprd12.prod.outlook.com (2603:10b6:8:a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.27; Mon, 11 Nov 2024 06:34:39 +0000 Received: from BN2PEPF000044AA.namprd04.prod.outlook.com (2603:10b6:208:52b:cafe::47) by MN0P223CA0017.outlook.office365.com (2603:10b6:208:52b::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28 via Frontend Transport; Mon, 11 Nov 2024 06:34:38 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044AA.mail.protection.outlook.com (10.167.243.105) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:34:37 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:34:25 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:34:23 -0800 From: Xueming Li To: Jun Wang CC: , Bruce Richardson , "dpdk stable" Subject: patch 'net/e1000: fix link status crash in secondary process' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:27:39 +0800 Message-ID: <20241111062847.216344-54-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044AA:EE_|DM4PR12MB6136:EE_ X-MS-Office365-Filtering-Correlation-Id: d6a0525c-8fdd-45e6-2930-08dd021aea27 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|82310400026|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?M1wVzAwRTr5IbPAs5ItLjhOleueNewOJ7SjZ1jyV/08ueNw9v6TogudHtU4Q?= =?us-ascii?Q?7Zwf6xR05XPxMt6ofmnodC+ljgb7bizJjbSdn1yyGfmpPJGXxTmcY8PnUb2J?= =?us-ascii?Q?fpBo8B7lYXHUO9Et4DKtCnPXVfeCcrMSRGsbrk5F+IH3lZdB3eLOUviperej?= =?us-ascii?Q?SosLhD38Be4xiGPjrKEjcMZJcU1S0KMnOUa3Xl//jUrtDEyADl4pOZw0kjub?= =?us-ascii?Q?x9htsWOSnImN3G4aHQ9dlrb+kd57JbXdRSdfqa9vDq6B1lh0Ba5mMOucszYr?= =?us-ascii?Q?svPb4ezLBrJ0govXzOzWRkoqHwWmR+KSZjiFP7taDmXamlH8jDV0alpcq8Hm?= =?us-ascii?Q?NXl91gNPaL/Scr81ENIRyLK3/fG5sttj3y6IcFmf85JRdB+a37+BXQP9d3VB?= =?us-ascii?Q?6GC1U4+OoFwwFxVJuRYoT6dEI7MIVHiEbHRc4fwLL6KAyWXRxK2WB4ZGgfud?= =?us-ascii?Q?k9T8B4jYQmEMNHT7T+GARcJZ5d319xJ4CV7hFVqC8fbhQ8b18oos3buFTKPl?= =?us-ascii?Q?/JFLuYyUL4h+q0tDTRxQpOmk9H/YuZkbL+JMlecEPpY05Kn9J2nFDiarSY2/?= =?us-ascii?Q?S6ASTpbfweeYHwUZcSB+RxJFIPPjgpAYT4O6kQ8nWJco+oX6zO7l0l7Oc4kf?= =?us-ascii?Q?7iEc8Qyp0fyLB3PJ0YwPeDPFgMFyXLiKpx0YaMULqglxGmDVo8DQz8FwV8/V?= =?us-ascii?Q?A9DZEgJ74KA/cwixfs4+eNlXCJITujXleAl5gpGHt33mLKKdzwEKKchU/6k2?= =?us-ascii?Q?dOjuAM4HZn9MhXXk+2u9PuFke/t2/CZWMHAXXNm4EttxVcH2ls4LRYNECykd?= =?us-ascii?Q?q211rqI+OXho2irWnednJiu1RdN2tM3HIqOGOPqWSbAOQTzrk+QVwP5P93sg?= =?us-ascii?Q?5UVTz9gPo1w/ruY6mF2VS+zBRVdiUcomKwIPuoPf2gw+C00fvoHFmhWQ2OIr?= =?us-ascii?Q?nqTQkq5Y2X7fo0ymtZRoLkB+EDRyOcbRLOBKGEvzwtJKrCSCUGMEvMU9csVf?= =?us-ascii?Q?Q04tq5k1QTJfn1cAT8Anss3++6aD4flc0F25l3ItVfhkW/tZkzNrQhJgbbkd?= =?us-ascii?Q?1Y4xBZ9TJkxheDieAuKYJCFSa8gTitfBg/2guXRJqis+M7rvWwZ426Wdadkq?= =?us-ascii?Q?hqdaxf97fHtoe8/d6hMRAOGaTQmc94z/zlh8fMgyU98B3rFkMx/sxiY4vKmz?= =?us-ascii?Q?6hOYRCmv3x8AeUHO3985WWCCEN7gSb+vh51Qqiy7QA6MH7LY1mioqHSRF+hX?= =?us-ascii?Q?THKVCvWS/CdkxndOZs1HDMvTR+Iki7J2aD9jAG4bPTAF5Z4IJY8tWIA5Nht3?= =?us-ascii?Q?VJ2h2pE1YhmNNMQck8XB+1xwpMYpB+XoCxFkhSpoCrAJGonHdJejLLGGmS+W?= =?us-ascii?Q?7ZdsC8Y738YW+0Rf00YyPSw9zJzdQbeeZMz6Y/qhY9MnLTy+7g=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(82310400026)(1800799024)(376014); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:34:37.5287 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d6a0525c-8fdd-45e6-2930-08dd021aea27 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044AA.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6136 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=be22d7ff5d84de7805ebe4e4db3993114ea16408 Thanks. Xueming Li --- >From be22d7ff5d84de7805ebe4e4db3993114ea16408 Mon Sep 17 00:00:00 2001 From: Jun Wang Date: Fri, 12 Jul 2024 19:30:47 +0800 Subject: [PATCH] net/e1000: fix link status crash in secondary process Cc: Xueming Li [ upstream commit 84506cfe07326fd6ddb158f3fa57bd678751561a ] The code to update link status is not safe in secondary process. If called from secondary it will crash, example from dumpcap: /dpdk/app/dpdk-dumpcap -i 0000:00:04.0 File: /tmp/dpdk-dumpcap_0_0000:00:04.0_20240723020203.pcapng Segmentation fault (core dumped) Fixes: 805803445a02 ("e1000: support EM devices (also known as e1000/e1000e)") Signed-off-by: Jun Wang Acked-by: Bruce Richardson --- drivers/net/e1000/em_ethdev.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index c5a4dec693..f6875b0762 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -1136,6 +1136,9 @@ eth_em_link_update(struct rte_eth_dev *dev, int wait_to_complete) struct rte_eth_link link; int link_up, count; + if (rte_eal_process_type() != RTE_PROC_PRIMARY) + return -1; + link_up = 0; hw->mac.get_link_status = 1; -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:07.638718189 +0800 +++ 0053-net-e1000-fix-link-status-crash-in-secondary-process.patch 2024-11-11 14:23:05.122192840 +0800 @@ -1 +1 @@ -From 84506cfe07326fd6ddb158f3fa57bd678751561a Mon Sep 17 00:00:00 2001 +From be22d7ff5d84de7805ebe4e4db3993114ea16408 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 84506cfe07326fd6ddb158f3fa57bd678751561a ] @@ -14 +16,0 @@ -Cc: stable@dpdk.org