From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AF9D45CE3 for ; Mon, 11 Nov 2024 07:36:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3317E40685; Mon, 11 Nov 2024 07:36:14 +0100 (CET) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2054.outbound.protection.outlook.com [40.107.237.54]) by mails.dpdk.org (Postfix) with ESMTP id 9175040685 for ; Mon, 11 Nov 2024 07:36:12 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=LQu7uwLQyLq/pBhV2d04Qyfd/nciCm+IX9f74BYgTOpBvpoJdJ/GpEK2ZbFTnMy3f1vqQIRLEFTlRskaMimqlOvhxFOuuAC9io340fRP5yAyCgZA9FNTlBdIJYwaVIHeGhqolCg71SE8ZXSTozE4gwvoenEzMmccd4hT090YRmvkcKYds/oWHp2WCVjaHm0liixw9fMl7LrLKZ1YV8n9UnjDmuGt69qo9H2/SO89DtE1np1G8nnnOP6H2JJ7hP+faYlREM177ateQmh8f7hEnkpd7Nkmm+M4B+FzUX5a6dG6HStnSbATJ0OL6LR+49TSrn5WW/Pqe9A8whwyLaTLFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=HH0nzx276k1u7mxYZS+XRcTouiIRpkS7+zU+s4VW12A=; b=ilV5oxjfWqTXUcPhfk6A7vD5USfL33nuVDm8xqdNMlvoVhLIyUL4kIYsJUN9Grbnh7v0VAwBuiWGwlGzEFbIMukqUA8vHOkaeaQTfphHLjLvzqStinyZxgeW5sRsHohkyNSv2XHUw1Q74e8Xn2hPModvkA/6omUJWGVjbvQjZur8w77LERheicEPnHPuzr0L3GIL9auYijSO4jVrLDcJ2ElhfGyy3Oo86i2mY7YeNxeJZpAJgusXUhCCkfQcv55muCc7O4SKBruJBtKS/1Hjsr5gDYCoLpfg7Krt8Hbz6Bv+3BiPkuP5rR9MGaPrYI9tURLkU1ijAk3s4807BgiMkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HH0nzx276k1u7mxYZS+XRcTouiIRpkS7+zU+s4VW12A=; b=WT20tDnc/J629BGvnaLF1st/aXA1BCn3fvVc1tCc95EUEqzYKhAccMS1DWo+rvSn1+oeG5SUCREZYX1FjmCZCicKHn/p6RGtj3lG11yAe9bTN5glxfkOeGPUJNaUy90gggjQV07Efa6fkdqDpNyGWB6WUQVY4+G0j8IbBynqW6S+XKO7yuqp0qumHdAGyFhkrRQ72//q1KagGG7Row/bl9wG3A8i6R7CNdM2+GeGKrS4roItzcngP89t+mfZVrkMEsxv18RQQSfMRxGFXlY6b0U88zOUroNLbRBs+nPiRLzgixBdttV4rpZzjPA8HWmEUiClzHtdSPD8qB/qHYr+Fg== Received: from BN9PR03CA0952.namprd03.prod.outlook.com (2603:10b6:408:108::27) by CYXPR12MB9441.namprd12.prod.outlook.com (2603:10b6:930:dc::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.18; Mon, 11 Nov 2024 06:36:07 +0000 Received: from BN2PEPF000044A8.namprd04.prod.outlook.com (2603:10b6:408:108:cafe::66) by BN9PR03CA0952.outlook.office365.com (2603:10b6:408:108::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26 via Frontend Transport; Mon, 11 Nov 2024 06:36:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A8.mail.protection.outlook.com (10.167.243.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:36:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:35:51 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:35:49 -0800 From: Xueming Li To: Barbara Skobiej CC: , Anatoly Burakov , "Bruce Richardson" , dpdk stable Subject: patch 'net/i40e/base: fix unchecked return value' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:27:52 +0800 Message-ID: <20241111062847.216344-67-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A8:EE_|CYXPR12MB9441:EE_ X-MS-Office365-Filtering-Correlation-Id: 382130b3-d061-4298-54d3-08dd021b1fc1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|36860700013|1800799024|82310400026; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?qA7EQICT+OlBrEwgvzo9S25v0npP5Hwe6k1uVmkpO7w1GJr+B0u9DZUojdbn?= =?us-ascii?Q?va5VmCicFfwRCjNZOatkw7PW8JswbiSdwquyySpyWoRy/WWaN0+cDbv5Avps?= =?us-ascii?Q?k6CNPbuwfueHtTIhBtwPy0xkSXHbrgF8b4fL4Nx3vGOakyWxPdQ8Kh51BbgP?= =?us-ascii?Q?YlyWt+uVmEvwxrlOVEQLuCfSKVDeTQS3NEOK0v8ySZ1N2axt6j1W0mZYaJXn?= =?us-ascii?Q?I0D0FT/UoYnDAf4w9c4yyxYQplPdCR3vaKLflkM9yyXA5t3K0Ha9/0s7P5IQ?= =?us-ascii?Q?oIpvFgiVMyIsPSp0gvuVW2nPoGDtvj77/NdWJLS0XFUPoEWiAPCVKk5wX9ZG?= =?us-ascii?Q?zoIcXyhriamHzybHn4VgOa6MMJNtR8J4kNuI78WRJH30DpkynJv9XfNrBMuP?= =?us-ascii?Q?+1/+CNCdpgQZoVbh0iH4ImNH/AmiKNmuNY7pi3gijL7Ehy98U53UW1mPUTdN?= =?us-ascii?Q?jbiNRwZH+RpN3GKhTbQbugO9NrmcgxE9yTJJoeQ1BKhdji3VKrKpwT0Qz20z?= =?us-ascii?Q?i3Qnd2eIFz67omV8HvexMJ1QN24oK7Oka86NO4cz8FEwv3GimQ1fst5rL41M?= =?us-ascii?Q?hRLUSOuwvoKIYpMFchFnBxzWt7ixaVb98v3uafRBmR3pvkeoVAOBzIRJc8/H?= =?us-ascii?Q?oxmCJs/EpCZlXdSi5Z4eBQi7gsZsfA8HZLweWLZRQUcPag+yZYA3cMsetVRg?= =?us-ascii?Q?QzQBb+ECg/DAuCh1Vp/ANyC2jnTRJbt58zJH4iFw2DAJ535Kdqf9I4hpzQgu?= =?us-ascii?Q?McyQuT7kgPNg9X769279XzqcODdUgk+Jzx6ZcXHCFcDd3n1vQxaiHsxgPqYE?= =?us-ascii?Q?IZosP51TBkO5hmw/MORHWbOp2MmXrUro1g3YgcCRg4G+KL8ISCcs0zH2HG3/?= =?us-ascii?Q?9Ih9eflydPb3GTvbxNEcb8LDZ2oISSy8ALfqflYmAK+HgkNiUqYquh6Wz73v?= =?us-ascii?Q?T22k7YYlvhQzt6GvWouoXdHFEIysLdLeR49RJGuPGyhOSSp4OIaavLfgWbHQ?= =?us-ascii?Q?FOoX/Hz/5RSBqS9Sescs0LA48JaSHACZhUu6oOz53yXdwirdhQPPdMBB71tm?= =?us-ascii?Q?mb+00A8W68kPGiialCB8Eawu4G9AVfDgLhLJdn9vbMdMsi2cbADfQTTbbcS0?= =?us-ascii?Q?APlTUOAUVYKttRwFGI2mJnOzyO71xOB1/bOaJKSHGLaFFQNTYPQvb/I+koNW?= =?us-ascii?Q?FrH285DDyXesVxjrvSvKRGop3pctkI3HJBrLLyAedII9MMAe0iiH/PObznBT?= =?us-ascii?Q?JkiXFxcgzjSQYKjrvJT/v77qOWfdxmGL3sE7H7q/Os03EihY/asgFU/fXWv3?= =?us-ascii?Q?JMYzejBfmGm+7fkmDBZT5PTIKPaIv0XFlmk4GuLg/QbDgAP+Q6q90mNmDt6t?= =?us-ascii?Q?gYjC4A8RONH+ZHhs6Up/aSUhj8vMjlQJi3TU6g1zrO4D9GtC/g=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(376014)(36860700013)(1800799024)(82310400026); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:36:07.4427 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 382130b3-d061-4298-54d3-08dd021b1fc1 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A8.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9441 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=bfc9bdcad325d486a798120507a7d93bfce2473d Thanks. Xueming Li --- >From bfc9bdcad325d486a798120507a7d93bfce2473d Mon Sep 17 00:00:00 2001 From: Barbara Skobiej Date: Mon, 2 Sep 2024 10:54:34 +0100 Subject: [PATCH] net/i40e/base: fix unchecked return value Cc: Xueming Li [ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] Static analysis tools have reported an unchecked return value warning. Address the warning by checking return value. Fixes: 2450cc2dc871 ("i40e/base: find partition id in NPAR mode and disable FCoE") Signed-off-by: Barbara Skobiej Signed-off-by: Anatoly Burakov Acked-by: Bruce Richardson --- drivers/net/i40e/base/i40e_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c index 4d565963a9..547f5e3c2c 100644 --- a/drivers/net/i40e/base/i40e_common.c +++ b/drivers/net/i40e/base/i40e_common.c @@ -4228,8 +4228,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, /* use AQ read to get the physical register offset instead * of the port relative offset */ - i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); - if (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK)) + status = i40e_aq_debug_read_register(hw, port_cfg_reg, &port_cfg, NULL); + if ((status == I40E_SUCCESS) && (!(port_cfg & I40E_PRTGEN_CNF_PORT_DIS_MASK))) hw->num_ports++; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:08.330951475 +0800 +++ 0066-net-i40e-base-fix-unchecked-return-value.patch 2024-11-11 14:23:05.162192839 +0800 @@ -1 +1 @@ -From 7fb34b9141aab299c2b84656ec5b12bf41f1c21d Mon Sep 17 00:00:00 2001 +From bfc9bdcad325d486a798120507a7d93bfce2473d Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 7fb34b9141aab299c2b84656ec5b12bf41f1c21d ] @@ -10 +12,0 @@ -Cc: stable@dpdk.org @@ -20 +22 @@ -index 416f31dcc3..07e18deaea 100644 +index 4d565963a9..547f5e3c2c 100644 @@ -23 +25 @@ -@@ -4215,8 +4215,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff, +@@ -4228,8 +4228,8 @@ STATIC void i40e_parse_discover_capabilities(struct i40e_hw *hw, void *buff,