From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BA6BF45CE3 for ; Mon, 11 Nov 2024 07:37:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AAE8340E37; Mon, 11 Nov 2024 07:37:12 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2060.outbound.protection.outlook.com [40.107.243.60]) by mails.dpdk.org (Postfix) with ESMTP id 6E1FA40685 for ; Mon, 11 Nov 2024 07:37:11 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SyDXf3qXEbIQXgn2D/DcQIqy9dtWnj8+jqutHwU6quoMS5zcewcokCGCVDFV4qB8Dtxp0VPbqtwdKEDbliO7/Y++Ux3M+YwAohIrQM3+5spooIZQmiViJvkPwtMB7kgraonmHE1CRDiqWYaq5l6yDfcYcEDxwtBkSo1DA0q+mNXkzqV1jieb08LFBkI41H9V7s5/hWMwnlK5tTF0+XAcmc91HzECBRBcXcMI59jDYPOslXJVi37FLDUFqKaZ9OU2ouE1BIvDxXeIFVs+3033K7GynEOqKXPpS1eCo1fIf/urcBIKAQ/RYfjGj+TfI7R9qos5WG1/QTZHvCMCsXDFig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YDzBr/NmK94b/SCUvic/8m3tzURROh5H7FSR7RhKOPc=; b=G5WLEVmH+EEhIRD641AGaTf+4BO4Relo1192f1IPLF0qKt5yahC6R+2SRvK0j1Y6ZZ2wwM32uj0YLi778FgEp6cbbu0maBr+juZlcT4ORewCRWKGbtSRFQCaU2WD36aqL8tFG8nPBd95ClUH5DgwBvyT6o0tHinbyD43XFcCPsqdNk5OpbGJUQsQzTHeHCy+JnbscJwhyO/4KET6XtqdDOs/l4IgkBz9+hFOOyGm/lmioEHAgbO5IMSN2ru4NVpR+0a14Ayao0RTjqbXaMiv+VK3DjHfDTBcLGWpZx5xqqmUVRd4+y/bwhYPVmtCnMvTLLVluFik0HXE7Iggy7WxoQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=gmail.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YDzBr/NmK94b/SCUvic/8m3tzURROh5H7FSR7RhKOPc=; b=Pk8Ko9ekhLoRry2u5ce0g94jLCvoaH9pBV1wZHbX7uGnPb/410KSRCb7iS949gJ6vgcCZB6n5GP8cX/mvWkgaPuLanhmOy/1oar0r4SGDGliDBtNLhXBem4x75F3YOTO6VxXMe7Sf9o4D/l2neK2WOWQTmmHeWl+9oue7yURoHzlhf9tEe6u1RS1/hTVBr7TKMuEfi3e1NVsNqDpysof1PJEG9m9GvC6beIQTha4oSICwQBu73r0XOavO0d3NZKfG6jgz6JOBKPYcnJ1COadcPkEkEay9pNA/vU3pKXTWEsOX7O8iYH58wVpB6vw9re6j/VjNMTlCYONiF0HXoiA0w== Received: from BN9PR03CA0756.namprd03.prod.outlook.com (2603:10b6:408:13a::11) by IA0PR12MB7752.namprd12.prod.outlook.com (2603:10b6:208:442::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.26; Mon, 11 Nov 2024 06:37:07 +0000 Received: from BL02EPF00021F69.namprd02.prod.outlook.com (2603:10b6:408:13a:cafe::56) by BN9PR03CA0756.outlook.office365.com (2603:10b6:408:13a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28 via Frontend Transport; Mon, 11 Nov 2024 06:37:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by BL02EPF00021F69.mail.protection.outlook.com (10.167.249.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:37:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:36:56 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:36:54 -0800 From: Xueming Li To: Shreesh Adiga <16567adigashreesh@gmail.com> CC: , Long Li , dpdk stable Subject: patch 'net/mana: support rdma-core via pkg-config' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:28:04 +0800 Message-ID: <20241111062847.216344-79-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL02EPF00021F69:EE_|IA0PR12MB7752:EE_ X-MS-Office365-Filtering-Correlation-Id: 58a92db8-a0bd-4030-d61a-08dd021b433a X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?tDOEHCfwU7wzxX/1soqcoIXXYaf+dg7qPXLQT6M1mEPNmvgbu6ITHBT5DmuP?= =?us-ascii?Q?O7Q/1y973WSsRr4D9yuxiKpPpSrIVhAjbs7NGt+7rCmpEKjgNM+nhM790jl4?= =?us-ascii?Q?WqubUpX9gPuXCHbsaSloSJX/fkI9xDoReQ1eLgHYLBku9vUwasV0rFdxLFPu?= =?us-ascii?Q?ddpyTNE3ONeqSXLuuhj2dwQAkWzdk1H/7ulCY92PgCPBPHCumtmXH0aVwMtt?= =?us-ascii?Q?sd5IPG8FT8//knTRXGal2wYkjach8mRM7RlVJOJwtuaxoS+Hjpbpb9X/oO9Y?= =?us-ascii?Q?jWgKxcJU23mMWV3aPcklw1JsK1whipRpzKat7/xjgDjtlVnFCUWoSkRnBWaD?= =?us-ascii?Q?tv4tsqqdvV174H5hZrlKmh/dkHf6IVqeyXCLX71+XaMW502fRy/8z3Y4hD95?= =?us-ascii?Q?PzwtFn/YrgqR38JQBc5ukJVeCXjo9hSPwwzlOS+S/CvixTNQzZPq9J258bzf?= =?us-ascii?Q?M/o9BML6dL4wNPhCvSmyZZwFA0XzFXZmbcPas8gBlLOUgDzXOVMjjSzqEVMc?= =?us-ascii?Q?uvDFCjXXdTkg2Kb8Zxce+BJ2QfbmilyQCbTY+eSCkmyzwHsP6KEYzaTESi4S?= =?us-ascii?Q?fpYBi5QRjNUYU1ufw9crKGc/dolWzZkBjyESocfMjMfLH6xgrI6Yw7UUno4Z?= =?us-ascii?Q?DBlPMdhKzXGW9WAvMUrURlYJX+ins/iEBFZxAL42l1mGwxILX/zX6ImgGbq+?= =?us-ascii?Q?z9vTLvrEe2v8FzfwiOt08GAUwGYx4vHU515yhvReIBva213FTMdeNuYi3Kve?= =?us-ascii?Q?64J0+maTFNvhO5fyd6bq+jtYMtMTwKgP3vegQkWnCAEOijuJiSjfH7LZTv1Y?= =?us-ascii?Q?zejPU1XvhqG3B/BorHvMt/68UvDsTWp48lOkMaUWx94HX/D5l22Al+EDEwA7?= =?us-ascii?Q?H4s52FF0pafjhWC6IwyjRmdCNqL1/8rp9XPRy3rfJ9mtYnmb3wspMjAdRkka?= =?us-ascii?Q?tA8M+KmuDxhCV6E0yNf6K3azrqAsmaWyvWH9vRi6ZKd3RibmN+ZAVR/7PhrP?= =?us-ascii?Q?qx1MXeIub0bIqj/UHWdsmWq9jvHcvXQM3YGVmnp7XiEoYp4Aqsye9gI6xSZ/?= =?us-ascii?Q?N7Gd9HrO+QefABqhASdCcfWn/gm0Gt658e2HmTqOZzUP1YcP1OpJBzON90wa?= =?us-ascii?Q?gYb+/gS9fPJSM1EY5+wmyMoKNFZFc+ez2ScjUhim+dFB/lr3o+Jm3w0ApcAd?= =?us-ascii?Q?46ZxLDwVBFM3eLxHsde4q53e0NjOnb0pMrupUb38N1y07Ku17JmLfdH/l5d0?= =?us-ascii?Q?71JLUlYmT044OL4sQuNXF9ofX0y6TLzvwe6Ej2UOQ7XpWglc5aFN0uLA7wSm?= =?us-ascii?Q?TdhIHqFoYegGvNDg4+ILKn1m7UYaqZn+mZYFvB+WALItU3CorH1CLCQvz26f?= =?us-ascii?Q?unqPoNcDOcenf+2mfZBWaTmEjIe4A9Krl4FyCydcnAorayesUQ=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:37:06.9592 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 58a92db8-a0bd-4030-d61a-08dd021b433a X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BL02EPF00021F69.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB7752 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=9477687ed2ef8e7c2588397a9542fc5ccfc1df40 Thanks. Xueming Li --- >From 9477687ed2ef8e7c2588397a9542fc5ccfc1df40 Mon Sep 17 00:00:00 2001 From: Shreesh Adiga <16567adigashreesh@gmail.com> Date: Fri, 20 Sep 2024 16:41:16 +0530 Subject: [PATCH] net/mana: support rdma-core via pkg-config Cc: Xueming Li [ upstream commit 8d7596cad7abb413c25f6782fe62fd0d388b8b94 ] Currently building with custom rdma-core installed in /opt/rdma-core after setting PKG_CONFIG_PATH=/opt/rdma-core/lib64/pkgconfig/ results in the below meson logs: Run-time dependency libmana found: YES 1.0.54.0 Header "infiniband/manadv.h" has symbol "manadv_set_context_attr" : NO Thus to fix this, the libs is updated in meson.build and is passed to the cc.has_header_symbol call using dependencies. After this change, the libmana header files are getting included and net/mana is successfully enabled. Fixes: 517ed6e2d590 ("net/mana: add basic driver with build environment") Signed-off-by: Shreesh Adiga <16567adigashreesh@gmail.com> Acked-by: Long Li --- drivers/net/mana/meson.build | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/mana/meson.build b/drivers/net/mana/meson.build index 2d72eca5a8..3ddc230ab4 100644 --- a/drivers/net/mana/meson.build +++ b/drivers/net/mana/meson.build @@ -19,12 +19,14 @@ sources += files( ) libnames = ['ibverbs', 'mana'] +libs = [] foreach libname:libnames lib = dependency('lib' + libname, required:false) if not lib.found() lib = cc.find_library(libname, required:false) endif if lib.found() + libs += lib ext_deps += lib else build = false @@ -43,7 +45,7 @@ required_symbols = [ ] foreach arg:required_symbols - if not cc.has_header_symbol(arg[0], arg[1]) + if not cc.has_header_symbol(arg[0], arg[1], dependencies: libs, args: cflags) build = false reason = 'missing symbol "' + arg[1] + '" in "' + arg[0] + '"' subdir_done() -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:08.786021665 +0800 +++ 0078-net-mana-support-rdma-core-via-pkg-config.patch 2024-11-11 14:23:05.202192838 +0800 @@ -1 +1 @@ -From 8d7596cad7abb413c25f6782fe62fd0d388b8b94 Mon Sep 17 00:00:00 2001 +From 9477687ed2ef8e7c2588397a9542fc5ccfc1df40 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 8d7596cad7abb413c25f6782fe62fd0d388b8b94 ] @@ -18 +20,0 @@ -Cc: stable@dpdk.org @@ -27 +29 @@ -index 330d30b2ff..4d163fc0f2 100644 +index 2d72eca5a8..3ddc230ab4 100644