From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B19E045CE3 for ; Mon, 11 Nov 2024 07:38:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A9D224067A; Mon, 11 Nov 2024 07:38:16 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2083.outbound.protection.outlook.com [40.107.94.83]) by mails.dpdk.org (Postfix) with ESMTP id 9D0FD40E1B for ; Mon, 11 Nov 2024 07:38:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=SY3yTXswGUicp/05dEhEl28dvlGWj9jzsUmhbiTkn5H4Zu8W18n3tSYRocD23nVf0myQJ+qob5Oc9ckaFXqwAzR7n1ILGAzsYOTJWFns1lvBVPpgqeyaBq74WI5j4dKzDkEUkgAtpG+pKVexJSmuzSitsnMBr30k1OhXlCVFaGkLnCuuA9r4gLP9dv+nrw7C5h7mo94gr2oZtx7+8/qhpD9RXfQmPKgUe1brJ/7SZChG1yLI05JBshb3Erc7f/fa25lVmkK4TPGplXkid0OwqHW3HMtn2b79u4MAc4GYwrGMaszujBCpj/MnuvGS71MgIJhRduhyQFt0I7IfGnuzvA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=1JsC6ajwoeghpq3isJ5+LptEPBw9fOpVGUol2sXM6X8=; b=H6zDjReW2GiJzejkx6UkLDIBv7rK86hVDGspSvA15c2AUcQpUAlFRc+DDUcBX4NVmK0us07QMQi8oowqk97zG+yentRJ8ipVNq2OEtxONbn8noHOhAHMBlXo1VcWeZA9Ziypp73e5L6thvhlqkeKktW41gATeo12rnzUq0bnNv/gJmgt+mQnA9mpaZwGyz5h2zEjUJBY5PPKkjGFIxDFk9uudMNUFp63VJlnHvvRYkzaiAAf+zK6iQbDTIVaPqa29oWGMn4gcPLgQe2epf3pnXg6IPcAbIYQLwJDteIS2giMEvoQmd2Ai/0zgkBqONeL5026rkdRB2EiTkdwUiX1Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=google.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=1JsC6ajwoeghpq3isJ5+LptEPBw9fOpVGUol2sXM6X8=; b=oAWMU1TgbPq9NF1BhT8QFGL7WabWbOHh1CvbPhyk9Gcr3igYo0arbpIBa3LtxL8CNRG9TbkAU8bncqXoqbJ+kNSm6oQ6YoPDcO+MCPyY76tRMUQIPzKmGU1t4aQBCIFr2uTWwipuekY0zGJuwcLaihEQiGWojkp+cuBLSQxm5LP84AlcDZFIcIzAahNmFrkdcyTIChIekquVx1lCG/wEIaZcyIx3x+u9/gd3MVOkdVQwjhahBA7VUnQVr8tGQRwIr8lyImRn6CWcrPHdbrlOsvBRX7IdUE50D06VJHNJa9ItEboW4mKETaxlwdLT3QDMIe5GttF7DZ9br3K8PSzHhg== Received: from BLAPR03CA0152.namprd03.prod.outlook.com (2603:10b6:208:32f::16) by CY5PR12MB6033.namprd12.prod.outlook.com (2603:10b6:930:2f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28; Mon, 11 Nov 2024 06:38:11 +0000 Received: from BN2PEPF000044A7.namprd04.prod.outlook.com (2603:10b6:208:32f:cafe::4e) by BLAPR03CA0152.outlook.office365.com (2603:10b6:208:32f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.28 via Frontend Transport; Mon, 11 Nov 2024 06:38:11 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN2PEPF000044A7.mail.protection.outlook.com (10.167.243.101) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8158.14 via Frontend Transport; Mon, 11 Nov 2024 06:38:11 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:38:00 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.4; Sun, 10 Nov 2024 22:37:58 -0800 From: Xueming Li To: Joshua Washington CC: , Praveen Kaligineedi , Rushil Gupta , dpdk stable Subject: patch 'net/gve: always attempt Rx refill on DQ' has been queued to stable release 23.11.3 Date: Mon, 11 Nov 2024 14:28:15 +0800 Message-ID: <20241111062847.216344-90-xuemingl@nvidia.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20241111062847.216344-1-xuemingl@nvidia.com> References: <20241111062847.216344-1-xuemingl@nvidia.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN2PEPF000044A7:EE_|CY5PR12MB6033:EE_ X-MS-Office365-Filtering-Correlation-Id: 63a756d7-3a24-4299-53da-08dd021b696e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|36860700013|376014|82310400026|1800799024; X-Microsoft-Antispam-Message-Info: =?us-ascii?Q?iBat8BQd4bgfob/H4xqf37H4OMrBnV6fGR7uLavrVYyRGXSFdjQhWpcktGh3?= =?us-ascii?Q?ueMyGLYcwNs9pyZr2bA+L+PomK+22SURT2eoSVBiE9ouHWYltwlAF1TGdU7m?= =?us-ascii?Q?vKUaOYPq3M7PgD6ObwQ5l32hrzPCrdIhZM9zX8cYN40tc5F2Pukh8OFlXq6G?= =?us-ascii?Q?xebDJmZaqhUOz6VkepTtyuk0I4XUDSw2QfoRhiwGa1h4vXhFaXXv6MXgZ/DV?= =?us-ascii?Q?VCL79c8IBBIA+YUDmsdOEWZsnFTW5TmFuy+R+3UznHfmB6SBwNq9g0oTlUZb?= =?us-ascii?Q?nVy63d0rJLA9UpZonmxpDnwoBFhcBvDXMJK4QKWPVhcVTcOKoCPeBl7on3Ed?= =?us-ascii?Q?vC3/lTVY1mdep+Ge7IcMdp7WdRLUCtEI1c+SJl/yLT7vbZaGrFhdbcZSLfp3?= =?us-ascii?Q?FhXwvYTnt21/eZpmAUoZkDUa4qcKblvba5IkTF1d0PlBOOvVgD+i2DjzEkEA?= =?us-ascii?Q?Zf/vLW2v6nJ1goBeVAT30ktqVzRMQxVwy5KjRZd86tD2Gtx/BlkfWNDtag/0?= =?us-ascii?Q?8dpLXuTcZhv5JXl5AzO+5iLZJpC7oL7ZVLHLmzqD7TuSUlybD2uBbOhFrp8v?= =?us-ascii?Q?dfVdN8md+VFZvxIhq9J2PDzURrsSNubo6H/2MA74+Z9te5oICItmMbcA4Sjo?= =?us-ascii?Q?enZFK5gkItDcmdNPe2Iz2JPf8drOP73wodA+zyoDzQPbEQ+AtYu3uIXC+Rwn?= =?us-ascii?Q?38EJLsDkaqvviDcd/Bw5Idr2hmvD9bamUWB39086E3lz2f4fXrJQ6VMXwSha?= =?us-ascii?Q?ujywfkWqOdKFo5cU5jSufhQ3UGrNtXP+eFJ/JKC6u9yK5s9nyGgZlBeGSVer?= =?us-ascii?Q?Gstw3JcWuh0qBLtZGdBUkOTgdZ9XkeoRAtGtUqjsbDZNqH/5NA18OgvfUFQe?= =?us-ascii?Q?Sw1UUIGTPPST005/jotjODTJmekim3MPplCESVxS4ba2jx5A6ga2qMEHbOfJ?= =?us-ascii?Q?teGC1KocbH/lEG7WrKGw+5nTF3/uGtLTmkMAMflDrJmf9PRtRmyrwZCr5eTm?= =?us-ascii?Q?U6sFkm+FCHs0U0RnDNXZE0phHLheMWx4qoPD8NhxFJhtGJB9Jy1A3lYfGeAp?= =?us-ascii?Q?eq+MInisJ+MspmMMCRwfvfOoAvL+g1hPxiuvJ7tDmXAWpTlNgA23RwyDt89Y?= =?us-ascii?Q?0ykIGBvHPEJ/TOeaHPEd67GPBbT7wVIMFPhOc41kQG+EA7FJ0RpLGZW2izdn?= =?us-ascii?Q?hxXJTtezbrhV7gQCR9ONJUGXzybML9jyhh83V5wekbDWTtUnRy/h+qlBlQOi?= =?us-ascii?Q?JXdHCkqZQB1EzwTgekSj9wkyIUWoMCrHjiiQNB7Z3smzb//OsZCVcCdM3oj5?= =?us-ascii?Q?wY4iLk5ouNg9LWata29UyPWXgn4lqUvw0ZRr9AfS7rnaqU6lZkcZqnkpmIYF?= =?us-ascii?Q?dDITkmxgToTCPEfUx0B09UbzPMjdWdaRvgWesp5nTuHm8v1Dgw=3D=3D?= X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230040)(36860700013)(376014)(82310400026)(1800799024); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Nov 2024 06:38:11.0657 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 63a756d7-3a24-4299-53da-08dd021b696e X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN2PEPF000044A7.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6033 X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 23.11.3 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/30/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://git.dpdk.org/dpdk-stable/log/?h=23.11-staging This queued commit can be viewed at: https://git.dpdk.org/dpdk-stable/commit/?h=23.11-staging&id=efbc64f353914ae5763f5b201e1d597d6c7b5044 Thanks. Xueming Li --- >From efbc64f353914ae5763f5b201e1d597d6c7b5044 Mon Sep 17 00:00:00 2001 From: Joshua Washington Date: Tue, 1 Oct 2024 16:45:33 -0700 Subject: [PATCH] net/gve: always attempt Rx refill on DQ Cc: Xueming Li [ upstream commit 31d2149719b716dfc8a30f2fc4fe4bd2e02f7a50 ] Before this patch, gve_rx_refill_dqo() is only called if the number of packets received in a cycle is non-zero. However, in a memory-constrained scenario, this doesn't behave well, as this could be a potential source of lockup, if there is no memory and all buffers have been received before memory is freed up for the driver to use. This patch moves the gve_rx_refill_dqo() call to occur regardless of whether packets have been received so that in the case that enough memory is freed, the driver can recover. Fixes: 45da16b5b181 ("net/gve: support basic Rx data path for DQO") Signed-off-by: Joshua Washington Reviewed-by: Praveen Kaligineedi Reviewed-by: Rushil Gupta --- drivers/net/gve/gve_rx_dqo.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c index 855c06dc11..0203d23b9a 100644 --- a/drivers/net/gve/gve_rx_dqo.c +++ b/drivers/net/gve/gve_rx_dqo.c @@ -135,14 +135,12 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) if (nb_rx > 0) { rxq->rx_tail = rx_id; - if (rx_id_bufq != rxq->next_avail) - rxq->next_avail = rx_id_bufq; - - gve_rx_refill_dqo(rxq); + rxq->next_avail = rx_id_bufq; rxq->stats.packets += nb_rx; rxq->stats.bytes += bytes; } + gve_rx_refill_dqo(rxq); return nb_rx; } -- 2.34.1 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-11 14:23:09.176827557 +0800 +++ 0089-net-gve-always-attempt-Rx-refill-on-DQ.patch 2024-11-11 14:23:05.232192837 +0800 @@ -1 +1 @@ -From 31d2149719b716dfc8a30f2fc4fe4bd2e02f7a50 Mon Sep 17 00:00:00 2001 +From efbc64f353914ae5763f5b201e1d597d6c7b5044 Mon Sep 17 00:00:00 2001 @@ -4,0 +5,3 @@ +Cc: Xueming Li + +[ upstream commit 31d2149719b716dfc8a30f2fc4fe4bd2e02f7a50 ] @@ -17 +19,0 @@ -Cc: stable@dpdk.org @@ -27 +29 @@ -index 81a68f0c7e..e4084bc0dd 100644 +index 855c06dc11..0203d23b9a 100644 @@ -30 +32 @@ -@@ -195,14 +195,12 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts) +@@ -135,14 +135,12 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)