please help backporting some patches to stable release 22.11.7

please help backporting some patches to stable release 22.11.7

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 22.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 22.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 11/19/24.

You can find the a temporary work-in-progress branch of the coming 22.11.7
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 22.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 22.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 22.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
d46f3b525a  Gregory Etelson  net/mlx5: fix error notifications in counter initialization
ee76b173b2  Gregory Etelson  net/mlx5: fix non-template flow action validation
0bc4795d59  Huisong Li       examples/l3fwd-power: fix options parsing overflow
2a682d65f8  Stephen Hemminger app/dumpcap: use bitops API instead of compiler builtins
27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR

Re: please help backporting some patches to stable release 22.11.7

[Stephen Hemminger]

On Tue, 12 Nov 2024 22:23:53 +0000
luca.boccassi@gmail.com wrote:

This patch 

2a682d65f8  Stephen Hemminger app/dumpcap: use bitops API instead of compiler builtins

depends on rte_clz64 that was introduced by.

916c50dd3a16  Tyler Retzlaff  bitops: add more bit count functions

So skip it.  The code ends up the same just doesn't use wrapper.

Re: please help backporting some patches to stable release 22.11.7

[lihuisong (C)]

Hi Luca,

The following patch can backport to 22.11 branch without any conflicts. 
Can you try it again?

0bc4795d59  Huisong Li       examples/l3fwd-power: fix options parsing overflow

/Huisong


在 2024/11/13 6:23, luca.boccassi@gmail.com 写道:
> Hi commit authors (and maintainers),
>
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> I didn't apply following commits from DPDK main to 22.11
> stable branch, as conflicts or build errors occur.
>
> Can authors check your patches in the following list and either:
>      - Backport your patches to the 22.11 branch, or
>      - Indicate that the patch should not be backported
>
> Please do either of the above by 11/19/24.
>
> You can find the a temporary work-in-progress branch of the coming 22.11.7
> release at:
>      https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
>
> Some notes on stable backports:
>
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>      [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
>
> For example:
>      https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
>
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>      [PATCH 22.11] foo/bar: fix baz
>
> With git format-patch, this can be achieved by appending the parameter:
>      --subject-prefix='PATCH 22.11'
>
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
>
> FYI, branch 22.11 is located at tree:
>     https://git.dpdk.org/dpdk-stable
>
> Thanks.
>
> Luca Boccassi
>
> ---
> d46f3b525a  Gregory Etelson  net/mlx5: fix error notifications in counter initialization
> ee76b173b2  Gregory Etelson  net/mlx5: fix non-template flow action validation
> 0bc4795d59  Huisong Li       examples/l3fwd-power: fix options parsing overflow
> 2a682d65f8  Stephen Hemminger app/dumpcap: use bitops API instead of compiler builtins
> 27918f0d53  Tim Martin       net/mlx5: fix real time counter reading from PCI BAR
> .

please help backporting some patches to stable release 22.11.7

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 22.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 22.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 12/04/24.

You can find the a temporary work-in-progress branch of the coming 22.11.7
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 22.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 22.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 22.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
f8f294c66b  Bing Zhao        net/mlx5: fix shared Rx queue control release
916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts

RE: please help backporting some patches to stable release 22.11.7

[Jiawen Wu]

Hi Luca Boccassi,

> 916aa13f4a  Jiawen Wu        net/txgbe: fix a mass of interrupts
>

It does not need backport to 22.11.7.
Thanks.

please help backporting some patches to stable release 22.11.7

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 22.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 22.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 11/27/24.

You can find the a temporary work-in-progress branch of the coming 22.11.7
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 22.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 22.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 22.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
a7ae9ba1f8  Alexander Kozyrev net/mlx5: fix miniCQEs number calculation
ffe827f38e  Andre Muezerie   rcu: fix implicit conversion in bit shift
3c9a82fa6e  Bing Zhao        net/mlx5: fix Rx queue control management
78dcdb821c  Shahaji Bhosle   net/bnxt/tf_core: fix WC TCAM multi-slice delete

please help backporting some patches to stable release 22.11.7

[luca.boccassi]

Hi commit authors (and maintainers),

Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
I didn't apply following commits from DPDK main to 22.11
stable branch, as conflicts or build errors occur.

Can authors check your patches in the following list and either:
    - Backport your patches to the 22.11 branch, or
    - Indicate that the patch should not be backported

Please do either of the above by 2024/10/30.

You can find the a temporary work-in-progress branch of the coming 22.11.7
release at:
    https://github.com/bluca/dpdk-stable
It is recommended to backport on top of that to minimize further conflicts or
misunderstandings.

Some notes on stable backports:

A backport should contain a reference to the DPDK main branch commit
in it's commit message in the following fashion:
    [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]

For example:
    https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb

When sending the backported patch, please indicate the target branch in the
subject line, as we have multiple branches, for example:
    [PATCH 22.11] foo/bar: fix baz

With git format-patch, this can be achieved by appending the parameter:
    --subject-prefix='PATCH 22.11'

Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".

FYI, branch 22.11 is located at tree:
   https://git.dpdk.org/dpdk-stable

Thanks.

Luca Boccassi

---
d16364e3bd  Bruce Richardson common/idpf: fix AVX-512 pointer copy on 32-bit
b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
f665790a5d  David Marchand   drivers: remove redundant newline from logs
e4a4087992  Gavin Li         net/mlx5: set errno for ipool allocation failures
6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
4baf54ed9d  Stephen Hemminger common/idpf: fix use after free in mailbox init
2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active VF
b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
97e19f0762  Viacheslav Ovsiienko net/mlx5: fix non full word sample fields in flex item
2254813795  Zerun Fu         net/nfp: notify flower firmware about PF speed

RE: please help backporting some patches to stable release 22.11.7

[Richardson, Bruce]

Hi,

For my two patches: 
* d16364e3bd common/idpf: fix AVX-512 pointer copy on 32-bit 
     - this I have now backported and submitted to stable@dpdk.org
* b34fe66ea8  net/iavf: delay VF reset command
     - this doesn't seem to be needed to be backported.

/Bruce

> -----Original Message-----
> From: luca.boccassi@gmail.com <luca.boccassi@gmail.com>
> Sent: Wednesday, October 23, 2024 10:32 PM
> To: dpdk stable <stable@dpdk.org>
> Cc: Gavin Li <gavinl@nvidia.com>; Richardson, Bruce
> <bruce.richardson@intel.com>; Marchand, David
> <david.marchand@redhat.com>; Nithin Dabilpuram
> <ndabilpuram@marvell.com>; Oleksandr Nahnybida
> <oleksandrn@interfacemasters.com>; Robin Jarry <rjarry@redhat.com>;
> Stephen Hemminger <stephen@networkplumber.org>; Sunil Kumar Kori
> <skori@marvell.com>; Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Zerun
> Fu <zerun.fu@corigine.com>
> Subject: please help backporting some patches to stable release 22.11.7
> 
> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-
> fixes.sh
> I didn't apply following commits from DPDK main to 22.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 22.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 2024/10/30.
> 
> You can find the a temporary work-in-progress branch of the coming 22.11.7
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-
> stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 22.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 22.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 22.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> d16364e3bd  Bruce Richardson common/idpf: fix AVX-512 pointer copy on
> 32-bit
> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
> f665790a5d  David Marchand   drivers: remove redundant newline from logs
> e4a4087992  Gavin Li         net/mlx5: set errno for ipool allocation failures
> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> 4baf54ed9d  Stephen Hemminger common/idpf: fix use after free in mailbox
> init
> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with
> active VF
> b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field
> translation
> 97e19f0762  Viacheslav Ovsiienko net/mlx5: fix non full word sample fields in
> flex item
> 2254813795  Zerun Fu         net/nfp: notify flower firmware about PF speed

Re: please help backporting some patches to stable release 22.11.7

[Stephen Hemminger]

On Wed, 23 Oct 2024 22:31:52 +0100
luca.boccassi@gmail.com wrote:

> Hi commit authors (and maintainers),
> 
> Despite being selected by the DPDK maintenance tool ./devtools/git-log-fixes.sh
> I didn't apply following commits from DPDK main to 22.11
> stable branch, as conflicts or build errors occur.
> 
> Can authors check your patches in the following list and either:
>     - Backport your patches to the 22.11 branch, or
>     - Indicate that the patch should not be backported
> 
> Please do either of the above by 2024/10/30.
> 
> You can find the a temporary work-in-progress branch of the coming 22.11.7
> release at:
>     https://github.com/bluca/dpdk-stable
> It is recommended to backport on top of that to minimize further conflicts or
> misunderstandings.
> 
> Some notes on stable backports:
> 
> A backport should contain a reference to the DPDK main branch commit
> in it's commit message in the following fashion:
>     [ upstream commit <commit's dpdk main branch SHA-1 checksum> ]
> 
> For example:
>     https://git.dpdk.org/dpdk-stable/commit/?h=18.11&id=d90e6ae6f936ecdc2fd3811ff9f26aec7f3c06eb
> 
> When sending the backported patch, please indicate the target branch in the
> subject line, as we have multiple branches, for example:
>     [PATCH 22.11] foo/bar: fix baz
> 
> With git format-patch, this can be achieved by appending the parameter:
>     --subject-prefix='PATCH 22.11'
> 
> Send the backported patch to "stable@dpdk.org" but not "dev@dpdk.org".
> 
> FYI, branch 22.11 is located at tree:
>    https://git.dpdk.org/dpdk-stable
> 
> Thanks.
> 
> Luca Boccassi
> 
> ---
> d16364e3bd  Bruce Richardson common/idpf: fix AVX-512 pointer copy on 32-bit
> b34fe66ea8  Bruce Richardson net/iavf: delay VF reset command
> f665790a5d  David Marchand   drivers: remove redundant newline from logs
> e4a4087992  Gavin Li         net/mlx5: set errno for ipool allocation failures
> 6c3de40af8  Nithin Dabilpuram common/cnxk: fix inline CTX write
> 6db358536f  Oleksandr Nahnybida pcapng: fix handling of chained mbufs
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints
> 4baf54ed9d  Stephen Hemminger common/idpf: fix use after free in mailbox init
> 2d4505dc6d  Sunil Kumar Kori common/cnxk: fix MAC address change with active VF
> b04b06f4cb  Viacheslav Ovsiienko net/mlx5: fix flex item header length field translation
> 97e19f0762  Viacheslav Ovsiienko net/mlx5: fix non full word sample fields in flex item
> 2254813795  Zerun Fu         net/nfp: notify flower firmware about PF speed

Although you may not want to backport the malloc annotations to the release.
It is a useful way to see if you found all the rte_free bugs that were marked for stable.
commit 80da7efbb4c4216de93b1039b891a6f31fa06f2d

I

Re: please help backporting some patches to stable release 22.11.7

[Robin Jarry]

Hi Luca,

, Oct 23, 2024 at 23:31:
> 6f96937dad  Robin Jarry      ethdev: fix race on ports in telemetry endpoints

I don't think this can easily be backported to 22.11. It depends on 
commit 5fa337858df6 ("ethdev: protect shared memory accesses under one 
lock") which has been added in 23.11.

I don't know if it is worth backporting that dependency or not.

Re: please help backporting some patches to stable release 22.11.7

[David Marchand]

Hello Luca,

On Wed, Oct 23, 2024 at 11:32 PM <luca.boccassi@gmail.com> wrote:
> f665790a5d  David Marchand   drivers: remove redundant newline from logs

Not critical to backport this, and there may be more issues present in
the lts branch that this backport would not fix.
Let's simply skip it.


-- 
David Marchand