From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DEE045D16 for ; Fri, 15 Nov 2024 21:08:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 633D6432DE; Fri, 15 Nov 2024 21:08:14 +0100 (CET) Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by mails.dpdk.org (Postfix) with ESMTP id 23C6943295 for ; Fri, 15 Nov 2024 21:08:08 +0100 (CET) Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-720aa3dbda5so1663820b3a.1 for ; Fri, 15 Nov 2024 12:08:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1731701287; x=1732306087; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=l21Pg390V4j6zy88yz6E5exOjrveQVhJKRd99FzrHxg=; b=miTMy/5E6CLRp2PVtb+daoVGzUAMctHZ18BinMT2c/x710TP6jjsr7bomucfnemZQZ UANVTXcpZL+snMzkzX0GLg6BDUahBILeQG+ztUKG6sA2LHgUuIPie1mOT+m0w1PIbNVk cTBKSWkZaKVciAcaVrJSOSMAl/gWUDNU8R2ygUpxVz+Aw9Htcm7capA4Q2Cv95iHnfad nmUezC4nR0nQo/3RvHJg7Lg0bRQeMQmTpPufJ+WnjcUsyrtvWsA/T1iH1ndlUh0Z8Lo3 ObSNcGawGanexboej3aig4l+OFgWFjmGVfVrxpOM4+vn6cMyIVMr1y5EQhyPQ0cWrdet 9VoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731701287; x=1732306087; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l21Pg390V4j6zy88yz6E5exOjrveQVhJKRd99FzrHxg=; b=gB2x+EJUNVMCUxwaC3Wzetwu4O/q8iKnD6FEx12C0zB7Yh8HaqSJz/FVJqkoVS7aUi ob5Gu0S5oLIbVBp7VH9lg5weaHduhhP6INJGDrxkmzX9jjajOqY7+NV4H91go/duQe8p 7muuoui3PSSEW1pZydTfsqEEq2liEb5Or3ixLK4eWaT4C2G/WATfuzmbc8lAcqLFBT19 NsBwQeT29Qa6c6295ae65wQ7nbOiHXcuB6g1JUu4K31K4Fy0EAZEktZaEt3HWsrzWhO/ PagP3j+9ORAc5HHEWyw1GdWuzIBqqe6p2IX9OC9SL/3L/HBgD1P0rnSM0YYHWz8O0k2q N0Mw== X-Forwarded-Encrypted: i=1; AJvYcCXw9JpdMzknMjPLQxYYUPmt+BDSvuZ0Yo0mkxTwkUYkixXCekkVk1GUrCXEaJLKD6Ode3UxevM=@dpdk.org X-Gm-Message-State: AOJu0Yz3RJztpmRydONRsOteHf8Of2kDu73QuWQnNfRZryldFdUFyWIy 9kXnd3dwVNrFjymMj9Ndjzs3QtNiSZkGVK5J8oGnk1hoyWErh3+s+6pgs5lQRcY= X-Google-Smtp-Source: AGHT+IFAcTAqCvdf1LmapbemMxm4MreFgXZCckxx9k4vqagb/HlOEMIMAp5v0PlZEuLV9QU2Vkq0Ig== X-Received: by 2002:a05:6a00:4fc9:b0:71e:6489:d06 with SMTP id d2e1a72fcca58-72476a0075fmr4385108b3a.0.1731701287366; Fri, 15 Nov 2024 12:08:07 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724771e11f0sm1759686b3a.131.2024.11.15.12.08.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Nov 2024 12:08:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , msantana@redhat.com, stable@dpdk.org, Bruce Richardson , Tyler Retzlaff , David Marchand , Michael Santana , Aaron Conole Subject: [PATCH v3 07/10] test/eal: fix core check in c flag test Date: Fri, 15 Nov 2024 12:06:51 -0800 Message-ID: <20241115200751.17141-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241115200751.17141-1-stephen@networkplumber.org> References: <20241114001403.147609-1-stephen@networkplumber.org> <20241115200751.17141-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The expression for checking which lcore is enabled for 0-7 was wrong (missing case for 6). Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests") Cc: msantana@redhat.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson --- app/test/test_eal_flags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index d37d6b8627..e32f83d3c8 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -677,8 +677,8 @@ test_missing_c_flag(void) if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) && rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) && - rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) && - rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) && + rte_lcore_is_enabled(4) && rte_lcore_is_enabled(5) && + rte_lcore_is_enabled(6) && rte_lcore_is_enabled(7) && launch_proc(argv29) != 0) { printf("Error - " "process did not run ok with valid corelist value\n"); -- 2.45.2