From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B07A45D5D for ; Thu, 21 Nov 2024 00:43:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8386440296; Thu, 21 Nov 2024 00:43:07 +0100 (CET) Received: from mail-wr1-f52.google.com (mail-wr1-f52.google.com [209.85.221.52]) by mails.dpdk.org (Postfix) with ESMTP id EE1AE40296 for ; Thu, 21 Nov 2024 00:43:06 +0100 (CET) Received: by mail-wr1-f52.google.com with SMTP id ffacd0b85a97d-3823eaad37aso922014f8f.0 for ; Wed, 20 Nov 2024 15:43:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732146186; x=1732750986; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=V/6/X8XaKR6ZydiGf8nw5E+oszrMaupk/sepSItE208=; b=D72HN6iXVQumB+S3AWNxWRWtz4fE8DQZjeBPEoDTFEHQ6C9zk018CD/3w0bmnBdxwI QCjyH4Eacb5ODuoFnxYVKUszcw+A9KKgzC+O+OuWwaMenGEJjPWUcqMS/vNtE52uQIWb 9EkjzX0uCtDbAYYyTcmYSIhvWq1F3/mBXYjgK+x5Lr0buW5TBfHK9o+xNyeDPBTiCshY FdIHh6ozu7QXEn5+qhexYoO6dkjEiBgBSQNU9YcdtY06vdaHtBvGY8E5XQkKgqvgHu62 2xc5WzYQFeYn6Tj5ArrD52iWFB5lQKBxHZQZkBuBEBqx8R7i3u5BdLUh84W+N062EXgB kYAA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732146186; x=1732750986; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=V/6/X8XaKR6ZydiGf8nw5E+oszrMaupk/sepSItE208=; b=Iiptfx6ZEuvj/LNUfkWqCENLtp7wcoSCvzU0NjLEvPXeY5nsh9HDiKtYz8Pnf41IKY SFOd3Zv4slN++QeQGNmj/qbyltEYsLrMY0Jj2xV7ZmlB22PK+yjsmReEqWhDacPTHg7m eXGWhoPfmoeR2JSqZ2rLexSEDwa7bhPhu/Nw8QQ95p+s9u2wmMK1BuKP3bju/Oh2JKtY tJ9pzZf/SgTHXyV2ghwHoGDFi4WPu/3uxibzVbNmy11zm2q1UO/e1f5ro/pwYPdRkzEH mOBXx8scEh8RNb430/bzcjZrNXjg5nTUbXXj1AYhMxOCRMf0ZH4EHXkMcgI5DB/4TwYk Ee3w== X-Gm-Message-State: AOJu0Yytqx+bvONSWgw0cOPBUxTMA7yyyMSXCtXqiaOqN9RUhKfw9joO 3Y2Tj7ir+ZEAHAMOFLEyHLD4XPeHV8mEkxY5lz2Ch9SMO5YPnHm2Te6BUxK0 X-Google-Smtp-Source: AGHT+IEYGtGdf8tc5hIr79FGArRMI2jEp6+dqMH8GfrNaZy++RgbhkTduVEbePGg5vQb63Zk0jaaHg== X-Received: by 2002:a05:6000:2a9:b0:382:31a1:b4db with SMTP id ffacd0b85a97d-38259d2b826mr1004419f8f.21.1732146186272; Wed, 20 Nov 2024 15:43:06 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b46430f1sm34670395e9.43.2024.11.20.15.43.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 15:43:05 -0800 (PST) From: luca.boccassi@gmail.com To: Hemant Agrawal Cc: dpdk stable Subject: patch 'examples/l2fwd-event: fix spinlock handling' has been queued to stable release 22.11.7 Date: Wed, 20 Nov 2024 23:41:37 +0000 Message-ID: <20241120234215.233355-12-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241120234215.233355-1-luca.boccassi@gmail.com> References: <20241112220754.666489-40-luca.boccassi@gmail.com> <20241120234215.233355-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/22/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/a137ec434299bf3a9eeb8e10f490db6de7cea12d Thanks. Luca Boccassi --- >From a137ec434299bf3a9eeb8e10f490db6de7cea12d Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Thu, 14 Nov 2024 13:14:36 +0530 Subject: [PATCH] examples/l2fwd-event: fix spinlock handling [ upstream commit 1f41deac447d7938198a2acdd1b7862161feef91 ] Detected by pvs-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might remain blocked. Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Signed-off-by: Hemant Agrawal --- examples/l2fwd-event/l2fwd_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c index 4b5a032e35..78f10f31ad 100644 --- a/examples/l2fwd-event/l2fwd_event.c +++ b/examples/l2fwd-event/l2fwd_event.c @@ -141,6 +141,7 @@ l2fwd_get_free_event_port(struct l2fwd_event_resources *evt_rsrc) rte_spinlock_lock(&evt_rsrc->evp.lock); if (index >= evt_rsrc->evp.nb_ports) { printf("No free event port is available\n"); + rte_spinlock_unlock(&evt_rsrc->evp.lock); return -1; } -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-20 23:41:23.139168779 +0000 +++ 0012-examples-l2fwd-event-fix-spinlock-handling.patch 2024-11-20 23:41:22.708195467 +0000 @@ -1 +1 @@ -From 1f41deac447d7938198a2acdd1b7862161feef91 Mon Sep 17 00:00:00 2001 +From a137ec434299bf3a9eeb8e10f490db6de7cea12d Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f41deac447d7938198a2acdd1b7862161feef91 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 22472027b9..416957384b 100644 +index 4b5a032e35..78f10f31ad 100644