From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 640DF45D5D for ; Thu, 21 Nov 2024 00:44:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D94D40296; Thu, 21 Nov 2024 00:44:09 +0100 (CET) Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) by mails.dpdk.org (Postfix) with ESMTP id DB1DD40296 for ; Thu, 21 Nov 2024 00:44:08 +0100 (CET) Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-4319399a411so2277675e9.2 for ; Wed, 20 Nov 2024 15:44:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732146248; x=1732751048; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KOBLW3KdLfYW+b7M1QZhVPh7Lm6wv0rHLyhzlFTa1EM=; b=WOGcV89DjGUQRISXXFgmyW3YtBPXxmMjBhZ0yaQfq1hJliSrB+s1igQZHVD/iHP/qH e+zp/LGYWGmuYSoJuOPTGbfDl3praUWc537fc4lBq9dQmZbKcfqiFRuet5OSb0d5/ABs rJnXEohV6H8RmVRKuUIap20J5dEmfcd0uGTQitP5zmrl/aBzkHuSs4giHtPxys3W89ST Oc1qRehOcnbDqtVak1crwnJFwNVlhHti4ou/0i3VqJ5atcvwUcY12LiGeaRdPkFzdxgN Pm0ePV7UgwtKlGcw/ijC8xlqKTfCOlaZ4oGsXpGvPVfBA1mPoPLJ8/AP0UOqAkZN4jVg Wmrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732146248; x=1732751048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KOBLW3KdLfYW+b7M1QZhVPh7Lm6wv0rHLyhzlFTa1EM=; b=DzUbx6LTJ8iegY53jhg2H11Eu6YZk9CzKd1weZ2pV+1Y5p5bvegfiJDwUG8QL+jaUR FPWKOXz2ii+5dAl5Nz7n55IE/G0fTfZQLmzTrEHFpOEnLck0IQr4cgLeru1xsL6aRyvU 4l2/aFgFWYnZOEhCA0we7+JwRRAFB7vdj22kbWQL6cMMKgSzlLVqF8P82CtasTdcOihs 1qnEUfczWeMouAZiJzLq8aFLXg5Z1iMUt6PJdiFxZtskrIAT30YqgUaXbqdtt+ytrcy/ 89kSQLtZXZtkVsKSgyhU7kOql2AjQz2/7iRjTv7krJ9eFU/8lsTLEN4uxLJMwojMTxAH uReA== X-Forwarded-Encrypted: i=1; AJvYcCWeeWSjF/PVWu4GLwemfHF1ILl5G9W80cIHItGk5GB5lvBajnlIwTmaB0LaORd9QNRSSASwtjE=@dpdk.org X-Gm-Message-State: AOJu0YwuVlkfeM/iNyvqJ4LTVULks8/zJDPIHlM8TWdnjRc2pv8AFcwl UK3rS7D047V3xsjhwMFvvdXhteGeQTFTzvyOkINGTrN9piLWn/J4tuR0uRPN X-Gm-Gg: ASbGncuzvDpdjk47V6navfYxiZijKnYaT6GSkZ669lGY0Hs7dUHnBlNF+zL3STpcTK6 lUCzciHFDqjzcmLzVHvVbS/8JaKDX+oSY7CDxxY6wtsK5s9rle1lyy9sUrBZRNxMOGv70ahPEVS x4W8mVpC+coPLKhg5jz5tqwwdZWenUL0Y2Ah+uNzxWWgoMPCnDiSXWjGobV0DLV8tP4H1I2JalS CvmKMzv88dV7tnlvZvYtndaXEoY/iYJt61pmE3AmcwjaBf2NcJVdk4j X-Google-Smtp-Source: AGHT+IEwJBFk2YWe1J7TM6MF9oxpfVGv3xH0ACplgpmyz9GBmd2n4KNKP0dMPbb37VHeZN48Hx3oDQ== X-Received: by 2002:a05:600c:350f:b0:42c:ba83:3f0e with SMTP id 5b1f17b1804b1-4334899569fmr38803545e9.7.1732146248428; Wed, 20 Nov 2024 15:44:08 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:21cd:def0:a01d:d2aa]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-433b463ab37sm34485815e9.28.2024.11.20.15.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Nov 2024 15:44:08 -0800 (PST) From: luca.boccassi@gmail.com To: Fidaullah Noonari Cc: Stephen Hemminger , Chengwen Feng , dpdk stable Subject: patch 'app/procinfo: fix leak on exit' has been queued to stable release 22.11.7 Date: Wed, 20 Nov 2024 23:41:51 +0000 Message-ID: <20241120234215.233355-26-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241120234215.233355-1-luca.boccassi@gmail.com> References: <20241112220754.666489-40-luca.boccassi@gmail.com> <20241120234215.233355-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/22/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/0b010067c389479edb923a972584396da819d8d5 Thanks. Luca Boccassi --- >From 0b010067c389479edb923a972584396da819d8d5 Mon Sep 17 00:00:00 2001 From: Fidaullah Noonari Date: Thu, 3 Oct 2024 19:48:29 -0700 Subject: [PATCH] app/procinfo: fix leak on exit [ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] When app is launched with -m proc-info exit without rte_eal_cleanup() causing memory leakage. This commit resolves the memory leakage issue and closes app properly. Bugzilla ID: 898 Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats") Signed-off-by: Fidaullah Noonari Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- app/proc-info/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index 9104f9e6b9..8fd7ac945c 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1793,7 +1793,7 @@ main(int argc, char **argv) if (mem_info) { meminfo_display(); - return 0; + goto cleanup; } nb_ports = rte_eth_dev_count_avail(); @@ -1875,6 +1875,7 @@ main(int argc, char **argv) RTE_ETH_FOREACH_DEV(i) rte_eth_dev_close(i); +cleanup: ret = rte_eal_cleanup(); if (ret) printf("Error from rte_eal_cleanup(), %d\n", ret); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-20 23:41:23.612441016 +0000 +++ 0026-app-procinfo-fix-leak-on-exit.patch 2024-11-20 23:41:22.756195468 +0000 @@ -1 +1 @@ -From 8a171e52ed8b26f768ced79a22286914ebd30180 Mon Sep 17 00:00:00 2001 +From 0b010067c389479edb923a972584396da819d8d5 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -19,2 +20,2 @@ - app/proc-info/main.c | 5 +++-- - 1 file changed, 3 insertions(+), 2 deletions(-) + app/proc-info/main.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) @@ -23 +24 @@ -index 6886eb373a..e1272164b1 100644 +index 9104f9e6b9..8fd7ac945c 100644 @@ -26 +27 @@ -@@ -2171,11 +2171,11 @@ main(int argc, char **argv) +@@ -1793,7 +1793,7 @@ main(int argc, char **argv) @@ -34,4 +34,0 @@ - if (eventdev_xstats() > 0) -- return 0; -+ goto cleanup; - @@ -39,2 +36 @@ - if (nb_ports == 0) -@@ -2256,6 +2256,7 @@ main(int argc, char **argv) +@@ -1875,6 +1875,7 @@ main(int argc, char **argv)