From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0894045D6B for ; Thu, 21 Nov 2024 19:25:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2114143252; Thu, 21 Nov 2024 19:25:05 +0100 (CET) Received: from mail-pg1-f182.google.com (mail-pg1-f182.google.com [209.85.215.182]) by mails.dpdk.org (Postfix) with ESMTP id 402F542FA1 for ; Thu, 21 Nov 2024 19:24:59 +0100 (CET) Received: by mail-pg1-f182.google.com with SMTP id 41be03b00d2f7-7fbc1ca1046so710639a12.0 for ; Thu, 21 Nov 2024 10:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1732213498; x=1732818298; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=9LYeEaogBAc0vSyBtqoy7sP97FB+GnQO77RdZXSw6MM=; b=d+nZnl85cn00kvUg5irRhG+ZxIzZ7X2+vs466Uc26iEyTnDFt9VB02X+72Xw1UFVJf FMJ6oiEy2qUWSRf//5ANBXEPhV4U8H+P91kcsSUlnFaYquwj06FBceCggBLqI87DxBBe O+Lcm1vDGPS/guT27rGjH1LuayX95YJKbA15wOVB65wOCB3m55LKcQp9GfPsuoqEJmEG epMrqFRzHXn9Jby0HhT03lbyDPbG4cMN+yDGVuDtBLnzkxlycX1/IPM0bFERe+0artGG XYbYhzZ1DZQsdh4WSe1dnfFJgvILwznXXmEyE9BnJ0cz8N3mlDNZXa31qMG0o2MH6+O4 ZK1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732213498; x=1732818298; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9LYeEaogBAc0vSyBtqoy7sP97FB+GnQO77RdZXSw6MM=; b=j5s9srY5aD0HX0Dr0uY8eRFt+zxGL80VEDKCeCnKNPZgu5XNKoOy21yQYZkcMFbla4 +FabT3it9zDJ/A1WRs1PisT7i6wfsXF25sKu9TGABleC2cxaYlq24P69E6OUNjYEccST SMXIPpPm8793A2Q40DEdzdnSA+wJ1ZyMAUQVMMx/YAYHL4hNf/m8TB/Kjno/JDDjdBKp ligIJl98AaDMKAUzQRwPSfcnXiRnuB8Yu0ANe4nt3LDPOzCNASUECQDxfC7Q9SJ3LVCw 50IRKYoLKv58gqGbtf4UY+fwUVnELjX8ZH6jZhRgCzs+yrj3M2Y/nDDPxQ4KeGbOJzqt T7vg== X-Forwarded-Encrypted: i=1; AJvYcCVenvJxGaniNbH9gD/dzOJcuMrIcLNNrVOc9UOu+n0i5W/PnP4r0qprQcFGnbJFfUdh3oaYQ5I=@dpdk.org X-Gm-Message-State: AOJu0YxwtNCYWekRQuRRYW5AEaOku6WotPLzXqJ+DtuJmmkTvumUv9t3 BDNCAcTUlzFTKqAuKAlNNCRCY+C0S8i4aqpX5TIb7jdGCp3a/+UUio4JSnIeBl4= X-Gm-Gg: ASbGncs00qdShMbjjBhZqz47b4HRJhZb+uqgQxWMqa96FdBY3rRSa/HiqSX54sQVQFE EeUIp6E8N3BrklvaBfFZF3aKWu3ZknbmVlZNp/V5RniH7lEZ5KkfP0lrZ5InA8g0YFjjUbYD5ke 9sxanYsy5QqBg3TtzXSwP6OrQh0HvZRqwIeKZlkBrNLwM1A4M6fQas+DeIZJDgLrrAAkvLayWeX e7HsyLsV8B+B/GVkY+DIZvxLYv5DhgUp/8QWIlrFNumqbvRXy9CPcXFbOYTmPPzM1D00FNpod4E 2HfZLZnO0wy0iAZbq3XOcmszJcI= X-Google-Smtp-Source: AGHT+IH8ZyYKNPYwyLkraGAHJHYqhctHPYPlIwEzNzG7p+tzGzZzy2WgVEtPEnvGnG62d7OTnyK/WA== X-Received: by 2002:a05:6a20:9149:b0:1db:e1b0:b679 with SMTP id adf61e73a8af0-1ddaebce7c8mr11382371637.18.1732213498456; Thu, 21 Nov 2024 10:24:58 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-724de454aa1sm70201b3a.4.2024.11.21.10.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Nov 2024 10:24:58 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , vvelumuri@marvell.com, stable@dpdk.org, Akhil Goyal , Fan Zhang , Anoob Joseph Subject: [PATCH v4 5/9] app/test: fix TLS zero length record Date: Thu, 21 Nov 2024 10:23:26 -0800 Message-ID: <20241121182443.68025-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241121182443.68025-1-stephen@networkplumber.org> References: <20241114001403.147609-1-stephen@networkplumber.org> <20241121182443.68025-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org The code was duplicating the same condition three times? Reading the commit message, the intention was: Add unit tests to verify the zero len TLS records. Zero len packets are allowed when content type is app data while zero packet length with other content type (such as handshake) would result in an error. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 79a58624369a ("test/security: verify zero length TLS records") Cc: vvelumuri@marvell.com Cc: stable@dpdk.org Signed-off-by: Stephen Hemminger --- app/test/test_cryptodev.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index c647baeee1..a33ef574cc 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -12253,10 +12253,7 @@ test_tls_record_proto_all(const struct tls_record_test_flags *flags) if (flags->skip_sess_destroy && sec_session_outb == NULL) sec_session_outb = ut_params->sec_session; - if (flags->zero_len && - ((flags->content_type == TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE) || - (flags->content_type == TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE) || - (flags->content_type == TLS_RECORD_TEST_CONTENT_TYPE_HANDSHAKE))) { + if (flags->zero_len && flags->content_type != TLS_RECORD_TEST_CONTENT_TYPE_APP) { if (ret == TEST_SUCCESS) return TEST_FAILED; goto skip_decrypt; -- 2.45.2