From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3157345D31 for ; Wed, 27 Nov 2024 01:54:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E92EA402E0; Wed, 27 Nov 2024 01:54:41 +0100 (CET) Received: from mail-wm1-f51.google.com (mail-wm1-f51.google.com [209.85.128.51]) by mails.dpdk.org (Postfix) with ESMTP id AF3EC402E0 for ; Wed, 27 Nov 2024 01:54:40 +0100 (CET) Received: by mail-wm1-f51.google.com with SMTP id 5b1f17b1804b1-4349fd77b33so22761685e9.2 for ; Tue, 26 Nov 2024 16:54:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732668880; x=1733273680; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=o5J8T48H/8GgC2mRxyyA++aMqVHKoltWwfVRgHNS3bg=; b=XhKQlWTdU/3y/gCLq2pYgr0OWgw9c4Pyd0D/ALWy7tdAFiOTm+4J0ksX/tcufTXoxJ tscKHAUGtCezOEUlmqqt3pceqFJI5jeaCBwwEvMsDVBP960Cx2tYP5/kp0I2Tu+gr9z9 R2vHBPyPMrqApn56Tfd19PZUbxVAuEahn6uSI1f9RLpQRU1Pscpxm5U7NhjeadHlVeTf htidlJk/rNfraPJWnjy2mzFZeG7460C7RgdrtuYpfSQJLPTVbx9y3DUmI4HAekLvamLH +PiC4IDBgjArNgYMfn0AMucgnuL/WStB5x0/7HXMhOhvIs1t0Z0eiuC/9y273nBMQ+UM IK/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732668880; x=1733273680; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o5J8T48H/8GgC2mRxyyA++aMqVHKoltWwfVRgHNS3bg=; b=rqPu4lhvl6I+9xVmQ/m+H4QRFVApyqDeuFRkEq3QADGjOqCXn7fqdlO0p6JR2zWnWi yrEHmmDBsEW1BAR+rYtaODrMCN0DbZLZktP+VyWL/ynKfJix6RAXvRU2sOFFCKqD1wjm ZWffuMxlgokzr/FCbqn9br+mSNZal/csCH3qaAA3n/Wnz+p7zZ+/lfUpilix8SlmjmP4 rxGmqIacKsW/IYQI6njhZ5aqDIIRYiclCdHkYn/gvV9JXwE9lkEtrHUi6QInLEW0rYlX H0qkEZfA7rhtB4fhdA5rmsssOv9yoItqM60Nq1W5XPQycdQyAz5GBOLbXg9YD8pS++sf dORw== X-Forwarded-Encrypted: i=1; AJvYcCUY+mQAeWqtLmHeK+j5QVmzvw1Aq1Y3W1mvDXuwCBqSTZqF5vkRbuJh9uW9RIkUEKVtZTjIJPs=@dpdk.org X-Gm-Message-State: AOJu0YzXOipl0LJgkFiBiypMhYf9TCe49JoEE2O/unqyABMsi/ZB+jGc LGX3p9Atl9qC44oOG9Z+TzREE27aJ4uslF+CC2Whn+4aVhxWTJza X-Gm-Gg: ASbGnctPvgDGSQa5OadUPj9xUGt3QjNqZ/tdPe9K4/ENyNQ4ThyYxngU1zlFBUsDJrM qVRh0TQrDAeSr+/HPdiQYu7J+u3GSxfLnKA+k4GwK4IuykCdnHCcg2VHuZGiBzVGGz32pFMpx7S oZbE25L+f27+aejRck2TjVYeyo9yIo9nAkiVEuQ/yTUAkCT6l2PeRvwTy26Z1UU386RAL1YP4yI N3ZeOK+WYz3aHOBBTozu2Fib33nz5ALZ64lIrpBRNJ6vtDCSa7boJWn X-Google-Smtp-Source: AGHT+IH6Aj9IVQbVmFhkWooocNsuwij3e7TJKIkgnh0vb7ccjEMNgTA15CrULfsgP7k4fqxgIrCoIw== X-Received: by 2002:a05:600c:524d:b0:434:9be8:6cb5 with SMTP id 5b1f17b1804b1-434a9dd0052mr10988775e9.17.1732668880048; Tue, 26 Nov 2024 16:54:40 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:2203:ead5:e694:df3c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7d25c5sm3633145e9.28.2024.11.26.16.54.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 16:54:38 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , Chengwen Feng , dpdk stable Subject: patch 'test/bonding: fix loop on members' has been queued to stable release 22.11.7 Date: Wed, 27 Nov 2024 00:54:27 +0000 Message-ID: <20241127005435.188430-1-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241120234215.233355-28-luca.boccassi@gmail.com> References: <20241120234215.233355-28-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/634cf74378ab4fb451ea6f24aca1658cfce24743 Thanks. Luca Boccassi --- >From 634cf74378ab4fb451ea6f24aca1658cfce24743 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:22 -0800 Subject: [PATCH] test/bonding: fix loop on members [ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] Do not use same variable for outer and inner loop in bonding test. Since the loop is just freeing the resulting burst use bulk free. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_link_bonding.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 53f5c13a24..f342b04802 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -2265,12 +2265,7 @@ test_activebackup_rx_burst(void) } /* free mbufs */ - for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) { - rte_pktmbuf_free(rx_pkt_burst[i]); - rx_pkt_burst[i] = NULL; - } - } + rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size); /* reset bonded device stats */ rte_eth_stats_reset(test_params->bonded_port_id); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 00:29:59.548769355 +0000 +++ 0001-test-bonding-fix-loop-on-members.patch 2024-11-27 00:29:59.500711022 +0000 @@ -1 +1 @@ -From 112ce3917674b7e316776305d7e27778d17eb1b7 Mon Sep 17 00:00:00 2001 +From 634cf74378ab4fb451ea6f24aca1658cfce24743 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4d54706c21..805613d7dd 100644 +index 53f5c13a24..f342b04802 100644 @@ -24 +25 @@ -@@ -2288,12 +2288,7 @@ test_activebackup_rx_burst(void) +@@ -2265,12 +2265,7 @@ test_activebackup_rx_burst(void) @@ -36,2 +37,2 @@ - /* reset bonding device stats */ - rte_eth_stats_reset(test_params->bonding_port_id); + /* reset bonded device stats */ + rte_eth_stats_reset(test_params->bonded_port_id);