From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5435A45D31 for ; Wed, 27 Nov 2024 01:54:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4BF57427E3; Wed, 27 Nov 2024 01:54:44 +0100 (CET) Received: from mail-wm1-f44.google.com (mail-wm1-f44.google.com [209.85.128.44]) by mails.dpdk.org (Postfix) with ESMTP id 7072F427E1 for ; Wed, 27 Nov 2024 01:54:42 +0100 (CET) Received: by mail-wm1-f44.google.com with SMTP id 5b1f17b1804b1-434a95095efso1640865e9.0 for ; Tue, 26 Nov 2024 16:54:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732668882; x=1733273682; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FTZHulCcwookJFrgG1pBXDS86tKWgMWdMUBFb2odH7Q=; b=DPV7dvUIVTL4ArRirdXkbG60V1Mk0u8TTCnsudj2ZA+3KYcu1Tx1Fsf0HPzvikUm/q X4DqkubLbCvJUcHHoscDwrziIQ3qRFaseqaBuI1kg5ihMpUSCvrGUmGV6hsfP3N0U0ft Dv+vNy3JvU0ekcYQy+XrxRkD9e4Ny33lg8oWzdysSzKi5TWv8asOQKQY1jAjv1aH6Gkc Uo5oDs6iEY+sCv2KcCYRmHo3PnJkFB3wOLa5VMPyu8wQJ1icwLaJQdifnCe/cn0fvkMx +E76Qsgf3QLG6umk6WDMkBwnrokH4sLtKn0A1GPS1h04+v5DvEmOyi68oz1oBYa1lM0x P3bg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732668882; x=1733273682; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FTZHulCcwookJFrgG1pBXDS86tKWgMWdMUBFb2odH7Q=; b=ks6ZgS0XAx4H3vCwhnqyNqS8S7kSt0iK5muqyqtYKverLQ4Hsrt5Ln37qpSSD1muue sPNjmKZR3/aDDdIXBOkBiCBjFTps2Mwl4+g+NG7NnCE4ANp6ft7J01hkuNQp6EwVuNVj HE4YSLSaXbEsa1oMw/MZhhf2T20DW/urMt2SwjCo3SAaSp5kC8Kfsu4x4nO2nXL+5gHV ZIMLJCqU+Sfc3dRbBwmRSBYOirAyB3IUJano/rmQcD+usSLqgXYM0kftwBUI/3VjM9OO iSv0lK3qF3Oba0tbvqNS3yNwbjSiHLgViraFePC8XkznhCP9hr57xXhMv9Zq9Bmohpf6 JNkg== X-Forwarded-Encrypted: i=1; AJvYcCUM9RWJxym7aD+E5zZQoTWwKJsagxg/oQIZN1ukGTHlBcyM/nV3TbrB6A2znS994aM7EYpk+sI=@dpdk.org X-Gm-Message-State: AOJu0YxjWuZLQhYB4dEokfmSwAKlGpFM/GM5qAk7qL3rdKJ0IZPkg+/Y i2Hq5AWGRNnGh4yg532dmL3aIvdQI0eEIngDsdSiumu08hYW2tym X-Gm-Gg: ASbGncsNETdoFhLZD8OA4qJGEd2XhnchdRn5Qss96JmIZbG8hLDfgyjA2JQ20B1okQ7 p6GcZpdJn7sOksshgpqC7DcB4+8KAUV++wL6buBNvHDHYQgaA+I/+QWfcXztj7ExH3dLQhoOKvq SW2b5ImQrUzkY2CdGTC4RxqIYc6ro5HrlbH4dQQnxwn51TwOB6QVnlqWffL8Upoxw3243MsdCAK KMB+rLhf6wkdsYYwUMqcm/C4uG7gM3pm9JDJOHe5BRYqPqSA5CmV37J X-Google-Smtp-Source: AGHT+IEiQ2tUAAS+BI1a4/QVRkSdvODSnlij2z81kXfUGYxqU1CSoDjPXcWqNBcuUJCpT2u1golWfw== X-Received: by 2002:a05:600c:4f12:b0:434:9f77:e1dd with SMTP id 5b1f17b1804b1-434a9de7b32mr8960855e9.5.1732668881863; Tue, 26 Nov 2024 16:54:41 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:2203:ead5:e694:df3c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7d264dsm3647225e9.33.2024.11.26.16.54.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 16:54:41 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Chengwen Feng , Bruce Richardson , dpdk stable Subject: patch 'test/bonding: fix MAC address comparison' has been queued to stable release 22.11.7 Date: Wed, 27 Nov 2024 00:54:28 +0000 Message-ID: <20241127005435.188430-2-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241127005435.188430-1-luca.boccassi@gmail.com> References: <20241120234215.233355-28-luca.boccassi@gmail.com> <20241127005435.188430-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/d82f1f87600df76212a41eb4b9401ac18c7af5fb Thanks. Luca Boccassi --- >From d82f1f87600df76212a41eb4b9401ac18c7af5fb Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:23 -0800 Subject: [PATCH] test/bonding: fix MAC address comparison [ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index f342b04802..5dfee4639b 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -786,7 +786,7 @@ test_set_primary_slave(void) TEST_ASSERT_SUCCESS(rte_eth_macaddr_get(test_params->bonded_port_id, &read_mac_addr), "Failed to get mac address (port %d)", test_params->bonded_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonded port mac address not set to that of primary port\n"); -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 00:29:59.580661534 +0000 +++ 0002-test-bonding-fix-MAC-address-comparison.patch 2024-11-27 00:29:59.504711022 +0000 @@ -1 +1 @@ -From f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 Mon Sep 17 00:00:00 2001 +From d82f1f87600df76212a41eb4b9401ac18c7af5fb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 805613d7dd..b752a5ecbf 100644 +index f342b04802..5dfee4639b 100644 @@ -24,2 +25,2 @@ -@@ -792,7 +792,7 @@ test_set_primary_member(void) - &read_mac_addr), +@@ -786,7 +786,7 @@ test_set_primary_slave(void) + TEST_ASSERT_SUCCESS(rte_eth_macaddr_get(test_params->bonded_port_id, &read_mac_addr), @@ -27 +28 @@ - test_params->bonding_port_id); + test_params->bonded_port_id); @@ -31 +32 @@ - "bonding port mac address not set to that of primary port\n"); + "bonded port mac address not set to that of primary port\n");