From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2595F45D31 for ; Wed, 27 Nov 2024 01:55:00 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1C21C402E0; Wed, 27 Nov 2024 01:55:00 +0100 (CET) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by mails.dpdk.org (Postfix) with ESMTP id 8256A402E0 for ; Wed, 27 Nov 2024 01:54:59 +0100 (CET) Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-38231f84dccso4299487f8f.1 for ; Tue, 26 Nov 2024 16:54:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732668899; x=1733273699; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=faBcPCP6OeO7L/7kHT7KzVvKKRLvHVzyviqYWoKy6sI=; b=j6bypFUpgXIJj+mJOecZAAfT1bdvMKhae+5xNXxEOE/VKqOICqoZ6W8fR7PLPt7yIf cd4/AKLZUnQ/Sz8ojxgEVSr+dNalew+7cNcIE217e8b9aXIxXaIeIyiM2V9/CSO9XBT5 bkguiKBPtf3jZE4mwONLkGRmRZw7Lv+WH/VQRzZxkNyxouJxC0xNkD4qpZkvQvUFrIrD v48MnJtriDAxJUHeiwlLLSuCgZVbZ+YgOl0W7qbJj0Wu3LvUpZFz3DSdDz4AWk1iirDg qlibxCdkgMyPcVDyVwHHvECGa+oXMh7aSlQbX1YY8+Pka8gOmza31xXHwQgciNRBkdkR vNZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732668899; x=1733273699; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=faBcPCP6OeO7L/7kHT7KzVvKKRLvHVzyviqYWoKy6sI=; b=UXJfVLVLV1BboiOkBQNlmDU59jmiYr3WOPbCrFY7+S8WXE2/NIWtFTY5FIfr4jfhUw JkR7tJvI0B70lRqzik50TgIHTMzNAz3GYYj3Jd9XhTXfSSxgO6CNwt305Sg3Tx8rkLO7 v6QT4/y6FgxPTnaFERva7uy4S4/53FANhGVbzlGpv+c08UmIMJBQebIT9xR9epFtmYyI cTMO3one8usikNaPa/i5u1j0DkQtwEhVWdApqkvivchnZJPIT5nlFa9aXeDO8sT2UFDg yUcEmTEeq8q8E+tStsIwvqG6zeGiKoXhR6ri0kIUJ7nNGvl/oA75VqvBDfJbVutSWDJw d8BQ== X-Forwarded-Encrypted: i=1; AJvYcCV/5yD5VVph/Q0zi2VYR0Zni4ky/le92pEObkkpbwl5rqX3c69ijxq4e9JZAKUGzJRAkFIwJKY=@dpdk.org X-Gm-Message-State: AOJu0YwYguNqpPLwa6c1MkPXFAMURouky4JBs3A5PRQb3fQ6eiYHHbPK kEabYH5nluvTnbuoy05RBJsN07/HRmBmS3D0Iss9sOT86WU0X5CP X-Gm-Gg: ASbGncv0DPZx863n5gpjjm9Kr5+fi1NXTxhSKmdHe6f1+g51CVuiI3ZwyglXMAWszNV PBufZ2BnmMVM+LFYYG++zKe0dSanchVzJSRwDnZcCdRYEXAyGBEKCu5qRK7eL8ZL8YAkbJcqbDC fP3olLVKQf9GfmTI6hjpSIJLZsj2Kk3UXHYOaH/M5CgBDyO6FESl+NC5xNNGsuK+E/GTGNFgDGa AqAhoK0n3IHF7u4+EEk2NlZz0Bh1V0KSD7RaSMvSl/euLkW4OwYsHuP X-Google-Smtp-Source: AGHT+IHsNslR3JAcXz0QY0W2v4orHzPt7Mn9/bNk3BZkMTIjzg+35C79r0J/08VDCnrSxqA9Os98xQ== X-Received: by 2002:a5d:5850:0:b0:382:4493:ff8f with SMTP id ffacd0b85a97d-385c6eddb44mr588263f8f.43.1732668899023; Tue, 26 Nov 2024 16:54:59 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:2203:ead5:e694:df3c]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-3825fbc40a1sm14676322f8f.69.2024.11.26.16.54.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 16:54:57 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Bruce Richardson , Ajit Khaparde , Chengwen Feng , dpdk stable Subject: patch 'app/testpmd: remove redundant policy action condition' has been queued to stable release 22.11.7 Date: Wed, 27 Nov 2024 00:54:32 +0000 Message-ID: <20241127005435.188430-6-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241127005435.188430-1-luca.boccassi@gmail.com> References: <20241120234215.233355-28-luca.boccassi@gmail.com> <20241127005435.188430-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/8d8d069395174f14110cf1379fbe0870e5f26923 Thanks. Luca Boccassi --- >From 8d8d069395174f14110cf1379fbe0870e5f26923 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:29 -0800 Subject: [PATCH] app/testpmd: remove redundant policy action condition [ upstream commit 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d ] The loop over policy actions will always exit when it sees the flow end action, so the next check is redundant. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: f29fa2c59b85 ("app/testpmd: support policy actions per color") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Ajit Khaparde Acked-by: Chengwen Feng --- app/test-pmd/config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 83339ee455..189bf68223 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2137,7 +2137,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, for (act_n = 0, start = act; act->type != RTE_FLOW_ACTION_TYPE_END; act++) act_n++; - if (act_n && act->type == RTE_FLOW_ACTION_TYPE_END) + if (act_n > 0) policy.actions[i] = start; else policy.actions[i] = NULL; -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 00:29:59.696867912 +0000 +++ 0006-app-testpmd-remove-redundant-policy-action-condition.patch 2024-11-27 00:29:59.512711022 +0000 @@ -1 +1 @@ -From 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d Mon Sep 17 00:00:00 2001 +From 8d8d069395174f14110cf1379fbe0870e5f26923 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 4c2e7468426ae6be3f2a8f2d15e7d1222083eb9d ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -18,2 +19,2 @@ - app/test-pmd/config.c | 3 +-- - 1 file changed, 1 insertion(+), 2 deletions(-) + app/test-pmd/config.c | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) @@ -22 +23 @@ -index 28d45568ac..4e7fb69183 100644 +index 83339ee455..189bf68223 100644 @@ -25 +26 @@ -@@ -2288,7 +2288,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, +@@ -2137,7 +2137,7 @@ port_meter_policy_add(portid_t port_id, uint32_t policy_id, @@ -34,5 +34,0 @@ -@@ -7338,4 +7338,3 @@ show_mcast_macs(portid_t port_id) - printf(" %s\n", buf); - } - } --