From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4BEA645D31 for ; Wed, 27 Nov 2024 01:55:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3F5AE42D68; Wed, 27 Nov 2024 01:55:03 +0100 (CET) Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by mails.dpdk.org (Postfix) with ESMTP id B18A142D35 for ; Wed, 27 Nov 2024 01:55:01 +0100 (CET) Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-434a9f2da82so2733935e9.2 for ; Tue, 26 Nov 2024 16:55:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732668901; x=1733273701; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0lxXwp5J0jrfINjg5nEn/iUolCmL1GkoEGSukgkc4mo=; b=HfbMOxDKYRnXifIgNqaHJSwizQWAANyeN/lKnd+6cgBZTJLw3Ni+Dc7JAmduwfpTjq B6WBsWKZisfuba33N+uIbXfZrQeAuhPOevQ+KdNP3yMKakRHBo/XRU2eEUnx2XFxwkbo 9/ciqtEIc4JNfKGfo2CjDA2OmpNYyvA/wxKoz40qnE6ETfFXV8YO8BiYab+5Gg5yn0Ex TAdEG1LVp1VePtMX9qfRZjjvMYs1ljMmzFxgyVuRu6Em/Tz+//9l/AIwKi3jFXzeSjY+ EkgAYufORqC5biCah+/CYzbfFY95XXDO2ZEc/FtwhNO0crkSxuCmV2nqUwWWzvS0RfmS UjaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732668901; x=1733273701; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0lxXwp5J0jrfINjg5nEn/iUolCmL1GkoEGSukgkc4mo=; b=n+am9IffwXuEYOJyCFWT0ak+g/8tfen2iwTxjC79IUTXPuHIqSS7sSmt2p1uA4uj9O /uuoW18cIsosbUuaBj+T4ZXxWBL2KRpQ/9EnO6OaqsJdnj46K8s370O+LvDd190+iGlc UOQ286waZPkjSE24tthwqsP9IdKZxW2cuO+0KNfbQ1ARlBlvVycBmCJmTA7pC3B3i/f7 0p0MkQQGuhTy+CrlncGzCaTxmdwMEXDHtghJb4vDIQf8wIKBy+yLl4hT9Y6MxAnVvRWC /xacKA6ARY8tTWMJSX3kkLZGiEcLq7FRidyZk51iXo+hZGWpEqfdbH8zJ00OoB0ECUVX 5YLA== X-Forwarded-Encrypted: i=1; AJvYcCWq4xmH1zBZC2Ekwat51421SCCZVAajFaZ+82S54St/dkPCSfMo9M5UyMI2iDCBKf2p5lOZOEk=@dpdk.org X-Gm-Message-State: AOJu0Yx+kYXCLgXQCOT1D75X4Oo5egEhKwDbFKGdn5Nr8ojcc/z1lHMa MMkMD8zclKPoDqv0VaRrWOclNm63A3gFmyFxnLM8IJr4F4Y/bmQaIENX0A== X-Gm-Gg: ASbGnctx7xadOJDKditG4x9WhU5Pn0AmtSMcawf3tfdkmQ4+aUM7cNBBG3ethaDpioF PcTupC0G9AB+r+SNSfRXK2tA5jWE25iL8yYnFxhxcRUdKAvwbZGTRtGtSXjWWTdJSkr+qKox3gz RPUPQ/69QRRshcFAh46XL0OC1SV0BnruJunu6o0Y7l7ODamtU+Va+QVQ6nbLDUAfP2OiBz/tH9N 7rRiDzTFwi/UYhw1y1ppDFwevjff4+mFsij+4R//kyCPmWvbea1Xk6T X-Google-Smtp-Source: AGHT+IGxTduKymqJwcS/rzUnBNVN+WyFnPW0yO+siXNO6w8yUHdD+4rSv1R8YMMjomz4+mAL7emHhQ== X-Received: by 2002:a05:600c:5488:b0:434:932b:a469 with SMTP id 5b1f17b1804b1-434a9dfbdc0mr7663155e9.28.1732668901077; Tue, 26 Nov 2024 16:55:01 -0800 (PST) Received: from localhost ([2a01:4b00:d036:ae00:2203:ead5:e694:df3c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-434aa7cfb40sm3624875e9.27.2024.11.26.16.54.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Nov 2024 16:55:00 -0800 (PST) From: luca.boccassi@gmail.com To: Stephen Hemminger Cc: Ferruh Yigit , dpdk stable Subject: patch 'doc: correct definition of stats per queue feature' has been queued to stable release 22.11.7 Date: Wed, 27 Nov 2024 00:54:33 +0000 Message-ID: <20241127005435.188430-7-luca.boccassi@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20241127005435.188430-1-luca.boccassi@gmail.com> References: <20241120234215.233355-28-luca.boccassi@gmail.com> <20241127005435.188430-1-luca.boccassi@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 22.11.7 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 11/29/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/bluca/dpdk-stable This queued commit can be viewed at: https://github.com/bluca/dpdk-stable/commit/fec1fb480002cc05072bab2e2cfc44cdee4b6758 Thanks. Luca Boccassi --- >From fec1fb480002cc05072bab2e2cfc44cdee4b6758 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 10 Oct 2024 18:38:27 -0700 Subject: [PATCH] doc: correct definition of stats per queue feature [ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] Change the documentation to match current usage of this feature in the NIC table. Moved this sub heading to be after basic stats because the queue stats reported now are in the same structure. Although the "Stats per Queue" feature was originally intended to be related to stats mapping, the overwhelming majority of drivers report this feature with a different meaning. Hopefully in later release the per-queue stats limitations can be fixed, but this requires and API, ABI, and lots of driver changes. Fixes: dad1ec72a377 ("doc: document NIC features") Signed-off-by: Stephen Hemminger Acked-by: Ferruh Yigit --- doc/guides/nics/features.rst | 34 ++++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/doc/guides/nics/features.rst b/doc/guides/nics/features.rst index 4332ff0a31..5e662ba42b 100644 --- a/doc/guides/nics/features.rst +++ b/doc/guides/nics/features.rst @@ -705,14 +705,32 @@ Basic stats Support basic statistics such as: ipackets, opackets, ibytes, obytes, imissed, ierrors, oerrors, rx_nombuf. -And per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. - These apply to all drivers. * **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. * **[related] API**: ``rte_eth_stats_get``, ``rte_eth_stats_reset()``. +.. _nic_features_stats_per_queue: + +Stats per queue +--------------- + +Supports per queue stats: q_ipackets, q_opackets, q_ibytes, q_obytes, q_errors. +Statistics only supplied for first ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` (16) queues. +If driver does not support this feature the per queue stats will be zero. + +* **[implements] eth_dev_ops**: ``stats_get``, ``stats_reset``. +* **[related] API**: ``rte_eth_stats_get``, ``rte_eth_stats_reset()``. + +May also support configuring per-queue stat counter mapping. +Used by some drivers to workaround HW limitations. + +* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. +* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, + ``rte_eth_dev_set_tx_queue_stats_mapping()``. + + .. _nic_features_extended_stats: Extended stats @@ -727,18 +745,6 @@ Supports Extended Statistics, changes from driver to driver. ``rte_eth_xstats_get_names_by_id()``, ``rte_eth_xstats_get_id_by_name()``. -.. _nic_features_stats_per_queue: - -Stats per queue ---------------- - -Supports configuring per-queue stat counter mapping. - -* **[implements] eth_dev_ops**: ``queue_stats_mapping_set``. -* **[related] API**: ``rte_eth_dev_set_rx_queue_stats_mapping()``, - ``rte_eth_dev_set_tx_queue_stats_mapping()``. - - .. _nic_features_congestion_management: Congestion management -- 2.45.2 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 00:29:59.729481755 +0000 +++ 0007-doc-correct-definition-of-stats-per-queue-feature.patch 2024-11-27 00:29:59.512711022 +0000 @@ -1 +1 @@ -From 71eae7fe3eac90b70200460c714d1c13ee43dc25 Mon Sep 17 00:00:00 2001 +From fec1fb480002cc05072bab2e2cfc44cdee4b6758 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 71eae7fe3eac90b70200460c714d1c13ee43dc25 ] + @@ -19 +20,0 @@ -Cc: stable@dpdk.org @@ -28 +29 @@ -index 0508f118fe..8bd448139e 100644 +index 4332ff0a31..5e662ba42b 100644 @@ -31 +32 @@ -@@ -729,14 +729,32 @@ Basic stats +@@ -705,14 +705,32 @@ Basic stats @@ -66 +67 @@ -@@ -751,18 +769,6 @@ Supports Extended Statistics, changes from driver to driver. +@@ -727,18 +745,6 @@ Supports Extended Statistics, changes from driver to driver.