From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B39945DB9 for ; Wed, 27 Nov 2024 18:19:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 472A6402DE; Wed, 27 Nov 2024 18:19:53 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 98330402DE for ; Wed, 27 Nov 2024 18:19:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732727992; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tgTZUcyK40l8CMoDJCEGnqJBNBV4f6kpA+S04ZUWfz0=; b=exHB7M04lqua4ebmUNxjfkPNKvWM7yI+94kDkCOMfS1Xrl4wJxvUjP9DpC+4qx3xLxJg3x hkGggqgVRxksQJrauUHm+cOI7c4iWikLl40K20nxHH0VIKjXyUj+muC2Yhvhwykd8ldLye bWTPVNqH+T4CP3l8nCV5KeINU4LY1Pk= Received: from mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-477-wJjEtFPONha8sKZmmmQeyQ-1; Wed, 27 Nov 2024 12:19:50 -0500 X-MC-Unique: wJjEtFPONha8sKZmmmQeyQ-1 X-Mimecast-MFC-AGG-ID: wJjEtFPONha8sKZmmmQeyQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-04.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 346631955BCF; Wed, 27 Nov 2024 17:19:49 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 686623003B71; Wed, 27 Nov 2024 17:19:46 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , =?UTF-8?q?Morten=20Br=C3=B8rup?= , Konstantin Ananyev , Wathsala Vithanage , dpdk stable Subject: patch 'dma/idxd: fix free function mismatch in device probe' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:17:17 +0000 Message-ID: <20241127171916.690404-10-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PHGF8hOC7U_Js2MTG4SEyZdPthDWcxayl802LBVP3O4_1732727989 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/7872b67b772c5298b18e49b3e08ba33c18a3a667 Thanks. Kevin --- >From 7872b67b772c5298b18e49b3e08ba33c18a3a667 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Tue, 8 Oct 2024 09:47:07 -0700 Subject: [PATCH] dma/idxd: fix free function mismatch in device probe MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit [ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] The data structure is allocated with rte_malloc and incorrectly freed in cleanup logic using free. Bugzilla ID: 1549 Fixes: 9449330a8458 ("dma/idxd: create dmadev instances on PCI probe") Signed-off-by: Stephen Hemminger Reviewed-by: Bruce Richardson Acked-by: Morten Brørup Acked-by: Konstantin Ananyev Acked-by: Wathsala Vithanage --- drivers/dma/idxd/idxd_pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/idxd/idxd_pci.c b/drivers/dma/idxd/idxd_pci.c index 2f8ec06d9e..3dd25bf0b1 100644 --- a/drivers/dma/idxd/idxd_pci.c +++ b/drivers/dma/idxd/idxd_pci.c @@ -293,5 +293,5 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, err: - free(pci); + rte_free(pci); return err_code; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:38.651659014 +0000 +++ 0010-dma-idxd-fix-free-function-mismatch-in-device-probe.patch 2024-11-27 17:17:38.161269041 +0000 @@ -1 +1 @@ -From 91b026fb46d987e68c1152b0bb5f0bc8f1f274db Mon Sep 17 00:00:00 2001 +From 7872b67b772c5298b18e49b3e08ba33c18a3a667 Mon Sep 17 00:00:00 2001 @@ -8,0 +9,2 @@ +[ upstream commit 91b026fb46d987e68c1152b0bb5f0bc8f1f274db ] + @@ -14 +15,0 @@ -Cc: stable@dpdk.org @@ -26 +27 @@ -index 60ac219559..6ed03e96da 100644 +index 2f8ec06d9e..3dd25bf0b1 100644 @@ -29 +30 @@ -@@ -302,5 +302,5 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd, +@@ -293,5 +293,5 @@ init_pci_device(struct rte_pci_device *dev, struct idxd_dmadev *idxd,