From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E82F245DB9 for ; Wed, 27 Nov 2024 18:23:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E4890402DE; Wed, 27 Nov 2024 18:23:16 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id C7C1540A6F for ; Wed, 27 Nov 2024 18:23:14 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vpsQufs055BqHQZZcyKohr/GsMr6HES4fgsqqDpSfUk=; b=Vge3xKU2xiqBRfrN3cI5pQSQnnW0k4mrj0GzYaP0RumKpeoYmoE0C/oTnj6B6b2QDx9Z47 QwAcraaGxRZe3RWO9u0jYqPH0/irOoJOQ30lPxJX++QQIXmJGkFo6rm+E/ztxRfwQa94oI 9ZaMLT+pfs+0O+/NeJjvuYWNL3jBR0s= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-627-6GXQhKayMq6BL6QoO7FmPA-1; Wed, 27 Nov 2024 12:23:11 -0500 X-MC-Unique: 6GXQhKayMq6BL6QoO7FmPA-1 X-Mimecast-MFC-AGG-ID: 6GXQhKayMq6BL6QoO7FmPA Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6B3D01955F45; Wed, 27 Nov 2024 17:23:10 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 2BB6030001A2; Wed, 27 Nov 2024 17:23:08 +0000 (UTC) From: Kevin Traynor To: Hemant Agrawal Cc: dpdk stable Subject: patch 'examples/l2fwd-event: fix spinlock handling' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:53 +0000 Message-ID: <20241127171916.690404-106-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rnmfMuO84ToaWI7Z5LZCxbhPpmAHm7Sz7tHpmZDkwjg_1732728190 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/0d9ea65b3ba613526a92f38bf07b3a317218fc36 Thanks. Kevin --- >From 0d9ea65b3ba613526a92f38bf07b3a317218fc36 Mon Sep 17 00:00:00 2001 From: Hemant Agrawal Date: Thu, 14 Nov 2024 13:14:36 +0530 Subject: [PATCH] examples/l2fwd-event: fix spinlock handling [ upstream commit 1f41deac447d7938198a2acdd1b7862161feef91 ] Detected by pvs-studio Bug 89-93: very suspicious synchronization The analyzer issued a pack of V1020 warnings that a resource might remain blocked. Fixes: 080f57bceca4 ("examples/l2fwd-event: add eventdev main loop") Signed-off-by: Hemant Agrawal --- examples/l2fwd-event/l2fwd_event.c | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/l2fwd-event/l2fwd_event.c b/examples/l2fwd-event/l2fwd_event.c index 6df3cdfeab..7f3f308886 100644 --- a/examples/l2fwd-event/l2fwd_event.c +++ b/examples/l2fwd-event/l2fwd_event.c @@ -142,4 +142,5 @@ l2fwd_get_free_event_port(struct l2fwd_event_resources *evt_rsrc) if (index >= evt_rsrc->evp.nb_ports) { printf("No free event port is available\n"); + rte_spinlock_unlock(&evt_rsrc->evp.lock); return -1; } -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.603175328 +0000 +++ 0106-examples-l2fwd-event-fix-spinlock-handling.patch 2024-11-27 17:17:38.329269912 +0000 @@ -1 +1 @@ -From 1f41deac447d7938198a2acdd1b7862161feef91 Mon Sep 17 00:00:00 2001 +From 0d9ea65b3ba613526a92f38bf07b3a317218fc36 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 1f41deac447d7938198a2acdd1b7862161feef91 ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -20 +21 @@ -index 22472027b9..416957384b 100644 +index 6df3cdfeab..7f3f308886 100644