From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16B4845DB9 for ; Wed, 27 Nov 2024 18:23:18 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1324140A6F; Wed, 27 Nov 2024 18:23:18 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0813E40A70 for ; Wed, 27 Nov 2024 18:23:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728196; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0BtyXkdslJAoNeo/pIqJTQw7w+YwURJ45f52zdhYdpw=; b=LCNfAfD/NsClAxqMyBPxPjMv/EeOOTefofo7cIA5OJi2tT/gOoL01FcR+B7ZWr7vFgcP6g QJfYHOedyW0sjueTGKargdedFE4g7le1CGk8Ru4MrIyebtdsmoX/0G6oJU/v8LuvPiXxJO QaF4IZqibrmaIP9JhZxZX9JXloSXWjU= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-670-MhUx91bvOtedefIudXYRuQ-1; Wed, 27 Nov 2024 12:23:13 -0500 X-MC-Unique: MhUx91bvOtedefIudXYRuQ-1 X-Mimecast-MFC-AGG-ID: MhUx91bvOtedefIudXYRuQ Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 48EF31955F41; Wed, 27 Nov 2024 17:23:12 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id E078A300019E; Wed, 27 Nov 2024 17:23:10 +0000 (UTC) From: Kevin Traynor To: Bruce Richardson Cc: Jerin Jacob , dpdk stable Subject: patch 'eventdev: fix possible array underflow/overflow' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:18:54 +0000 Message-ID: <20241127171916.690404-107-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: fVJhLrNpL9CvXWAIiHll6YdLiOXX7LfUTn6M0Eeb8ZE_1732728192 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/2b3091f5dee0655172d6742283bd47470c8b2aa9 Thanks. Kevin --- >From 2b3091f5dee0655172d6742283bd47470c8b2aa9 Mon Sep 17 00:00:00 2001 From: Bruce Richardson Date: Thu, 14 Nov 2024 11:55:38 +0000 Subject: [PATCH] eventdev: fix possible array underflow/overflow [ upstream commit 952b24bd0475450e548d4aafae7d8cf48258402b ] If the number of interrupts is zero, then indexing an array by "nb_rx_intr - 1" will cause an out-of-bounds write Fix this by putting in a check that nb_rx_intr > 0 before doing the array write. Coverity issue: 448870 Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter") Signed-off-by: Bruce Richardson Acked-by: Jerin Jacob --- lib/eventdev/rte_event_eth_rx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c index 54115cc899..e223728c86 100644 --- a/lib/eventdev/rte_event_eth_rx_adapter.c +++ b/lib/eventdev/rte_event_eth_rx_adapter.c @@ -2247,5 +2247,5 @@ rxa_sw_add(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id, dev_info->intr_queue[i] = i; } else { - if (!rxa_intr_queue(dev_info, rx_queue_id)) + if (!rxa_intr_queue(dev_info, rx_queue_id) && nb_rx_intr > 0) dev_info->intr_queue[nb_rx_intr - 1] = rx_queue_id; -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.631448320 +0000 +++ 0107-eventdev-fix-possible-array-underflow-overflow.patch 2024-11-27 17:17:38.331269922 +0000 @@ -1 +1 @@ -From 952b24bd0475450e548d4aafae7d8cf48258402b Mon Sep 17 00:00:00 2001 +From 2b3091f5dee0655172d6742283bd47470c8b2aa9 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 952b24bd0475450e548d4aafae7d8cf48258402b ] + @@ -12 +13,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 3ee20d95f3..39674c4604 100644 +index 54115cc899..e223728c86 100644 @@ -24 +25 @@ -@@ -2300,5 +2300,5 @@ rxa_sw_add(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id, +@@ -2247,5 +2247,5 @@ rxa_sw_add(struct event_eth_rx_adapter *rx_adapter, uint16_t eth_dev_id,