From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE03D45DB9 for ; Wed, 27 Nov 2024 18:23:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EA3EA40695; Wed, 27 Nov 2024 18:23:30 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id D92EA402DE for ; Wed, 27 Nov 2024 18:23:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JreWYNsKCP6nh/n0TizWdb2n9In8fRtYc3fr5U5Q1VU=; b=F8Ttb3lxU1qWM5gpR3tt2p88IohPtz21C1JrpZ8iEW0eIN4FC4hlPbM/pHU8JZftIOBmf1 cBYI+QH71ixHvBz5aS0z2De/qZYEpzkWw2zPgSl62WliDL3a1a/DE1nEUK+hSFVN8dRp94 Wlc3T/9vA6xu4hkkQoeslNZPwtRQjMs= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-114-2_EBF5PpPgezYYtx_sf08Q-1; Wed, 27 Nov 2024 12:23:25 -0500 X-MC-Unique: 2_EBF5PpPgezYYtx_sf08Q-1 X-Mimecast-MFC-AGG-ID: 2_EBF5PpPgezYYtx_sf08Q Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 8C3CA19560B2; Wed, 27 Nov 2024 17:23:24 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id C880730001A2; Wed, 27 Nov 2024 17:23:22 +0000 (UTC) From: Kevin Traynor To: Fidaullah Noonari Cc: Stephen Hemminger , Chengwen Feng , dpdk stable Subject: patch 'app/procinfo: fix leak on exit' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:19:00 +0000 Message-ID: <20241127171916.690404-113-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: SgbyoW_cKAyYsc1QBQod3ZcZHojIFR63i29jKdRREeY_1732728204 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/36f4854030e5c702a76f2169b9a502b9bb87b199 Thanks. Kevin --- >From 36f4854030e5c702a76f2169b9a502b9bb87b199 Mon Sep 17 00:00:00 2001 From: Fidaullah Noonari Date: Thu, 3 Oct 2024 19:48:29 -0700 Subject: [PATCH] app/procinfo: fix leak on exit [ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] When app is launched with -m proc-info exit without rte_eal_cleanup() causing memory leakage. This commit resolves the memory leakage issue and closes app properly. Bugzilla ID: 898 Fixes: 67684d1e87b6 ("app/procinfo: call EAL cleanup before exit") Fixes: 674bb3906931 ("app/procinfo: display eventdev xstats") Signed-off-by: Fidaullah Noonari Acked-by: Stephen Hemminger Acked-by: Chengwen Feng --- app/proc-info/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/proc-info/main.c b/app/proc-info/main.c index b52c3ffbc5..8030c10c25 100644 --- a/app/proc-info/main.c +++ b/app/proc-info/main.c @@ -1500,5 +1500,5 @@ main(int argc, char **argv) if (mem_info) { meminfo_display(); - return 0; + goto cleanup; } @@ -1568,4 +1568,5 @@ main(int argc, char **argv) rte_eth_dev_close(i); +cleanup: ret = rte_eal_cleanup(); if (ret) -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.815780350 +0000 +++ 0113-app-procinfo-fix-leak-on-exit.patch 2024-11-27 17:17:38.345269995 +0000 @@ -1 +1 @@ -From 8a171e52ed8b26f768ced79a22286914ebd30180 Mon Sep 17 00:00:00 2001 +From 36f4854030e5c702a76f2169b9a502b9bb87b199 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 8a171e52ed8b26f768ced79a22286914ebd30180 ] + @@ -13 +14,0 @@ -Cc: stable@dpdk.org @@ -19,2 +20,2 @@ - app/proc-info/main.c | 5 +++-- - 1 file changed, 3 insertions(+), 2 deletions(-) + app/proc-info/main.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) @@ -23 +24 @@ -index 6886eb373a..e1272164b1 100644 +index b52c3ffbc5..8030c10c25 100644 @@ -26 +27 @@ -@@ -2172,9 +2172,9 @@ main(int argc, char **argv) +@@ -1500,5 +1500,5 @@ main(int argc, char **argv) @@ -33,6 +34 @@ - if (eventdev_xstats() > 0) -- return 0; -+ goto cleanup; - - nb_ports = rte_eth_dev_count_avail(); -@@ -2257,4 +2257,5 @@ main(int argc, char **argv) +@@ -1568,4 +1568,5 @@ main(int argc, char **argv)