From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6481045DB9 for ; Wed, 27 Nov 2024 18:23:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 60F18402DE; Wed, 27 Nov 2024 18:23:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 65F4540A6E for ; Wed, 27 Nov 2024 18:23:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728215; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eKoBPl6bZTPjXnv4zY8ka0hUEugm06Ngqb+UbDpKd/0=; b=OBAaRjvnoFD6vShxY4KEp1VI58kgIiFsQv8E9k+CjVOTZiXgXI2VPiRNf4flaPCWQM/Kxc 8j+/PViC1cuaMRNOe1L1Ca7bLXOZ/j1BYddUYRGqO3e+4qCCMM/XM15lwtJPuYh1SM1OuX 1ml1wIrCE8iPM5MKe7ESvJsRkPAM3FE= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-151-9zt57LxaPyaLQH5-vc_PFw-1; Wed, 27 Nov 2024 12:23:31 -0500 X-MC-Unique: 9zt57LxaPyaLQH5-vc_PFw-1 X-Mimecast-MFC-AGG-ID: 9zt57LxaPyaLQH5-vc_PFw Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id ACA9819560A3; Wed, 27 Nov 2024 17:23:30 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 0AEEA300019E; Wed, 27 Nov 2024 17:23:28 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , Chengwen Feng , dpdk stable Subject: patch 'test/bonding: fix loop on members' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:19:03 +0000 Message-ID: <20241127171916.690404-116-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: JgG4FxyiRbWVC7BKiP-eKOYOyENoTuSg47ND8CSCp6Q_1732728210 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/1b2707e26c3ccafaf8d11bf7f5ec671e41902ebb Thanks. Kevin --- >From 1b2707e26c3ccafaf8d11bf7f5ec671e41902ebb Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:22 -0800 Subject: [PATCH] test/bonding: fix loop on members [ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] Do not use same variable for outer and inner loop in bonding test. Since the loop is just freeing the resulting burst use bulk free. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Chengwen Feng --- app/test/test_link_bonding.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 0d5cfd43c4..2f8a9bebf5 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -2270,10 +2270,5 @@ test_activebackup_rx_burst(void) /* free mbufs */ - for (i = 0; i < MAX_PKT_BURST; i++) { - if (rx_pkt_burst[i] != NULL) { - rte_pktmbuf_free(rx_pkt_burst[i]); - rx_pkt_burst[i] = NULL; - } - } + rte_pktmbuf_free_bulk(rx_pkt_burst, burst_size); /* reset bonded device stats */ -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.904605508 +0000 +++ 0116-test-bonding-fix-loop-on-members.patch 2024-11-27 17:17:38.352270031 +0000 @@ -1 +1 @@ -From 112ce3917674b7e316776305d7e27778d17eb1b7 Mon Sep 17 00:00:00 2001 +From 1b2707e26c3ccafaf8d11bf7f5ec671e41902ebb Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 112ce3917674b7e316776305d7e27778d17eb1b7 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 4d54706c21..805613d7dd 100644 +index 0d5cfd43c4..2f8a9bebf5 100644 @@ -24 +25 @@ -@@ -2289,10 +2289,5 @@ test_activebackup_rx_burst(void) +@@ -2270,10 +2270,5 @@ test_activebackup_rx_burst(void) @@ -35 +36 @@ - /* reset bonding device stats */ + /* reset bonded device stats */