From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8258245DB9 for ; Wed, 27 Nov 2024 18:23:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7F0CC402DE; Wed, 27 Nov 2024 18:23:38 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id BB1DB40695 for ; Wed, 27 Nov 2024 18:23:37 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DW4ByYbYthYKPphYhtF6xcoI43vCMSOdSvsmaif67T4=; b=Y/pg+fvukX/Se8gaXwXHUQMGF/dPj1wWCEvT1sI/Fuz7A9DKafttHMTjBILmDgrF+XlZVz 7Gd9O5mmTE1mFd88NLt2ImyDFdZF1uHdKpcwG8T0RZbhrB0jfjtd1YfQTioW8rij6r/wy5 vfyCakdEqCAHOmK5mi2MhYpqOF/3ySY= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-568-ZxECeX8cNKCZy4HdHF_lZg-1; Wed, 27 Nov 2024 12:23:34 -0500 X-MC-Unique: ZxECeX8cNKCZy4HdHF_lZg-1 X-Mimecast-MFC-AGG-ID: ZxECeX8cNKCZy4HdHF_lZg Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id D781D195604F; Wed, 27 Nov 2024 17:23:32 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 3658C300019E; Wed, 27 Nov 2024 17:23:30 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Chengwen Feng , Bruce Richardson , dpdk stable Subject: patch 'test/bonding: fix MAC address comparison' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:19:04 +0000 Message-ID: <20241127171916.690404-117-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 2O3gPwOZNwRtf83tKbFf1pOkjoiunn2edyQULWpFNAg_1732728213 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/19e497edc761191053d0333cf7c42e042154cebc Thanks. Kevin --- >From 19e497edc761191053d0333cf7c42e042154cebc Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:23 -0800 Subject: [PATCH] test/bonding: fix MAC address comparison [ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] The first argument of 'memcmp' function was equal to the second argument. Therefore ASSERT would always be true. Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: 92073ef961ee ("bond: unit tests") Signed-off-by: Stephen Hemminger Acked-by: Chengwen Feng Acked-by: Bruce Richardson --- app/test/test_link_bonding.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c index 2f8a9bebf5..5e6a73133b 100644 --- a/app/test/test_link_bonding.c +++ b/app/test/test_link_bonding.c @@ -788,5 +788,5 @@ test_set_primary_slave(void) "Failed to get mac address (port %d)", test_params->bonded_port_id); - TEST_ASSERT_SUCCESS(memcmp(&read_mac_addr, &read_mac_addr, + TEST_ASSERT_SUCCESS(memcmp(expected_mac_addr, &read_mac_addr, sizeof(read_mac_addr)), "bonded port mac address not set to that of primary port\n"); -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:41.936117526 +0000 +++ 0117-test-bonding-fix-MAC-address-comparison.patch 2024-11-27 17:17:38.355270047 +0000 @@ -1 +1 @@ -From f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 Mon Sep 17 00:00:00 2001 +From 19e497edc761191053d0333cf7c42e042154cebc Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit f7f85632daf6d6f525d443f90a0ac3c8a3e40b72 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index 805613d7dd..b752a5ecbf 100644 +index 2f8a9bebf5..5e6a73133b 100644 @@ -24 +25 @@ -@@ -793,5 +793,5 @@ test_set_primary_member(void) +@@ -788,5 +788,5 @@ test_set_primary_slave(void) @@ -26 +27 @@ - test_params->bonding_port_id); + test_params->bonded_port_id); @@ -30 +31 @@ - "bonding port mac address not set to that of primary port\n"); + "bonded port mac address not set to that of primary port\n");