From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 04B7345DB9 for ; Wed, 27 Nov 2024 18:23:45 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 00BF6402DE; Wed, 27 Nov 2024 18:23:45 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id A523640A6F for ; Wed, 27 Nov 2024 18:23:43 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1732728223; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zBvgy/RwME52JmLBOQRx76WEJlzF22ELB6gXBvN1nr0=; b=bKaFW3KaC4hxs2eo14zHTBkjgB2opFROPwxVjEdaCsqpKWxINjI7MaKf4yoL6UdmeJTHxo iqP/cWf0a+i3QXGZZuzA74Sy+sWnd3QdCpbIMWuDOxcqfBlZzMlvZVO82wc+34PM3Y5HEU zkCUcGxhIjwWbhxQcHPHBVz3R8i9o7Q= Received: from mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-669-80YHbK3LPRWy24CqlmlA8g-1; Wed, 27 Nov 2024 12:23:40 -0500 X-MC-Unique: 80YHbK3LPRWy24CqlmlA8g-1 X-Mimecast-MFC-AGG-ID: 80YHbK3LPRWy24CqlmlA8g Received: from mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 326481936121; Wed, 27 Nov 2024 17:23:39 +0000 (UTC) Received: from rh.redhat.com (unknown [10.39.192.52]) by mx-prod-int-01.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 6B9A4300019E; Wed, 27 Nov 2024 17:23:37 +0000 (UTC) From: Kevin Traynor To: Stephen Hemminger Cc: Bruce Richardson , Aaron Conole , dpdk stable Subject: patch 'test/eal: fix lcore check' has been queued to stable release 21.11.9 Date: Wed, 27 Nov 2024 17:19:07 +0000 Message-ID: <20241127171916.690404-120-ktraynor@redhat.com> In-Reply-To: <20241127171916.690404-1-ktraynor@redhat.com> References: <20241127171916.690404-1-ktraynor@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.4 X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 1KEO4kfDIZsutnMzDHpMQ1GBini8IqxYBiESy4K618M_1732728219 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit content-type: text/plain; charset="US-ASCII"; x-default=true X-BeenThere: stable@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: patches for DPDK stable branches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: stable-bounces@dpdk.org Hi, FYI, your patch has been queued to stable release 21.11.9 Note it hasn't been pushed to http://dpdk.org/browse/dpdk-stable yet. It will be pushed if I get no objections before 12/02/24. So please shout if anyone has objections. Also note that after the patch there's a diff of the upstream commit vs the patch applied to the branch. This will indicate if there was any rebasing needed to apply to the stable branch. If there were code changes for rebasing (ie: not only metadata diffs), please double check that the rebase was correctly done. Queued patches are on a temporary branch at: https://github.com/kevintraynor/dpdk-stable This queued commit can be viewed at: https://github.com/kevintraynor/dpdk-stable/commit/78d1ebcc9f5fff5357985b14b8ffa1bf72e110f3 Thanks. Kevin --- >From 78d1ebcc9f5fff5357985b14b8ffa1bf72e110f3 Mon Sep 17 00:00:00 2001 From: Stephen Hemminger Date: Thu, 21 Nov 2024 10:23:28 -0800 Subject: [PATCH] test/eal: fix lcore check [ upstream commit 357f915ef5e1280d921fb103ea33066e7a888ed2 ] The expression for checking which lcore is enabled for 0-7 was wrong (missing case for 6). Link: https://pvs-studio.com/en/blog/posts/cpp/1179/ Fixes: b0209034f2bb ("test/eal: check number of cores before running subtests") Signed-off-by: Stephen Hemminger Acked-by: Bruce Richardson Acked-by: Aaron Conole --- app/test/test_eal_flags.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c index 8916ea5882..860e11e268 100644 --- a/app/test/test_eal_flags.c +++ b/app/test/test_eal_flags.c @@ -590,6 +590,6 @@ test_missing_c_flag(void) if (rte_lcore_is_enabled(0) && rte_lcore_is_enabled(1) && rte_lcore_is_enabled(2) && rte_lcore_is_enabled(3) && - rte_lcore_is_enabled(3) && rte_lcore_is_enabled(5) && - rte_lcore_is_enabled(4) && rte_lcore_is_enabled(7) && + rte_lcore_is_enabled(4) && rte_lcore_is_enabled(5) && + rte_lcore_is_enabled(6) && rte_lcore_is_enabled(7) && launch_proc(argv29) != 0) { printf("Error - " -- 2.47.0 --- Diff of the applied patch vs upstream commit (please double-check if non-empty: --- --- - 2024-11-27 17:17:42.024067470 +0000 +++ 0120-test-eal-fix-lcore-check.patch 2024-11-27 17:17:38.357270057 +0000 @@ -1 +1 @@ -From 357f915ef5e1280d921fb103ea33066e7a888ed2 Mon Sep 17 00:00:00 2001 +From 78d1ebcc9f5fff5357985b14b8ffa1bf72e110f3 Mon Sep 17 00:00:00 2001 @@ -5,0 +6,2 @@ +[ upstream commit 357f915ef5e1280d921fb103ea33066e7a888ed2 ] + @@ -11 +12,0 @@ -Cc: stable@dpdk.org @@ -21 +22 @@ -index d37d6b8627..e32f83d3c8 100644 +index 8916ea5882..860e11e268 100644 @@ -24 +25 @@ -@@ -678,6 +678,6 @@ test_missing_c_flag(void) +@@ -590,6 +590,6 @@ test_missing_c_flag(void)